From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Mike Rapoport <rppt@kernel.org>, <linux-mm@kvack.org>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<ying.huang@intel.com>
Subject: Re: [PATCH v2 08/13] mm: page_alloc: split out DEBUG_PAGEALLOC
Date: Wed, 17 May 2023 19:10:38 -0700 [thread overview]
Message-ID: <20230517191038.437a3750caa877cde58c054f@linux-foundation.org> (raw)
In-Reply-To: <f7b5aec9-f9e0-dd51-f9a0-c6af227537fd@huawei.com>
On Thu, 18 May 2023 09:35:29 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> > We're irritatingly inconsistent about whether there's an underscore.
> >
> > akpm:/usr/src/25> grep page_alloc mm/*c|wc -l
> > 49
> > akpm:/usr/src/25> grep pagealloc mm/*c|wc -l
> > 28
>
> All the 28 pagealloc naming is from DEBUG_PAGEALLOC feature, they chould
> be changed to page_alloc except the cmdline, but it will lead to long
> function name and don't gain too much advantage, so keep unchange?
Sure, it's probably not the worst thing in there. I was just having
a moan.
next prev parent reply other threads:[~2023-05-18 2:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 6:38 [PATCH -next v2 00/13] mm: page_alloc: misc cleanup and refector Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 01/13] mm: page_alloc: move mirrored_kernelcore into mm_init.c Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 02/13] mm: page_alloc: move init_on_alloc/free() " Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 03/13] mm: page_alloc: move set_zone_contiguous() " Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 04/13] mm: page_alloc: collect mem statistic into show_mem.c Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 05/13] mm: page_alloc: squash page_is_consistent() Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 06/13] mm: page_alloc: remove alloc_contig_dump_pages() stub Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 07/13] mm: page_alloc: split out FAIL_PAGE_ALLOC Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 08/13] mm: page_alloc: split out DEBUG_PAGEALLOC Kefeng Wang
2023-05-16 22:22 ` Andrew Morton
2023-05-18 1:35 ` Kefeng Wang
2023-05-18 2:10 ` Andrew Morton [this message]
2023-05-16 6:38 ` [PATCH v2 09/13] mm: page_alloc: move mark_free_page() into snapshot.c Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 10/13] mm: page_alloc: move pm_* function into power Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 11/13] mm: vmscan: use gfp_has_io_fs() Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 12/13] mm: page_alloc: move sysctls into it own fils Kefeng Wang
2023-05-16 6:38 ` [PATCH v2 13/13] mm: page_alloc: move is_check_pages_enabled() into page_alloc.c Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517191038.437a3750caa877cde58c054f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=osalvador@suse.de \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@intel.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox