From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BBE3C77B75 for ; Wed, 17 May 2023 15:04:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BE12900005; Wed, 17 May 2023 11:04:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06E54900003; Wed, 17 May 2023 11:04:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E785B900005; Wed, 17 May 2023 11:04:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA2FC900003 for ; Wed, 17 May 2023 11:04:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6FA4D1A067A for ; Wed, 17 May 2023 15:04:51 +0000 (UTC) X-FDA: 80800069182.30.0462BF2 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf26.hostedemail.com (Postfix) with ESMTP id 9BADC14006B for ; Wed, 17 May 2023 15:03:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nYRCTEvO; spf=pass (imf26.hostedemail.com: domain of revest@chromium.org designates 209.85.128.41 as permitted sender) smtp.mailfrom=revest@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684335833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oipxQEZj91stE4t+lxud7GTslgXbD/udBSL61+uH1L8=; b=iEmuwjYoO1ZmCshuHWlaAyhCnloNY7WCN8XZK4KXKY3wDmj/lMEojYozMtCegSSPa+/ST0 iNOKCKk2S/DFB/tJCL4duHTouNDBaCAgqlNxNpJ689CZp6VDvCaHyzKlJJCeyzhqCYYWQs 0+W/O8lz4UIEr0U+btqeOeeUF6SYEKI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684335833; a=rsa-sha256; cv=none; b=Q8Jb6nQu+0iASRrtE0KpgOrIJYx4UyMWC2XTLJ8Ks1g3Y56z0wTFg2iviI/1mJeEWMQCDx J8B/CyN8qqgwhGkcY44YRFsks1jXB4JQTvBYYZ6fVokWiPewICu54jXYsF8IZPrOr0cNmF c96vIL/Fjt/DpQqUS79xzduQRcn6PRA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nYRCTEvO; spf=pass (imf26.hostedemail.com: domain of revest@chromium.org designates 209.85.128.41 as permitted sender) smtp.mailfrom=revest@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-3f4c6c4b425so6439315e9.2 for ; Wed, 17 May 2023 08:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684335831; x=1686927831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oipxQEZj91stE4t+lxud7GTslgXbD/udBSL61+uH1L8=; b=nYRCTEvOWhb0FzekCMnJ6+34uErlW9tdW8D7eUgNnDXRCvoUVAdioTe4bDYStyLbtZ +wOkz4pBqp/FKbfovlnRGHcbww4zHsdW1pobdsCTi7FymG/8pUeZAv4ix9bN6fTKR5K0 yeoouszxWZdws1CxpHmjxNcnk9WQ5iIHC5Qms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684335831; x=1686927831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oipxQEZj91stE4t+lxud7GTslgXbD/udBSL61+uH1L8=; b=EMXIJNeFiIvy9N48K9nie25UpP23n3LNrXIuohwhrxelv8Mz3typogfpGai/AeqHqf /fFwYrMKGE1SGdWMeSCUXN4YUUIeHeQYw3Bcy4G6odrb+z7w3F9FQD9/lTXMHdKQkYld H7Jh4y98QYU1amki1aHKP/8bCnqK2EXukwF7+fFIZeLNcc2QQllh4wHzJ1voLpyVKEl1 U8DSMox0wZTPJjoy5NtcqB8Sr6U+Be1rl3FlkvTdV8QcDBdiTTg/5Bnky11Gp1HyWF6R lmU3+UK0JjRRWFoAbCXsSraYlENWa9FyXoUk9V8LixSkl+tjYFIuDDRoDAu2MImbP1Q3 wAVw== X-Gm-Message-State: AC+VfDyHkOOASxvpIBfGAK3xcKG5sefIGF63rglhiBdqb4TjC2dTHjkF nslrICFqLNS1wCVUQLXk6wO7Dw== X-Google-Smtp-Source: ACHHUZ4TlxSSHFz+e4rSAsGydvOiw2BlLkeaeXVAkr1EEg9gHoiubCodrjA6vz2o/fUYubTcNwOvcQ== X-Received: by 2002:a5d:4cc9:0:b0:2fb:7099:6070 with SMTP id c9-20020a5d4cc9000000b002fb70996070mr866319wrt.47.1684335831152; Wed, 17 May 2023 08:03:51 -0700 (PDT) Received: from revest.zrh.corp.google.com ([2a00:79e0:9d:6:e223:a0c2:d2c:c371]) by smtp.gmail.com with ESMTPSA id e17-20020adffd11000000b003047ea78b42sm3038211wrr.43.2023.05.17.08.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 08:03:50 -0700 (PDT) From: Florent Revest To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com, Florent Revest Subject: [PATCH v2 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long Date: Wed, 17 May 2023 17:03:19 +0200 Message-ID: <20230517150321.2890206-4-revest@chromium.org> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230517150321.2890206-1-revest@chromium.org> References: <20230517150321.2890206-1-revest@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9BADC14006B X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 8md4huujnrbkp3tm5dj1ssnrokpnu1j5 X-HE-Tag: 1684335832-792348 X-HE-Meta: U2FsdGVkX18IPDOv3mErOo6LigUQBC5FUwZ3xQwNGBz6JIDfHFQXB7xJJjZhqnOglm11hk6VlTrTUy00YNOgOi7MiCVHeNJeFAQgP3zLT7jas/UXTjylE/Z0c5MgHiWmeV97a6m8GQ5xU32EnE2Kfn+M2kK8ui+adGdpQg3O4oeD4l4yCiqeWd9d5D4fL04yP7BVxxVGZyiEe9VSNCg7NjvBzK2UeHGKOxmO8+oAOFF5sCmGI6xzPQpwjHNs2d3SpJgxq/l3nCd2xWRHSF+lUDn368a1TI+qKCrcvbdE373Za6Oqi9jjui4mZqoaR2RRmEHkSRW0zo91xVRu26IGXRSBrPVscXCAScJESBS0aX9bRWaN2dck1kXbxNuAWxAryITaVv8pe2UcBayEZsrACVmt7Hpnbit1Amz6oeUOmqP1sjPaMd4xUYC9ppTjdnz1BRY1Z9zp5jGBPC9g24nMoyWXij8m3SeeBZa8CwPzumHyJR7026+/oSvspTuFD43ujSFtnkJzmn2iRq29+cwYbyRWLGXczLvJmSNCpzdfLAC1plEEteSXz92k+Nav889zuwwEpS9E0sY6vqlERTDnRd/G//psqWUF9NAW+vMZCHczPOmCWkqDNYjN8CY1AEvATKDZBa0H3iOjeewiNFhTTP5Yuj+QwBXxHNIudlM7eqqCg5zMv3pqzaSnqsjotFzEc0VXPJ+qhsfFU3H8nKc3GHu3aFp9LFZIB95lUidRIBs0RGK0Ug1F1SacVsuvK+GI9whXog4J/VErVKpN1BPsextV+xXDXKdZyX0a9XABehNcRDwtwUdfpJAhlgF9JvVpn7GkjtQvZOI4uFKfQzFk+Fub4Bup1Ti3Tuyj7/mkM7yaJxGqa1CczmtviFX0/7LNgWmKBX2vIs6Tuo7eIt50vQEX0u88tYvsECoCHOTa6DY4uXQLEKmPXH4d1DiC8EOWKrHsabwEgRQPNrERHoy NkLf4+91 dyrtqCD6a9Q3HdFHtJjuT/QTh/nDwEW/BjwUrZ6C+Zp20EGCcd40WMMjqUd2QUdPFvsVdaCBFV6LF8RIPV3WYN4jUnx6aV6roiTdvlLUdDCezdqPKW+Es7i8B4x+cKcaduKJc4adOiLDYjvO+OaUeOkqSrUWN3L0s1DSWuNMXC4d36eY4KsSO0n9X411MG4/4pv7XxFs38z3+iA3bs7ijYCQzMzVwrZeHOaCqOKt/T+ziCCPu7kvsc0NDXOh+dA5dUW4G2KPix6beW5Sk3vPhB5k7SHspkbRCugreXea7hHFYFZ8i0iZ7zTQmTbZTYzdhyq+GAJwOsDkcV5KvSErGf9U5l6gDCiaMIsEVvnO2+lU9Rux2hX8fyrTFCVi5bzbz2Nxf11lfLYJyAKOoqty+eO0rjFPS74dlO7coFVrHGjqmI6kajbg0D6//DSJXccYsui4QrOasPciiuV27f92TZKB5X+5zVtpyVYRsScXy6LCzp5Av3bVtG0AQ/rO8KlXFeBjqnns9J0P3E3s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexey pointed out that defining a prctl flag as an int is a footgun because, under some circumstances, when used as a flag to prctl, it can be casted to long with garbage upper bits which would result in unexpected behaviors. This patch changes the constant to a UL to eliminate these possibilities. Signed-off-by: Florent Revest Suggested-by: Alexey Izbyshev --- include/uapi/linux/prctl.h | 2 +- tools/include/uapi/linux/prctl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/prctl.h b/include/uapi/linux/prctl.h index f23d9a16507f..6e9af6cbc950 100644 --- a/include/uapi/linux/prctl.h +++ b/include/uapi/linux/prctl.h @@ -283,7 +283,7 @@ struct prctl_mm_map { /* Memory deny write / execute */ #define PR_SET_MDWE 65 -# define PR_MDWE_REFUSE_EXEC_GAIN 1 +# define PR_MDWE_REFUSE_EXEC_GAIN (1UL << 0) #define PR_GET_MDWE 66 diff --git a/tools/include/uapi/linux/prctl.h b/tools/include/uapi/linux/prctl.h index 759b3f53e53f..6e6563e97fef 100644 --- a/tools/include/uapi/linux/prctl.h +++ b/tools/include/uapi/linux/prctl.h @@ -283,7 +283,7 @@ struct prctl_mm_map { /* Memory deny write / execute */ #define PR_SET_MDWE 65 -# define PR_MDWE_REFUSE_EXEC_GAIN 1 +# define PR_MDWE_REFUSE_EXEC_GAIN (1UL << 0) #define PR_GET_MDWE 66 -- 2.40.1.606.ga4b1b128d6-goog