From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3EDAC77B75 for ; Wed, 17 May 2023 15:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48E16900004; Wed, 17 May 2023 11:04:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43F68900003; Wed, 17 May 2023 11:04:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30672900004; Wed, 17 May 2023 11:04:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1EB71900003 for ; Wed, 17 May 2023 11:04:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E04E21C73D8 for ; Wed, 17 May 2023 15:04:40 +0000 (UTC) X-FDA: 80800068720.22.BF3978D Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf04.hostedemail.com (Postfix) with ESMTP id 0D4B340033 for ; Wed, 17 May 2023 15:03:46 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=H4NRL7fI; spf=pass (imf04.hostedemail.com: domain of revest@chromium.org designates 209.85.128.44 as permitted sender) smtp.mailfrom=revest@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684335827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ROoM+z1HUyIf7VmHaZw0Osm1LBJIPMGnhoCFAWKqLvQ=; b=bmISDEac3uO3JhIvjln+Kr13iMEBqfv3FadMM1LFqVHQpKKdo2Ga/fBmoJSVZDT1k6j6hm /jV5opK26kXZLU5QTvQxLHeQ2NzOpzEo2wBUWF9ErfbZrPjqdzZbMGCc+EnN9lE0p/gL9S HFuIW9iMSh9dKwotCD6Io0iqqNE9PhA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684335827; a=rsa-sha256; cv=none; b=SQ7OU+aCipt/idFXSlK6zgbLoAJkH5Yo2AmNwZBiYhVaUBtk7C8C+NQg3T+hoxnBk+oViD uu2qnW/zcLIiuAJCLJrGMi8mdMxDjsRtOBr+86EE046w3FOe2OJdKIq69QSteeroG+2239 EhpLVhnPPGJF6PVYAt9f8EONeKlXrLQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=H4NRL7fI; spf=pass (imf04.hostedemail.com: domain of revest@chromium.org designates 209.85.128.44 as permitted sender) smtp.mailfrom=revest@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3f42d937d2eso6046825e9.2 for ; Wed, 17 May 2023 08:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684335825; x=1686927825; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ROoM+z1HUyIf7VmHaZw0Osm1LBJIPMGnhoCFAWKqLvQ=; b=H4NRL7fIWw72mEHCSKlHC9bEXT51taavHTPlu4pLVksZeccv4zGLtYVNIV36lvzXiA 5DrTGLg1Rf7DedvAQXUKfRq7Ug6+IdfOEpKG9ZGu1VfUXI1NAB1a8pAc80nDzHmel1pE oMoptbsoDTg0m8spTjg6Y56dpGUOJwkJtqGNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684335825; x=1686927825; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ROoM+z1HUyIf7VmHaZw0Osm1LBJIPMGnhoCFAWKqLvQ=; b=W468NtJJS/gvmZnaAj2Yjs4ceTvZDuY6wC+ZFwqZAXEabf0HN4h7MsNaIPSx+u3yAD 5gGNpJx5GxqqJ7xkYQxAT71FT/CPwkCNwcYgUgkP0DkwA/+L09AcBvW8fDGE4jQW1R+p xAKCiaDm0fC/hpGl2wjz2R7MyfufOU7Pl8yo2ZkIhofFDSWw4wFhwT+bjkyUI4O5CaLi TdHb3wK6PAT0jtnYBcICg6U0QSgMDhcMQwBcr10VHxlQLo0n+ufGdadDrQj+hRwZ8KWO Xh51nWq+uDTDQ3D5oEIjTO4LLg+zuA+Cj1pEOJ/8cl37WlHFZpFUuVl2jFLjPFqwkqN1 7M4A== X-Gm-Message-State: AC+VfDy1PaGQ5vNWzPZ/lQ2GICX69FDR12eARWteaTx1OxD318G4r3oR MpmjCnIxPFjPRYQ1VbDr8QKCYA== X-Google-Smtp-Source: ACHHUZ6ycuHhmW1jZ1USr9pnh4eCN+Ti51EByPtxjWBdLNzffroPKrrzDg9jaCqBPM38i+CuolJ+MQ== X-Received: by 2002:a05:6000:1a4e:b0:306:37d9:201c with SMTP id t14-20020a0560001a4e00b0030637d9201cmr1145983wry.17.1684335824681; Wed, 17 May 2023 08:03:44 -0700 (PDT) Received: from revest.zrh.corp.google.com ([2a00:79e0:9d:6:e223:a0c2:d2c:c371]) by smtp.gmail.com with ESMTPSA id e17-20020adffd11000000b003047ea78b42sm3038211wrr.43.2023.05.17.08.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 08:03:43 -0700 (PDT) From: Florent Revest To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com, Florent Revest Subject: [PATCH v2 0/5] MDWE without inheritance Date: Wed, 17 May 2023 17:03:16 +0200 Message-ID: <20230517150321.2890206-1-revest@chromium.org> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 8ahhoqjd8fusaaog5csyghu8eobdtjag X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0D4B340033 X-HE-Tag: 1684335826-854132 X-HE-Meta: U2FsdGVkX18U+mFJHy2dcav72uJmymPNEZFLMwTDLWR55M/Of0+gZDxw0+fACmmWRvXgebEBXZQMG9HSxJb2rm87GhmQj/XRJfwqdJarlhQrQ4dKRbQdekHh8a9wzkBNNSn/H6mOosKV2/pXxg+vH8nltuDBoCWfZ1OO2aZkWcTpSNtSGQENrxUd3l9pLdnBeKvJsJxoHX+sJndSAqYYm/2gIGd4DgzdOiRoqGyO8eWtFNoSChVhMiVukRuy8ePxaLSF8jXP67U5pTOKkswWHIr1cFi90FEcHw84Z+PW7yDKUEcbXu7TC6uLEIdqiv8/L933UUuVUjaLHLu4z4pYWD7hbyt3zHvy0RGxtk2t95KJtmnz2GIgZME3NauZlt7HrRYk90fPx7Qn3rNT5wPYOUAcNfLP2QbdLfna5MkET7KEI3tQIRtI3rr+F8H2c38DQRaGOcOZuzfzRVgdMW/qD78VTZqZGOcXcnGFwTFB8pnM2MBiOKbGGrIFUb5hs22gQ739QMbJflVskAw++Q6ehLQvdEIlUzbxXNo3HK7o1tF/nrB+o9G0Gb+aUa4so/bLnWKbENMpe1bOlAnIY3HDG+P3KeRGvJz+xtG+fDIVoG41GlGWVUz/qY+6KgiWbTmskx10OmLVrtBnuyKNLMLTDxExzOPkDEdUwysQ8JRV6H3odN1e1f7nKPInxggudeA0mPqtQFd0k2i48oidxH7sJXwAB+nMkU+awXWUgBYPkP/olBxlw4fgGu1H72r6WklC449eZ5SUt1XBqL5mJAWeQyV6EBffb5g7q36CMBEIyTQROMhqJDykrDfPmLMYCp6o/QmyIFhoT3dpXKi/2mEE2MUqGi+57enSHkdc/2gV4OgmWZ+M4dHu52IL2mREmC9Cv8wy8TUXA4M/LccKmsuySK2gVaEDJyTSO24gey+FrBCtuguywZ2O60A+KVWTsYFrya/0vTJSRTUfyPSggfk drttHrhT 9GFDgtGOi7M9B7R1cFF+LGUtJLOMOCw2W9WYQHJ/+4FmEeM0jtqhsvg20jweTHMph53jC6ousApdT5QhDI+SzX4bTcPs3KpwOQtj+S+JG7X/1/30ySw+0rrd7TSejq/v9bxinW7tX0WpfuOt9QKZG7oaR/e6bmwWJxUy5wcNs3SiS47jHBQ1T0Wc6cupsJrl4A5qQOJRrP2RDVmQhrz37paq3yQqnMyKtzBcsIFCE8GsFsVpBHkh5W7KlR8d7J1n95cQOYKw5feDsLZyARCpy6A0J5jhLayIppSPj8i2qFW0U6APSnwqkdlH7ykiDgYMG0C4La51a5VoCUuZE+zM0vVc+jsb6G5SbtUw2gu/9v2iqjJuqzbFuCm5Wm8W5tnH3DgyPkfZ25ZFmCbD3GlGxgjAZmO6bwBmfJp77 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Joey recently introduced a Memory-Deny-Write-Executable (MDWE) prctl which tags current with a flag that prevents pages that were previously not executable from becoming executable. This tag always gets inherited by children tasks. (it's in MMF_INIT_MASK) At Google, we've been using a somewhat similar downstream patch for a few years now. To make the adoption of this feature easier, we've had it support a mode in which the W^X flag does not propagate to children. For example, this is handy if a C process which wants W^X protection suspects it could start children processes that would use a JIT. I'd like to align our features with the upstream prctl. This series proposes a new NO_INHERIT flag to the MDWE prctl to make this kind of adoption easier. It sets a different flag in current that is not in MMF_INIT_MASK and which does not propagate. As part of looking into MDWE, I also fixed a couple of things in the MDWE test. This series applies on the mm-everything-2023-05-16-23-30 tag of the mm tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/ Diff since v1: - MMF_HAS_MDWE_NO_INHERIT clears MMF_HAS_MDWE in the fork path as part of a MMF_INIT_FLAGS macro (suggested by Catalin) - PR_MDWE_* are defined as unsigned long rather than int (suggested by Andrey) Florent Revest (5): kselftest: vm: Fix tabs/spaces inconsistency in the mdwe test kselftest: vm: Fix mdwe's mmap_FIXED test case mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long mm: Add a NO_INHERIT flag to the PR_SET_MDWE prctl kselftest: vm: Add tests for no-inherit memory-deny-write-execute include/linux/sched/coredump.h | 10 +++ include/uapi/linux/prctl.h | 3 +- kernel/fork.c | 2 +- kernel/sys.c | 24 +++++- tools/include/uapi/linux/prctl.h | 3 +- tools/testing/selftests/mm/mdwe_test.c | 110 +++++++++++++++++++++---- 6 files changed, 131 insertions(+), 21 deletions(-) -- 2.40.1.606.ga4b1b128d6-goog