From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01A7C77B75 for ; Wed, 17 May 2023 20:49:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A54C280002; Wed, 17 May 2023 16:49:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 652BE280001; Wed, 17 May 2023 16:49:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51B83280002; Wed, 17 May 2023 16:49:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 44E58280001 for ; Wed, 17 May 2023 16:49:21 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F3F1FADE67 for ; Wed, 17 May 2023 20:49:20 +0000 (UTC) X-FDA: 80800937280.01.C3CA64F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 4C836180011 for ; Wed, 17 May 2023 20:49:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wh1XKXEW; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684356559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pQ7ykyJICb0GdnYuuL52ARHSnk7j8XBdS9thnoWpCsw=; b=rRNsGp3oHXCC/m2Hela1KT6cGwo8AIb6srtv4A+V4s0yST7XDHZT1L3aM3cBNWttkR3Ohx yrCdDFsVswwFo+WUqlv9+4IgsJnulK4TVXXDPs5BSSTwKwBMO7CMwbflPD7oXkN9Z2f0LY Je159+fP3vLRqpoTOFxF8SOwbGNq1Mg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wh1XKXEW; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684356559; a=rsa-sha256; cv=none; b=S2ZxzpvWElWG6tlaa3xzoCWnF2QczN4cdcXBG2OHi4bYSJp2u2AJNno+wOETSP5LTriGMG iqNAhu6ffQVp7DC3FwGeWdu8k4dJJe42MzBY4q9D7RIxc+6oQWw+UVm1IdCTQAEDdCwSqU W43tn48taVsgqmkImjF0q2ev6eHBeT8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B062646A8; Wed, 17 May 2023 20:49:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78240C433D2; Wed, 17 May 2023 20:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1684356557; bh=ESwHDFeH9sFs7LqoayE2LYshu3gFC0OnzfRGKxNaVuM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wh1XKXEWZpvLmsUnr/6T6ZYtnllDQ4ytqasvLJwOG4J2KTVMQ+QrmP0j8gs1Iw/oG H/8oA56+KSt0n0frYaPHICgsQYuNkwtiriDnXYFeSB5ZOJkSqaUkN8AY+oYKhrkICU aWinx5bNyUeSEyuTjSFhHs9SY2k8RFAXI0zhEV3w= Date: Wed, 17 May 2023 13:49:16 -0700 From: Andrew Morton To: Arnd Bergmann Cc: Nick Terrell , linux-mm@kvack.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] decompressor: provide missing prototypes Message-Id: <20230517134916.717bdcc4ba26e10462157ee9@linux-foundation.org> In-Reply-To: <20230517131936.936840-1-arnd@kernel.org> References: <20230517131936.936840-1-arnd@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: pk3wst5bkasahteafiptejrejxz17dai X-Rspam-User: X-Rspamd-Queue-Id: 4C836180011 X-Rspamd-Server: rspam07 X-HE-Tag: 1684356559-541996 X-HE-Meta: U2FsdGVkX180gdAgoBp15KVIA5SnoGX/+MbgYWyDscfBFnA6sCGQgWE60hZzCajLtertVxVP9DBiVhXi7O0i2va40uixZO8TeS0W1yvpQ7Q8r6ZpLwjkubgX05A7iHpeHId08M5aLdblMEj2E2E0+isllVfcqoGdJ79PMbYeTew2JtSTMC57hmJPj2YI+U2K03UXYK+8on70+b6FQxZLUreoTXUvLZJn0om9yQbT84NUbD0PjUv3MEqo9sMiBfYGDd9jBIK1ZrgBSaLbwtRh4arSKjzPK/iyimgU0enEijKOziT6MzvVrOiY5N1e5XTduF/wHiUru2h4wipkykDG7qenLnIfINon4TRWCRfapxTX8hQDdzGtKX0H/t89EwsaApRiufv77XHu/lq8gIYiGXp5MGxX3FAvV1X3+DhaOmdNDx3SdBpQ86DJki1YzLzNNvPeIUJ7c6o09OdnOZ+gJEOh/Ai5f2N+no5VoJ5LZdvFWNo2XLH0Yk8PC3tUkbSV64IzVJs7TIhJbXvOHGGnzexZBXJBO/4uIOWA8Zb3XkaEAqF2FKF07LTlLRfu3ih2rvxCCWkF9eD9oubhU68TWWWgV9QLWqa2pMDOZtUC+taYkkWTmNrmmenei+kGvsluELBw8ng6m/vDov2vn68Ol7ZGm4x31wglvItsab/HxS/bwWfRT+ggiYC5PR5xsMTWMHtSzi/APHJjXU/tFICBKdnpGBjOzxIyAtzAjsOgsGaslmvWfEzVi4vqwDncPqHykLaPRaerCcsWhfmvNvgPCoEUQTmMVwhINH0j4Ltpm4ED38ogBNmjDU1cofKq0+50obZr7buEsmPv42mkNjmwShYLG1O/z3l6pPECmze6+5GtJIQT98iAnrn5sdoesJlD+KFcyEK078t5nBenuuO7M/SK3Ox5DTvjdCiuPzLBAu9qmbBKhC7sXpHLcpFEieuIb/cs4AOgaV3siyWXHpE jGyuwpDa M8tmqRU7M3cP2kP3Yd39ku3Ma5/ZSDlqc9IEfO/HTdSKeP7t+AsGQg86LBmRuN86Alnb0UHV/E15YEdwwzEhGiCuDdAiMLUVvfxUfMnOeS448Tg5MtyGhooII70KfIDH/abzvkCT2J/AcDMkNzYHzs81qFHjFjsOkOUqJwonqVYdCDkqSgLMBsQWl1R8oDFlp+TUoAueHKVoPjv5vqmNc7aYnjHBHOl3FK/SwAu/KU77TiGxvHCwMFvaxycHe7WTjhTjrBuj4ulniTjlFfJCYvSx2xtOgJBCsRtMZteKk27Hz4cvIj9B+6jJq+MsLsHdLedeO71unb0nhqS3Sx5CwUiqXll7XDkOWmTywxI+VbKdhS3ZsyHH9IJtz8uawJoBbBvQhzI03DPN2Y4TXmlcWx8lNJE8ZIoobNgvO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 17 May 2023 15:19:31 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > The entry points for the decompressor don't always have a prototype > included in the .c file: > > lib/decompress_inflate.c:42:17: error: no previous prototype for '__gunzip' [-Werror=missing-prototypes] > lib/decompress_unxz.c:251:17: error: no previous prototype for 'unxz' [-Werror=missing-prototypes] > lib/decompress_unzstd.c:331:17: error: no previous prototype for 'unzstd' [-Werror=missing-prototypes] > > include the correct headers for unxz and unzstd, and mark the > inflate function above as unconditionally 'static' to avoid > these warnings. These are errors, not warnings? Under what circumstances do they occur? Shouldn't we cc:stable? If so, do we have a suitable Fixes: target?