From: chengkaitao <chengkaitao@didiglobal.com>
To: <tj@kernel.org>, <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
<corbet@lwn.net>, <mhocko@kernel.org>, <roman.gushchin@linux.dev>,
<shakeelb@google.com>, <akpm@linux-foundation.org>,
<brauner@kernel.org>, <muchun.song@linux.dev>
Cc: <viro@zeniv.linux.org.uk>, <zhengqi.arch@bytedance.com>,
<ebiederm@xmission.com>, <Liam.Howlett@Oracle.com>,
<chengzhihao1@huawei.com>, <pilgrimtao@gmail.com>,
<haolee.swjtu@gmail.com>, <yuzhao@google.com>,
<willy@infradead.org>, <vasily.averin@linux.dev>,
<vbabka@suse.cz>, <surenb@google.com>, <sfr@canb.auug.org.au>,
<mcgrof@kernel.org>, <sujiaxun@uniontech.com>,
<feng.tang@intel.com>, <cgroups@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: [PATCH v4 2/2] memcg: add oom_kill_inherit event indicator
Date: Wed, 17 May 2023 11:20:32 +0800 [thread overview]
Message-ID: <20230517032032.76334-3-chengkaitao@didiglobal.com> (raw)
In-Reply-To: <20230517032032.76334-1-chengkaitao@didiglobal.com>
From: chengkaitao <pilgrimtao@gmail.com>
Oom_kill_inherit can reflect the number of child cgroups selected by
the parent cgroup's OOM killer. We can refer to the proportion of the
indicator to adjust the value of oom_protect. The larger oom_protect,
the smaller oom_kill_inherit.
Signed-off-by: chengkaitao <pilgrimtao@gmail.com>
---
Documentation/admin-guide/cgroup-v2.rst | 4 ++++
include/linux/memcontrol.h | 1 +
mm/memcontrol.c | 6 ++++++
3 files changed, 11 insertions(+)
diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 51e9a84d508a..e6f56443d049 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1358,6 +1358,10 @@ PAGE_SIZE multiple when read back.
The number of processes belonging to this cgroup
killed by any kind of OOM killer.
+ oom_kill_inherit
+ The number of processes belonging to this cgroup
+ killed by all Ancestral memcg's OOM killer.
+
oom_group_kill
The number of times a group OOM has occurred.
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 23ea28d98c0e..d7797f9a0605 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -46,6 +46,7 @@ enum memcg_memory_event {
MEMCG_MAX,
MEMCG_OOM,
MEMCG_OOM_KILL,
+ MEMCG_OOM_INHERIT,
MEMCG_OOM_GROUP_KILL,
MEMCG_SWAP_HIGH,
MEMCG_SWAP_MAX,
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 8ee67abb415f..cf3cacf26cec 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2129,6 +2129,10 @@ struct mem_cgroup *mem_cgroup_get_oom_group(struct task_struct *victim,
if (memcg == oom_domain)
break;
+ /* we use oom.group's logic to update the OOM_INHERIT indicator,
+ * but OOM_INHERIT and oom.group are independent of each other.
+ */
+ memcg_memory_event(memcg, MEMCG_OOM_INHERIT);
}
if (oom_group)
@@ -6622,6 +6626,8 @@ static void __memory_events_show(struct seq_file *m, atomic_long_t *events)
seq_printf(m, "oom %lu\n", atomic_long_read(&events[MEMCG_OOM]));
seq_printf(m, "oom_kill %lu\n",
atomic_long_read(&events[MEMCG_OOM_KILL]));
+ seq_printf(m, "oom_kill_inherit %lu\n",
+ atomic_long_read(&events[MEMCG_OOM_INHERIT]));
seq_printf(m, "oom_group_kill %lu\n",
atomic_long_read(&events[MEMCG_OOM_GROUP_KILL]));
}
--
2.14.1
next prev parent reply other threads:[~2023-05-17 3:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 3:20 [PATCH v4 0/2] memcontrol: support cgroup level OOM protection chengkaitao
2023-05-17 3:20 ` [PATCH v4 1/2] mm: memcontrol: protect the memory in cgroup from being oom killed chengkaitao
2023-05-17 3:20 ` chengkaitao [this message]
2023-05-17 6:59 ` [PATCH v4 0/2] memcontrol: support cgroup level OOM protection Yosry Ahmed
2023-05-17 8:01 ` 程垲涛 Chengkaitao Cheng
2023-05-17 8:09 ` Yosry Ahmed
2023-05-17 10:01 ` 程垲涛 Chengkaitao Cheng
2023-05-17 20:42 ` Yosry Ahmed
2023-05-18 5:12 ` 程垲涛 Chengkaitao Cheng
2023-05-19 22:04 ` Yosry Ahmed
2023-05-20 9:52 ` 程垲涛 Chengkaitao Cheng
2023-05-23 22:02 ` Yosry Ahmed
2023-05-25 8:19 ` 程垲涛 Chengkaitao Cheng
2023-05-25 17:19 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517032032.76334-3-chengkaitao@didiglobal.com \
--to=chengkaitao@didiglobal.com \
--cc=Liam.Howlett@Oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=haolee.swjtu@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=pilgrimtao@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=sfr@canb.auug.org.au \
--cc=shakeelb@google.com \
--cc=sujiaxun@uniontech.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vasily.averin@linux.dev \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox