From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0600EC7EE24 for ; Wed, 17 May 2023 02:58:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 616AA900004; Tue, 16 May 2023 22:58:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A06C900003; Tue, 16 May 2023 22:58:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4403F900004; Tue, 16 May 2023 22:58:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30110900003 for ; Tue, 16 May 2023 22:58:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EDFC9160424 for ; Wed, 17 May 2023 02:58:01 +0000 (UTC) X-FDA: 80798237562.15.504FE72 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf29.hostedemail.com (Postfix) with ESMTP id 3AA4E12000C for ; Wed, 17 May 2023 02:58:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Elx9D7mf; spf=pass (imf29.hostedemail.com: domain of ssawgyw@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=ssawgyw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684292280; a=rsa-sha256; cv=none; b=RD35espCvj49yZGIU17NB6npLqJD5CJM17X2xOed+CH2pGiY674qsrP1m3LGSjQCBkJxKv H6Lp1XoGrkIFR3qYGOzji68wG8jqvpJ4JZrFFs60w4+aDRi4pHdS8Qy4OXr5dd48sVRjBQ Ll9H7Kdet5v00MwfAEjisJNWu9Kcoiw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Elx9D7mf; spf=pass (imf29.hostedemail.com: domain of ssawgyw@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=ssawgyw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684292280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=nfqadfuEw0ilEHiRhO6KvOWnkDKYSpST+spUfnDMNuc=; b=M1lc+xOu7N+DrYyJNJHPThRnr8m7JNc80x5P3SctcGRnqD9X8OuhP9u4jJMVB4ZRCh/B4P QH0Zb9uozgYy+Po/7DiYdAB3qKoGhgSSTKPLYt8gvIsqAk0Rsv1JbzFX0NJ2aW7DvYoRhy /qg7eFzew/8+2PVvlKbmtQQ0yosWUhI= Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-51b4ef5378bso169351a12.1 for ; Tue, 16 May 2023 19:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684292279; x=1686884279; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nfqadfuEw0ilEHiRhO6KvOWnkDKYSpST+spUfnDMNuc=; b=Elx9D7mfksOMb2sxsMzzbkNS1QqvaDXWs05bEm0E5xYbYYxbRcVaoZLpYXBSPWv12U ZgsdCqkYyzKDJ/8bzjY40a4NJPQ361NVpgATYgrcn2V25b30XBTOVDgGGcioCxtGANCZ gLShFCc7dBCFKqvL5X8rOyY5q3dOxjiCqty6Co1KJLKn+iAS6CwvHwI4gO6QPcA6LmRO 5Jh7e4I0Yoqd1kfmqoyxcRv9oJPHxbYvqG2wdHEI3xsHd22ZFoQ5UEAk2F3CUk7mnCgT fCykOoOCipmc+CteII4H6JkzOy34KAoBsE6zBwAdaQMb/L8IkkETJWEsoMwiRzD60Nh4 jAgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684292279; x=1686884279; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nfqadfuEw0ilEHiRhO6KvOWnkDKYSpST+spUfnDMNuc=; b=JojNSjNrljakVsAMkirui5UuCgtq3nG7zxyaCPi7H7hhH/a7QyD+njvjTr5ghQ+Xfe mlgQHPmnRL1NheXxmPDs8Blp+175/bK5Q8S++ZOCUmnVGCYqTg3BPrPg4/W5wzsK+ywQ TsFMv3DVzNazlnKgmmYLyZEyQ396pcZTZ78/AwQHks+/ZBf+1czmJOtlpt2fppxjpiP1 KdFShBFey5weOMBUgT6qmsxTS4m2tjyWi8N4RHqOCuhovNe5ydDZ5rYLLx1fMwTtbTN9 BwLIe1VMkjemQvbYmOgF9owxJqxuCvhCwnzVGhlxkFYJq1sWjhpe2kk0knJV+tFfnwId tvTQ== X-Gm-Message-State: AC+VfDwHCdfZDFYMagzZfMT82lKDARKnCeRg/oCN6f1i+ecW1GOLCWAk DndtrtlS/sGV+2oQbWrSNP0= X-Google-Smtp-Source: ACHHUZ7MdnHrEDZqQGdsWENHJBVnVpMTlniQPGiz1nbLE6ALJlCwei1k6asJyqV17kwkWcKRRgo2rw== X-Received: by 2002:a17:902:ecca:b0:1ae:3a5d:f9e0 with SMTP id a10-20020a170902ecca00b001ae3a5df9e0mr3726355plh.55.1684292278885; Tue, 16 May 2023 19:57:58 -0700 (PDT) Received: from localhost.localdomain ([45.43.34.98]) by smtp.gmail.com with ESMTPSA id iw9-20020a170903044900b001ac2f98e953sm454489plb.216.2023.05.16.19.57.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 19:57:58 -0700 (PDT) From: Yuwei Guan To: rppt@kernel.org, akpm@linux-foundation.org, tsahu@linux.ibm.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yuwei Guan Subject: [PATCH v2] memblock: Add flags and nid info in memblock debugfs Date: Wed, 17 May 2023 10:57:47 +0800 Message-Id: <20230517025747.230-1-ssawgyw@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: o8ykui57qfojnp6ptsrfi7iu8skf78jx X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3AA4E12000C X-HE-Tag: 1684292280-325877 X-HE-Meta: U2FsdGVkX18gfV3SFI7XN6f0zuY8cVKpX5XGilihP0dSzEeZc8+qZ/urFdan+Jg3gQLryrbSGzpevOBFukdgeRFEAiOhCmAhSPKjVXr+Dz5Cb7JFkjBaxVktRwojM739jeRjHgAa8KPiYIhzfJgCAAslRYOl7nS+T+ZulP+cW4T5pgqclKEyVI7EgkE8EUN7eA6bl6TYCRjmeRfwJxvPy6d9FIe7D3LbDT3axbxG8TLErTa+zO1d+8wQAMnqRriheLP3MM/ng9ckTodlkvf45Ck5YjM41D4xsSbCBCGqGFAJNMJicz9iVIoB+L+HNa//NdOqqrBQME+foLy38/ywnjsEnLdOI0fUDzzD8kS+ur4oC4KeFIsF+qKIU2tX5hkSTno+8yzxEAHz63lz5cRj+m8G8eB8bLGUnHBOEu2UMj4Nr6/5V6ICGVCruG9ZPL4hNlN32lnmAm7BaTrNQmL0LvV0lvR3d6RFT0IozFMuwjelFO79cO4pLpIbsiJup22UstqTNS164Ac7uEKg6Jxh7i8Ijp+JhrgZHqQNU+/HZThZbQ/AdSZmdkOC54FOzp3tnk1nRwSdlq/gJwtnxkU+J+27AeybplfZA5a3HMHdaGd4SSsJrPO66Z0etA4qecAwDa2TtzFiWDzhoCtlSqQSfh4QXQ9d+fmdnyqOyLszuS68qs9LSVTntYQYdrpTP82ZgIZoKuZZEyCThp0xHkbuR0iTjyWClwil5fcyzQyijVh+lSfdGa904jw/qR5yuhFAmUKrKvCAi5WE221VOZHaDyBSFAgDTsCWpyakkXCIJGA+9iqCGoUtrNdu041VYuEZEkCfLPhXUByvikFocPHUFTrUQKUBYu+bTMDOqDKcYJhw+xnmgMzgp0Sxd6FC43sqjLdRWeFnzTD4KrAMXudy+oU6y89bix8vMdFQ4DkNJUvtIiaBQTAFQJGyUx5dXsE9HPFghIsK/zYG7/jPjqD n7a6SnwN BQmpyruZZGbBSpvp7nxW1L7fLTNvMaDemxoufGaqO/IssM3qPO054y4RLPqAS0eFXFuKrQXnSLTd1nKRyoCFEefw+weCPcGEvw1mGHcBT5nl0Zg8a/+biejzWLhCY2+bdynZdO1FaUAOtAh6GfYuR9DKVsiKV3PxCKOWnff5DFf/7mwgKwvzRjtM6QQ95BKouaP4+BAXsywZTgW6ugDdahufGo/SP6LY6HoSyY5VmBQVPepbN6bkACAxJH2Fb6w0J9LVQXb+GhAppC0s2ITHdkze11/+yg/GMQi5pr1vn+yfx2zDTJaK8MWcfmkHU46dqqAUzSpIjQciH6yOIguyFyOpoMvF6eAtXnpiXRDR+6qba0jGJNj+DYpFuEbSkaK2FQXSae7pOWhoqz0XBdg9fRQhZsFaexNi3EylKLWvWxzz27B28x2vXx99S5VGOkviiQLovPVUQQPqt13K6YBZv4Ggyxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, the memblock debugfs can display the count of memblock_type and the base and end of the reg. However, when the following scenario occurs, the information in the existing debugfs cannot make it clear why the address is not consecutive. For example, cat /sys/kernel/debug/memblock/memory 0: 0x0000000080000000..0x00000000901fffff 1: 0x0000000090200000..0x00000000905fffff 2: 0x0000000090600000..0x0000000092ffffff 3: 0x0000000093000000..0x00000000973fffff 4: 0x0000000097400000..0x00000000b71fffff 5: 0x00000000c0000000..0x00000000dfffffff 6: 0x00000000e2500000..0x00000000f87fffff 7: 0x00000000f8800000..0x00000000fa7fffff 8: 0x00000000fa800000..0x00000000fd3effff 9: 0x00000000fd3f0000..0x00000000fd3fefff 10: 0x00000000fd3ff000..0x00000000fd7fffff 11: 0x00000000fd800000..0x00000000fd901fff 12: 0x00000000fd902000..0x00000000fd909fff 13: 0x00000000fd90a000..0x00000000fd90bfff 14: 0x00000000fd90c000..0x00000000ffffffff 15: 0x0000000880000000..0x0000000affffffff So we can add flags and nid to this debugfs. For example, cat /sys/kernel/debug/memblock/memory cnt base..end flags nid 0: 0x0000000080000000..0x00000000901fffff 0x0 0x0 1: 0x0000000090200000..0x00000000905fffff 0x4 0x0 2: 0x0000000090600000..0x0000000092ffffff 0x0 0x0 3: 0x0000000093000000..0x00000000973fffff 0x4 0x0 4: 0x0000000097400000..0x00000000b71fffff 0x0 0x0 5: 0x00000000c0000000..0x00000000dfffffff 0x0 0x0 6: 0x00000000e2500000..0x00000000f87fffff 0x0 0x0 7: 0x00000000f8800000..0x00000000fa7fffff 0x4 0x0 8: 0x00000000fa800000..0x00000000fd3effff 0x0 0x0 9: 0x00000000fd3f0000..0x00000000fd3fefff 0x4 0x0 10: 0x00000000fd3ff000..0x00000000fd7fffff 0x0 0x0 11: 0x00000000fd800000..0x00000000fd901fff 0x4 0x0 12: 0x00000000fd902000..0x00000000fd909fff 0x0 0x0 13: 0x00000000fd90a000..0x00000000fd90bfff 0x4 0x0 14: 0x00000000fd90c000..0x00000000ffffffff 0x0 0x0 15: 0x0000000880000000..0x0000000affffffff 0x0 0x0 Signed-off-by: Yuwei Guan Reviewed-by: Tarun Sahu --- mm/memblock.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 511d4783dcf1..b36fb6b31e0f 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2144,12 +2144,16 @@ static int memblock_debug_show(struct seq_file *m, void *private) int i; phys_addr_t end; + seq_puts(m, "cnt\tbase..end\tflags\tnid\n"); + for (i = 0; i < type->cnt; i++) { reg = &type->regions[i]; end = reg->base + reg->size - 1; - seq_printf(m, "%4d: ", i); - seq_printf(m, "%pa..%pa\n", ®->base, &end); + seq_printf(m, "%d:\t", i); + seq_printf(m, "%pa..%pa\t", ®->base, &end); + seq_printf(m, "0x%x\t", reg->flags); + seq_printf(m, "0x%x\n", memblock_get_region_node(reg)); } return 0; } -- 2.34.1