* [PATCH] mm/hugetlb: remove hugetlb_page_subpool()
@ 2023-05-16 22:52 Sidhartha Kumar
2023-05-16 23:03 ` Mike Kravetz
2023-05-17 7:20 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Sidhartha Kumar @ 2023-05-16 22:52 UTC (permalink / raw)
To: linux-kernel, linux-mm
Cc: akpm, songmuchun, mike.kravetz, willy, david, Sidhartha Kumar
All users of hugetlb_page_subpool() have been converted to use the folio
equivalent. This function can be safely removed.
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
include/linux/hugetlb.h | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index b2b698f9a2ecb..21f942025fecd 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
return folio->_hugetlb_subpool;
}
-/*
- * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
- */
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
- return hugetlb_folio_subpool(page_folio(hpage));
-}
-
static inline void hugetlb_set_folio_subpool(struct folio *folio,
struct hugepage_subpool *subpool)
{
@@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
return NULL;
}
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
- return NULL;
-}
-
static inline int isolate_or_dissolve_huge_page(struct page *page,
struct list_head *list)
{
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/hugetlb: remove hugetlb_page_subpool()
2023-05-16 22:52 [PATCH] mm/hugetlb: remove hugetlb_page_subpool() Sidhartha Kumar
@ 2023-05-16 23:03 ` Mike Kravetz
2023-05-17 7:20 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Mike Kravetz @ 2023-05-16 23:03 UTC (permalink / raw)
To: Sidhartha Kumar; +Cc: linux-kernel, linux-mm, akpm, songmuchun, willy, david
On 05/16/23 15:52, Sidhartha Kumar wrote:
> All users of hugetlb_page_subpool() have been converted to use the folio
> equivalent. This function can be safely removed.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> include/linux/hugetlb.h | 13 -------------
> 1 file changed, 13 deletions(-)
Thanks!
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index b2b698f9a2ecb..21f942025fecd 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return folio->_hugetlb_subpool;
> }
>
> -/*
> - * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
> - */
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return hugetlb_folio_subpool(page_folio(hpage));
> -}
> -
> static inline void hugetlb_set_folio_subpool(struct folio *folio,
> struct hugepage_subpool *subpool)
> {
> @@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return NULL;
> }
>
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return NULL;
> -}
> -
> static inline int isolate_or_dissolve_huge_page(struct page *page,
> struct list_head *list)
> {
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/hugetlb: remove hugetlb_page_subpool()
2023-05-16 22:52 [PATCH] mm/hugetlb: remove hugetlb_page_subpool() Sidhartha Kumar
2023-05-16 23:03 ` Mike Kravetz
@ 2023-05-17 7:20 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2023-05-17 7:20 UTC (permalink / raw)
To: Sidhartha Kumar, linux-kernel, linux-mm
Cc: akpm, songmuchun, mike.kravetz, willy
On 17.05.23 00:52, Sidhartha Kumar wrote:
> All users of hugetlb_page_subpool() have been converted to use the folio
> equivalent. This function can be safely removed.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> include/linux/hugetlb.h | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index b2b698f9a2ecb..21f942025fecd 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return folio->_hugetlb_subpool;
> }
>
> -/*
> - * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
> - */
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return hugetlb_folio_subpool(page_folio(hpage));
> -}
> -
> static inline void hugetlb_set_folio_subpool(struct folio *folio,
> struct hugepage_subpool *subpool)
> {
> @@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
> return NULL;
> }
>
> -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> -{
> - return NULL;
> -}
> -
> static inline int isolate_or_dissolve_huge_page(struct page *page,
> struct list_head *list)
> {
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-17 7:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16 22:52 [PATCH] mm/hugetlb: remove hugetlb_page_subpool() Sidhartha Kumar
2023-05-16 23:03 ` Mike Kravetz
2023-05-17 7:20 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox