From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72E2C77B7A for ; Tue, 16 May 2023 21:52:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4620E900005; Tue, 16 May 2023 17:52:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 411CF900002; Tue, 16 May 2023 17:52:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA06900005; Tue, 16 May 2023 17:52:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1E9B8900002 for ; Tue, 16 May 2023 17:52:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F137D80329 for ; Tue, 16 May 2023 21:52:20 +0000 (UTC) X-FDA: 80797467240.10.357A8E8 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by imf06.hostedemail.com (Postfix) with ESMTP id 9E229180011 for ; Tue, 16 May 2023 21:52:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="Kl0XuJ/7"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=tU+ViBfm; spf=pass (imf06.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.20 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684273938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1mTVN0zWdMUI2lVaj0xdpaB121fz73d+fGcmjELhUZk=; b=FUg69K72adXe6IFOWxC5Oj898CYh5oyoQ6A+okAe3Sn8h+ovrIh34kL/He+No/70wFG9lR klIeUJeNSFkgAjQT1qoYP1hxER+ozjH31nP6fKWSGXknFh0yy7dY9NfADMllzwFKQCAsuK DpUWtQ234j/vLnC1iMCxzYt7yUFDp60= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684273938; a=rsa-sha256; cv=none; b=vOwxB1V2gFM2mGbroceI6Y4ww4oiGrHxPdCF5CmY7mLMZcCgreBNFoUy0mZNBZHYdV4jXz 90IZ9srgn2nQFvxtSlEoJQwKgtdWtqhrCv9ilsWxrzuu1zBYSvlc9h8KbIghuatyESbPWM R0ZiFCl+kKaESTlESQ0O4YEQFJ8+VRU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="Kl0XuJ/7"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=tU+ViBfm; spf=pass (imf06.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.20 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5195232004ED; Tue, 16 May 2023 17:52:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 16 May 2023 17:52:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm2; t=1684273932; x=1684360332; bh=1mTVN0zWdMUI2lVaj0xdpaB12 1fz73d+fGcmjELhUZk=; b=Kl0XuJ/7rIR0raL3yWB6485sHqvMnmL2RGcc3l/D9 XK1ozRr20oXtM/pkqnBga8x4OZiLPdkuPeTcya8KxrKOuPaNK5iHbd4Z1EfybFu3 0DDU9lqBFLxnxgs2FIk0IkREbJWAQj8SQu69lVMsFNSinDaNr7+6YKEGkl0ArOeL WjkXcV0svcu/tIpvgKROlYgnBURRbckLIi2BheWDrl22IkmeFR2gVtBeLcYiHP+9 P4VYisa62yS4Hc8fGJNZur83EFykS5LoZtQBEELJqrPmzbDKV3tnKL1Zg49vLGLP g+CA3o3bvf7hNejFutszhr6Jj5xTXDo23+vvjZCejsIQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684273932; x=1684360332; bh=1mTVN0zWdMUI2lVaj0xdpaB121fz73d+fGc mjELhUZk=; b=tU+ViBfmK/un/Lo4Z03YcEyAbW/0SFOQJJQx4AsI0E3jnBxx2qh 3IhxNCJHYBpozyEtOjb4guShzBj+bzhNjwYnaf8WC/xaaaqmzo8h6WBd/AljRtsX 4vwVFQh1hDr8N8xyZzq+0OKOd3AsfE+ePvrvheZMPnbxiS61ULC7E/aL2Z8Xe9Sm P3PSHT4we7zgEtV2JALq1pRJkuUTUVvonLkRNTKfvow6RYAIqHVVr6PZiZ3gW7VW 3qphfT70JBf7jMKYx45+krDE9y3XOz3bWfEjd6yyg/ZUUVYiOfT+If7yNuQGsP9Y heX0TB/zA0TetA7lPy5AKDqoxaA7G2KUkig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehledgudeiiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthektddttddtjeenucfhrhhomhepfdfm ihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovh drnhgrmhgvqeenucggtffrrghtthgvrhhnpefgjeeikefffeefvedugfdtkedvhfdttdei feevtdehgefgjeffleelgffggfdvkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 May 2023 17:52:12 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 480C510C8C1; Wed, 17 May 2023 00:52:10 +0300 (+03) Date: Wed, 17 May 2023 00:52:10 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: Ard Biesheuvel , "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Hansen Subject: Re: [PATCHv11 6/9] efi/unaccepted: Avoid load_unaligned_zeropad() stepping into unaccepted memory Message-ID: <20230516215210.pviqojbr5o4hd6bb@box.shutemov.name> References: <20230513220418.19357-1-kirill.shutemov@linux.intel.com> <20230513220418.19357-7-kirill.shutemov@linux.intel.com> <6fe42f66-819c-f2c8-176b-759c1c5a9cf5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 9E229180011 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: g3wg469c84tiaxg41bohb3y6dehno7da X-HE-Tag: 1684273938-217525 X-HE-Meta: U2FsdGVkX19z88Q/jzac0HeOujmZBG0QG/Od9lIRFcofriUETSkL0TR+0t0Nvns/2YMA12M76ZgNNft6n2ivXd64LT5g4n2DhFvMI+cA4equJx7Uozt9eiL+gGd+oKzLhNj0lr+JjkHF0KCdiguQHzFk9v6JQVWbNcmxLa9KdiJ+nuyRLc1Dnrl2zyYOb8CRqpsGuoom/ovN+ZIUchvyciSaYEsmsZX03arevnFySJZxG9Lu0io/jqJMLCWZP3xYubsqn7QEqk+SXV2YSw1OEyH5SoTPv6trdBkdvA3vWmCe20vR0V/GY8lkEZf13Ir9DAtk8DrC8E+niFVC1rAYxTswHIX4rqJZpfnStrkQpnsCEmmuVOfXswS25ud+8p3xAvwMe62APhGVg0PRH1acteQdJXr3kcohXri3C3YiXrIUyYWceh0GwQAAapiU4iOXa4cIxz5Iwqp8aJb+5D1J2RYzxB4wOPvMuEmBnc+ZFuoBbM4YHmzXpBfGJjNDCifqY6LzdnV2rQ28Y+rBfBSdiJNvig0LEfcpqsRsleCzeSCG07+hsd9SWk4I8wuKFZXDmV+9VNKxKXoea3t/6YYxFdmpefHBICfI3fYMx9mJhhEe346CMG0JsLPwFVrj52ysJ3YkKWrtrPrSCc0iGJJ/Lq7A+H79Giha8llaD8W/V8OsJ9jdTyz/YHYej/wv2KnjLOghh9L/hxnGIdl2MK4g1nmY9WlcLrxon5BNSIydoL/YB9m5XBO899n9n2qfVs0Rl2CUnKb+QVgQCrT/F7NNs8B42U6CLFOUvFlpHTis6aN2K8wiSDoSJVRk0gkQiYHsnyEVLwIQsU3RY0zqFm6KE3Q/uLvBmK2wp5W+uMWwsgohfxKLzWMPtwYeBijjU+E/2TDS8IrRbXN8qn6ZxusOp4nu33fGlVWPGVQS4JZHYn9tFuABY0+pz/6WX0vMvqbPnkN9cTLoZEo+H2VK7lK nWIt/Yis Ouw2nET9oqcPA+/ZkKxLY/UUQUVnpmvMkppG78NbjlxycjaWgCv5uXJmVs9DUqzw3SZ106dba4///fyPoKAwB6zuxhRTWRVHGejlXtbUxxAcLyBerbZx6UEJYRqvDsEbOTfHqikP+eAjxXfjXlKLd6VBql8leejVAaaF4ARPWcZvFQtX8dKh5wbtUv8G66LOFoDqii8fQ2xALvvM6Mogj4e9F3hT7w2NVkrwe/OQTa+vacKxA8vPdeVbVbNGxtgC1mwI9m8Gv1atMoQBlOguJPyw4Idjs2Bf4wZAoUl5K30SigW/+ulFonsSAHUzIZka12BEVzOYMOrt9b/FqW/Tc+e2lxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 01:03:32PM -0700, Dave Hansen wrote: > On 5/16/23 11:35, Ard Biesheuvel wrote: > >>> Does this mean that the kernel maps memory before accepting it? As > >>> otherwise, I would assume that such an access would page fault inside > >>> the guest before triggering an exception related to the unaccepted > >>> state. > >> Yes, the kernel maps memory before accepting it (modulo things like > >> DEBUG_PAGEALLOC). > >> > > OK, and so the architecture stipulates that prefetching or other > > speculative accesses must never deliver exceptions to the host > > regarding such ranges? > > I don't know of anywhere that this is explicitly written. It's probably > implicit _somewhere_ in the reams of VMX/TDX and base SDM docs, but heck > if I know where it is. :) It is not specific to TDX: on x86 (and all architectures with precise exceptions) exception handling is delayed until instruction retirement and will not happen if speculation turned out to be wrong. And prefetching never generates exceptions. But I failed to find right away in 5000+ pages of Intel Software Developer’s Manual. :/ -- Kiryl Shutsemau / Kirill A. Shutemov