From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EE8C77B7A for ; Tue, 16 May 2023 21:44:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7240E900003; Tue, 16 May 2023 17:44:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ACFD900002; Tue, 16 May 2023 17:44:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54E96900003; Tue, 16 May 2023 17:44:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 40AF6900002 for ; Tue, 16 May 2023 17:44:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0FDE9A03E9 for ; Tue, 16 May 2023 21:44:33 +0000 (UTC) X-FDA: 80797447626.28.6D5FBF0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 2EE7210000A for ; Tue, 16 May 2023 21:44:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=XeCQ=BF=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=XeCQ=BF=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684273470; a=rsa-sha256; cv=none; b=RRMu2NHsM2Obm9SAlauUaeg13xfk77UY60rf32NFcODd9p58dQLSHxEPiZHRsdfZhRYbef 8xJPisgUKLwTvxPYBJnZ2kR86OQX7pVF6CXDGyllhQL5ZWO+jBqYJ7xpTVzCFkpSqt6yJc QpaV+mJdvxc2EYpVQD1mqRno7LDJLis= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=XeCQ=BF=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=XeCQ=BF=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684273470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vsAa0ECFhP+DYe3EBxahBbbDkuGvlFEm/cMsQGgjzeg=; b=q+nUcHvxVqj3H/a4UzAN1LEhXD0TthGwZW8RuJOSbyNBlJ1XZ6PpP0rE9Qqy/2xcJVI6ii PzHKcYcJYmezBY417ypBNXlbO8GvH7Ch8x7G1KBtxQu7sik+7wIvmjK7OssQU46TS3ZG17 hFjzZrVVWiblvI6TUq0CGOwUxbxdV+o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B42C632DB; Tue, 16 May 2023 21:44:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF912C433EF; Tue, 16 May 2023 21:44:25 +0000 (UTC) Date: Tue, 16 May 2023 17:44:22 -0400 From: Steven Rostedt To: Arnd Bergmann Cc: x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Masami Hiramatsu , Mark Rutland , Juergen Gross , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , Peter Zijlstra , Darren Hart , Andy Shevchenko , Boris Ostrovsky , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/20] x86: move prepare_ftrace_return prototype to header Message-ID: <20230516174422.63e1e942@gandalf.local.home> In-Reply-To: <20230516193549.544673-2-arnd@kernel.org> References: <20230516193549.544673-1-arnd@kernel.org> <20230516193549.544673-2-arnd@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2EE7210000A X-Stat-Signature: e3pq1oipgum5adoqb5rdweuhp1dnq3a3 X-HE-Tag: 1684273469-820357 X-HE-Meta: U2FsdGVkX1/99cV+6+hMUj5netMgSVsR7ujKCQxe8PytEOU70D1/kFFTf/LWNUjghucSOwAPrESRVbjhR1iV97T9DRe/X/Zas41UfOmJVKhFhDozZdJVw3RQZfshC7e1KNyZMogi/rAmpXNSqIu4ftWeXDoCgAJfovc26GmEMT+xI5DGcm/BYjrcKYEWkgASsM14//nH4DcYWhRI71iOF3hhZBPTEozZKfwOf2rx/JH/UEPI/nDXqL8mLJUfgRE5xevONj5rcQaAjq1zUT+ObsZv6WIyNWEt+gPik4H5R7hrvpNRZElwoHSaXSrLTtDPx0CLGwbst0fzJAHIvwLwpMA5a6Q/7t1P6kZcCiuvpRgy/Orb2AdlK0M0bk8s1naP1xnarwNgojAK9xOEIfaS12wk2rHR+jcxw1efUogzv/lCIvasvpQpBKhUn6DwzqGDxMNaY6XUTnMYje+I8+gVjRfQdV6UKX3HWlQ6TMux2apKlvUtg/p/9UJThZhdSx4KbMV8WcUkpVrjv9zkcvwjohXIz3lmm3cLFQBQO6nFPB/IaH+YxDPDaUCcvzZ79CtYDf9kSyPq4tjx97aFdcG0fUsJR/BRpW6IoUrDvs3R2bPSKzF9Gn7x4f+nlHCxJuZ/BJiILpXFrl0o+N1mkwvJTOCozy0ZfB+k6FIeR6DuPkOuX3uzb3FhVDALM17qdCNSpEglWRPUlZF4MTdnXe67qkhE5VOOLpFfUEZwnuLLIB7DIvDeqm+AN42IcYSTUWocMpoACjoLMcNVSjVfD2FD7ITNlGcD31jYmDoPlaDg/sc7OBxQUevzjbH6QqhiHJHeoLv/pGjRHUW4i726UPMOXVUBA1dUq0SEZXUr1/LAzWwQMkBBkdQ9FWovK/pKNHqiI95I5Ht9otuDfwh4B3ZuBqFqUdHWBTqpuAi2mQZBlirY3kKwIeT4GjfalF6JRLyWAU108+ZF5Q8p3AvYSqi tYpH+biu HJZXx+dCsr+IxOoUxdMmMjURTBnXrNukYpZbUSxP9kw7rr6xEO9xAD2QcpnJ4okqU730gSbaqTnU5rIaiHpkPiBFDub4d+NRsfOF/i/FijZOXkQd5cpsoHeq49JayDCmXLK3Otrn1ZOASZvBwir7L4kXxevoa8Bz6Zw6/Wz34yoSNJhusTwGX2P9pKgMfVdrLLuBkYJ+RMZdFSe7Z2ghSMLq41/QkWgMPlkXjz6aSk3PM8dzc15mePqgzR9R3g7o/h6H302WL+Ycl49V3irsz3/48pPryezP/MTmBUHwybOZVVWiXJqTSQMHKYeQiVR9QcZsDRUxL+yivyn7kD+fjyQ7JWfoUW6qI7o38Bl+t469GSOGvixyNvwpTuSVFGNq2E78gvEcHprEOsK4haKkilrl4nghjmuu606JRMHLDNMwgsAT4pH9y5bRnzuVYKYipFB4jfts7fFmCzPgeC/PNq+nmaoD6Rv0JTIFdQ5ylvjJZDxtQaABjaMbh9F/tWpDvOJ3RmMfCLpjLg8U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 16 May 2023 21:35:30 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > On 32-bit builds, the prepare_ftrace_return() function only has a global > definition, but no prototype before it, which causes a warning: >=20 > arch/x86/kernel/ftrace.c:625:6: warning: no previous prototype for =E2=80= =98prepare_ftrace_return=E2=80=99 [-Wmissing-prototypes] > 625 | void prepare_ftrace_return(unsigned long ip, unsigned long *paren= t, >=20 > Move the prototype that is already needed for some configurations into > a header file where it can be seen unconditionally. >=20 > Signed-off-by: Arnd Bergmann > --- > arch/x86/include/asm/ftrace.h | 3 +++ > arch/x86/kernel/ftrace.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > index 5061ac98ffa1..b8d4a07f9595 100644 > --- a/arch/x86/include/asm/ftrace.h > +++ b/arch/x86/include/asm/ftrace.h Acked-by: Steven Rostedt (Google) -- Steve