From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDA5C77B7F for ; Tue, 16 May 2023 12:29:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F0DE280003; Tue, 16 May 2023 08:29:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A128900002; Tue, 16 May 2023 08:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED17E280003; Tue, 16 May 2023 08:29:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E1197900002 for ; Tue, 16 May 2023 08:29:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B0B321A0237 for ; Tue, 16 May 2023 12:29:47 +0000 (UTC) X-FDA: 80796049614.28.7920466 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf15.hostedemail.com (Postfix) with ESMTP id C4B8CA0005 for ; Tue, 16 May 2023 12:29:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=oCuLtW6r; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684240185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h5oHxYRsTEmVik20ogmOFpOFFX6Yhrdsk15XGgVQoDA=; b=44ZAhBr3+DsjiebMRYSl9F3cLV7jBmJsdQ/EVIySZwN6dwnoZqqnZbhq/h3VEFag+wQe4O xvJLGqs05+85e3HkGBfA+oKWL2NeXXsgGCxQSdDi/rjlgWmik+JqX4edi4PoUYvxEkiE+C Dhh+3u/dn7rhRC5jCCTpLhDSmCu+UGQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684240185; a=rsa-sha256; cv=none; b=kLU1vZt8fXs3JBr3uISB7+UtoNsE1q82NJEXcrUYDDck13rlHGFonlfUCCzVKs6eEsVYm2 qRHK4rxi/emKVayhR/DG2I7BiJEt4nE8QPbEi71YtDr4ro+JmrdCaka4dfbjyetsKCkROR 5wSO4VY+f6QaA75HAK/hxkfgWbiExU8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=oCuLtW6r; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-64388cf3263so9982072b3a.3 for ; Tue, 16 May 2023 05:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684240184; x=1686832184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h5oHxYRsTEmVik20ogmOFpOFFX6Yhrdsk15XGgVQoDA=; b=oCuLtW6rxIJaWwNGL8Gi9wTXXIW2qzacrl3o+LtG6Rti2vdxMR40bwyRfxhDbipOSG MsewJKDE9Rii64HvSCHJJtIA3LXz8siJy94A+QqOQkhxnT8MpFfPLGT6IEFWywCyeCD/ YvL0tR68cppBDCKv7yweg3Y4r6iU0l/MA++oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684240184; x=1686832184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h5oHxYRsTEmVik20ogmOFpOFFX6Yhrdsk15XGgVQoDA=; b=L2k5Wj4Qiwu0OUkbg8cDEPYz2KLreDoFxBbITRgIYk7s0AgDON08QqeHa+5wrmRsGY jNEXJ51SLrLIDzxxIPOgLbUZAD3dydq34oHJwIqauZkmoXcP/w7+UeefULFfiuCrGkph nAksEhQKmvd9c04mapNUuT2+J8MN8kw8qCbt/ZlJxS02ihlQBNd5gQJhsEI3bBsL7kws SuytvyNRH9z4xm5j5l8u3msVxJsGo4xWaZkAAKK+On+bQe9GsdXJAEZe0vhFbo40jCKm xLobLkhPtXoV8fCP2PxZN/PHzmsV/kYKIMldB1oak3HCcv1bDzIsvpnYW8ZW8r3SSS1y oRQA== X-Gm-Message-State: AC+VfDxR0UmNTi0E3wQYi9glyaWPywvztRt5bXRCpUaQJF3HU1lA0UHK 3bRFXokBaQQdOfTD1cyX/8RDLw== X-Google-Smtp-Source: ACHHUZ6hpW1u699BdtJ7qhDcE6n6rqI46EVNi3KymLGq37oJvvtnTkFtXmot0FaVNcU0paAZLLQwaw== X-Received: by 2002:a05:6a20:431b:b0:101:4c8c:d1ee with SMTP id h27-20020a056a20431b00b001014c8cd1eemr30159998pzk.50.1684240184516; Tue, 16 May 2023 05:29:44 -0700 (PDT) Received: from google.com ([110.11.159.72]) by smtp.gmail.com with ESMTPSA id 3-20020a630a03000000b0051b930b2b49sm13498650pgk.72.2023.05.16.05.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 05:29:44 -0700 (PDT) Date: Tue, 16 May 2023 21:29:39 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: Sergey Senozhatsky , "minchan@kernel.org" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage() Message-ID: <20230516122939.GC15689@google.com> References: <20230516095029.49036-1-avromanov@sberdevices.ru> <20230516095327.GA15689@google.com> <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881> X-Stat-Signature: jbr9oex4ipwxfb5fnaf7ijuxw6tt5umz X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C4B8CA0005 X-Rspam-User: X-HE-Tag: 1684240185-888110 X-HE-Meta: U2FsdGVkX1/BVvvQN5+F5SQd8fl4HGNOvFxO7gm3ovNoBbDXluRxEBykMoKB2cubf1NUeMsjWd8MZfd+iwYQylSeLTG5EjM9PiGcpqd2TrTytt1feGYImLw+nm+8CBSXlfr9ZxdjqnM6gHksHbYLPuqDxILnEH5rTAt1lxdgn8+6wsiE370P1Hj1w3EUca05JqCa9SMeCU8HNtPwQUb46OPhPj4n8BL4IJtJ/20ABmBbMksHWrrJutlK6QNKrOJaRdfZS7wBV1JPV2yI7cnk2dhzwytJ/h5cxGtEQKJJnrOrFI9L4jW/aPR0epZRyi41ZV4xUSufJi8kvWLIgwK8QBBuWHZtcp3dFXAGjdSpkE+tS+J9Ne9TAVT9KaNBB3ThSDyjYaMHvHcXyQRiVMvLCfDinO5KVJLB/HTkI7BJSl13Mq2LS6HOFohBtR2cd9ALaVwNk8uNuwP+xzOKgMjBAGlauPUlSJj4HVPkOSLncEQA6vD6K7/6g0miNuiipnAkRwNBqYLptHJIP8aGdhKlMwl6OGOc5ifHLJW9gw1zin9LcqVCQ5Rk3l5KuC5VJcq3OnTJMUNWtzDtwRgnvK0GiL3o2re49OcUH62Mu5DQAWuW1OZMvM5/1/9wMpdUgCQHsbRD0fekNBzPA3ng9AxIOcanbIDWZ7XuigpEh4b22/Og8iR5LXS2dowakyXMpzotiHiQzQBzw2Zn+xsyVLGpsrEN1FHx4fh4tFEnwHtnxJzv9kGStcq8PXmaD4v4ReIjQenUnnG2wMEnWPL39qeRA3NrUq1XciVQq9od1QG3oDMD7rLWDSNrZDe7s4TgwZLr2npDYJngjCRzijj+rBOaItLIFqTw3Ic7vFqQ/VLg1WgrScLOW6xZ+9JlpCzNGlsNDzT9AM4vPbLhush+OhMKRWWZfL5tQY57ES0QaZKKZd5fq2DsWRLx/ToyeMbUucPegEtpOq5Ja4QPbTfAiXp qRfT+U+7 YTsPpS7uwmr0nNR3cf36OYVNXyD9cCRgBWhw494pEw17fmmlvpyPKKnEToOJq9XGaRXbNz8b1GL+fMiN2wJB1CArLe6egNW1fdm5HI3jND4F8qTNhvaE+oBGYT8Jb8kbn5JbI6RyCpMMr8AH90eqjAEFhW3yyhzzwMOmE0rRUFj0szHN7KJJ+Lj7DSqNRjAhVH7VTM7YPHdcseB2GyEmek+GIU3w6+kIZdmTDUJWqlqvLytizcM2flzjnIi3XuOcRLMspzmCd76/75itWnUNN7g17SAoEqQcFCxfQo0poWiW1+YdmdZTBOME83CX7OCiOLFV+EWJBkKwYb9H1go22TtueKGQlALN1EYD+ti6/xTBNjZ/d6JFcJrIu95A1MpgnPn1nmxwKnKXukPEWSnlcMnCfAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/05/16 10:11), Alexey Romanov wrote: > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > > index 702bc3fd687a..f23c2da55368 100644 > > > --- a/mm/zsmalloc.c > > > +++ b/mm/zsmalloc.c > > > @@ -1888,7 +1888,7 @@ static struct zspage *isolate_zspage(struct size_class *class, bool source) > > > fg[1] = ZS_ALMOST_EMPTY; > > > } > > > > > > - for (i = 0; i < 2; i++) { > > > + for (i = 0; i < ARRAY_SIZE(fg); i++) { > > > zspage = list_first_entry_or_null(&class->fullness_list[fg[i]], > > > struct zspage, list); > > > if (zspage) { > > > > This patch needs to be dropped. We don't have that function anymore. > > Do I need to sumbit v2 without this patch, or will Andrew just take > only the 2/2 patch into the branch? Let's hear from Andrew, but I think v2 won't be necessary.