* Re: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage()
[not found] <20230516095029.49036-1-avromanov@sberdevices.ru>
@ 2023-05-16 9:53 ` Sergey Senozhatsky
[not found] ` <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881>
[not found] ` <20230516095029.49036-2-avromanov@sberdevices.ru>
1 sibling, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2023-05-16 9:53 UTC (permalink / raw)
To: Alexey Romanov; +Cc: minchan, senozhatsky, akpm, linux-mm, linux-kernel, kernel
On (23/05/16 12:50), Alexey Romanov wrote:
> mm/zsmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 702bc3fd687a..f23c2da55368 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1888,7 +1888,7 @@ static struct zspage *isolate_zspage(struct size_class *class, bool source)
> fg[1] = ZS_ALMOST_EMPTY;
> }
>
> - for (i = 0; i < 2; i++) {
> + for (i = 0; i < ARRAY_SIZE(fg); i++) {
> zspage = list_first_entry_or_null(&class->fullness_list[fg[i]],
> struct zspage, list);
> if (zspage) {
This patch needs to be dropped. We don't have that function anymore.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 2/2] mm/zsmalloc: get rid of PAGE_MASK
[not found] ` <20230516095029.49036-2-avromanov@sberdevices.ru>
@ 2023-05-16 9:56 ` Sergey Senozhatsky
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2023-05-16 9:56 UTC (permalink / raw)
To: Andrew Morton, Minchan Kim
Cc: senozhatsky, linux-mm, linux-kernel, kernel, Alexey Romanov
On (23/05/16 12:50), Alexey Romanov wrote:
>
> Use offset_in_page() macro instead of 'val & ~PAGE_MASK'
>
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage()
[not found] ` <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881>
@ 2023-05-16 12:29 ` Sergey Senozhatsky
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2023-05-16 12:29 UTC (permalink / raw)
To: Alexey Romanov; +Cc: Sergey Senozhatsky, minchan, akpm, linux-mm, linux-kernel
On (23/05/16 10:11), Alexey Romanov wrote:
> > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > > index 702bc3fd687a..f23c2da55368 100644
> > > --- a/mm/zsmalloc.c
> > > +++ b/mm/zsmalloc.c
> > > @@ -1888,7 +1888,7 @@ static struct zspage *isolate_zspage(struct size_class *class, bool source)
> > > fg[1] = ZS_ALMOST_EMPTY;
> > > }
> > >
> > > - for (i = 0; i < 2; i++) {
> > > + for (i = 0; i < ARRAY_SIZE(fg); i++) {
> > > zspage = list_first_entry_or_null(&class->fullness_list[fg[i]],
> > > struct zspage, list);
> > > if (zspage) {
> >
> > This patch needs to be dropped. We don't have that function anymore.
>
> Do I need to sumbit v2 without this patch, or will Andrew just take
> only the 2/2 patch into the branch?
Let's hear from Andrew, but I think v2 won't be necessary.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-16 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230516095029.49036-1-avromanov@sberdevices.ru>
2023-05-16 9:53 ` [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage() Sergey Senozhatsky
[not found] ` <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881>
2023-05-16 12:29 ` Sergey Senozhatsky
[not found] ` <20230516095029.49036-2-avromanov@sberdevices.ru>
2023-05-16 9:56 ` [PATCH v1 2/2] mm/zsmalloc: get rid of PAGE_MASK Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox