From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Alexey Romanov <AVRomanov@sberdevices.ru>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
"minchan@kernel.org" <minchan@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage()
Date: Tue, 16 May 2023 21:29:39 +0900 [thread overview]
Message-ID: <20230516122939.GC15689@google.com> (raw)
In-Reply-To: <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881>
On (23/05/16 10:11), Alexey Romanov wrote:
> > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > > index 702bc3fd687a..f23c2da55368 100644
> > > --- a/mm/zsmalloc.c
> > > +++ b/mm/zsmalloc.c
> > > @@ -1888,7 +1888,7 @@ static struct zspage *isolate_zspage(struct size_class *class, bool source)
> > > fg[1] = ZS_ALMOST_EMPTY;
> > > }
> > >
> > > - for (i = 0; i < 2; i++) {
> > > + for (i = 0; i < ARRAY_SIZE(fg); i++) {
> > > zspage = list_first_entry_or_null(&class->fullness_list[fg[i]],
> > > struct zspage, list);
> > > if (zspage) {
> >
> > This patch needs to be dropped. We don't have that function anymore.
>
> Do I need to sumbit v2 without this patch, or will Andrew just take
> only the 2/2 patch into the branch?
Let's hear from Andrew, but I think v2 won't be necessary.
next prev parent reply other threads:[~2023-05-16 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230516095029.49036-1-avromanov@sberdevices.ru>
2023-05-16 9:53 ` Sergey Senozhatsky
[not found] ` <20230516101137.gqu5746k6qzigsw4@cab-wsm-0029881>
2023-05-16 12:29 ` Sergey Senozhatsky [this message]
[not found] ` <20230516095029.49036-2-avromanov@sberdevices.ru>
2023-05-16 9:56 ` [PATCH v1 2/2] mm/zsmalloc: get rid of PAGE_MASK Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516122939.GC15689@google.com \
--to=senozhatsky@chromium.org \
--cc=AVRomanov@sberdevices.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox