From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1658BC77B75 for ; Tue, 16 May 2023 02:07:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DC64900004; Mon, 15 May 2023 22:07:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88BBF900002; Mon, 15 May 2023 22:07:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75360900004; Mon, 15 May 2023 22:07:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 660C5900002 for ; Mon, 15 May 2023 22:07:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 308DFC13FB for ; Tue, 16 May 2023 02:07:03 +0000 (UTC) X-FDA: 80794480326.14.6FB6BD5 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 61C2F1C0010 for ; Tue, 16 May 2023 02:07:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QT2DhAFl; spf=pass (imf20.hostedemail.com: domain of ssawgyw@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=ssawgyw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684202821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=3b3x92cRQSciqeDzNgNXsU0gyL4nwobJzXcCOoED950=; b=QW3cKeglE0uOmnQFuIaBpyKe7urjuE7JdHPmUuIZB+tfTkisDOBAR4Jbu/cEAs7QMEuiaP p3evteRvspI2wqI2uFz613oz2sChx7NnbJTLRQA6MqmguPi2SyW3cO7E8yzuxTQkliQjVd 7BtYhFWfdZt9v1a6OTH6YUeHdG9NqQY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684202821; a=rsa-sha256; cv=none; b=sT2Db2j+TR8g35Dc/r/JJS/zvE7e4XVguB5gGBaQo3U0t9ZMz3YLqS1SGyQw41AOspvQgh SBDXX7s4FkWlfd7r9MlZcdnNzR0fQuJmMjd8liySB8bGj9XG5eAsv/MVdk1OHlbKAdYe59 ZwmSaBX8mf2bB//pBDN5h4BRmP+kgY8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QT2DhAFl; spf=pass (imf20.hostedemail.com: domain of ssawgyw@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=ssawgyw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-64395e741fcso14032258b3a.2 for ; Mon, 15 May 2023 19:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684202820; x=1686794820; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3b3x92cRQSciqeDzNgNXsU0gyL4nwobJzXcCOoED950=; b=QT2DhAFl77VqGnOxxCpMJhJSSAyPb54gGpT1BAO6l59QXrAdD5fJu0Kt7OMSmihShr bJpgvvTCxFtB9e7iZ5BjAoOTLppRPT9xZ1YTH0Y6TZTYM53NXOAbDTshx0O+9Rb2KzQX z80YsumZ54nrPMDsXZ5jp14RqfE62divxQ2/Phg40dhSFspAB/FLKoONjo3ii3MqwKJF li4kI1P3JQBmxO10oKzdyVphqV1HcCMYy86yNjYus6YgCUwJBfKBX31yjas/0W4oFJ7K qob9ryOpeuGURc4/T2hu+oNEnLsCAaA78QHnTbZrgnuG2pHBbDfXl2OykftfnAnp3y20 F+RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684202820; x=1686794820; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3b3x92cRQSciqeDzNgNXsU0gyL4nwobJzXcCOoED950=; b=dLi4P0Z2y96Fr9uXmjSVihyicpCJoBxdOGd/i38E5meSm5eVsuePTeE8Jlzff62tiq qfC7XW28B71hRGaxRl0wuHCpdZf1hUYQ7YcqhukoQ0RFvdBS0Us/Dmr5fzO0LkIJ4ifY P1Be4FXGxlcraMcxGABWvsvLKbwH8r0eL9FEc8KAtOqTLGAyGdbx/is8Y12Ac8o9FRZN X16IusFk8ZYEGeug6H2/wSXkMuZp4Vqipy91I3BaNmGPxjoTBAoSyU+QwQr9+IPiZnxv K10XWe1adI/LBOCKVpBYjlutLInnDkZxKg17ee9N+QxrVLGhFrSVn/EsJ0SWfrPiRy/K 0u/w== X-Gm-Message-State: AC+VfDx3njwJvobbsilm7bAXkewKva5GRW+B0iAyXs9dsegR1VYIRl4Z 4aVhzCQWt0VQWLaruLRtn6w= X-Google-Smtp-Source: ACHHUZ6uyp1wXv8kS0mHoGc0X/Ma5U1pCZ11zYHuIpGiuEM6/NkZqxUWO4GHvNuaALJdmgYbD90g9w== X-Received: by 2002:a05:6a00:ccc:b0:643:9cc0:a3be with SMTP id b12-20020a056a000ccc00b006439cc0a3bemr44337342pfv.5.1684202820065; Mon, 15 May 2023 19:07:00 -0700 (PDT) Received: from localhost.localdomain ([45.43.34.98]) by smtp.gmail.com with ESMTPSA id p19-20020a63f453000000b005287b22ea8esm12318753pgk.88.2023.05.15.19.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 19:06:59 -0700 (PDT) From: Yuwei Guan To: rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yuwei Guan Subject: [PATCH] memblock: Add flags and nid info in memblock debugfs Date: Tue, 16 May 2023 10:06:45 +0800 Message-Id: <20230516020645.160-1-ssawgyw@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 61C2F1C0010 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 6bffii4ghryq4um3icyme56f3dfaa5t1 X-HE-Tag: 1684202821-57731 X-HE-Meta: U2FsdGVkX1947C+oeeuV6W+xHkuD9ZxiqlRNPsJVigQ0ZlU/LjVZZJmNMAcNrnkuPSKL2yia5D4Qjs76mDDhovwFWgg83VY0zf3kTJJjvny92rqJl82Se/X1anHIyT5yhC64cIRbqOfY1Fdl4oKVwVmckQEWXcd1doFy4XM46oNx1+Is4cxPjHZUUq5KAthJ44hFlu9SSYHt10AOhTlM0/4TrstbncsNKpHNLGL1RuzAVkBkboMBp2OO0pSzXctt5/Olkkw+yAc2x1XM90FypRvcOWYihKZSNDLBHuhQGQqlgHWsvRva3B/uUOTsZYdFwqZaADLl2Q2a38t63Mp41B2jubZsbFcRPv8fwd5Zf0yY3Hu4Bg2tCU55958r8ILNc4C7Uz8xvo1syuYtMCOEvKJ4huKHAMPIVts3AkMb2HBNBXwg6rC90qojLg+JT4vAKCqCy2GLklg7Sr3B5v2YKCLeAMqeWtxBoFVtAbfgJ+Hk5Yqe5wwZkFyZaYczk5XgPeIpudA1irUA3pzmY4SkpdCjpY1XhhVK+dmllYpyLWCCV0OsKm4LrAJYFr05rqn+1IAlEKMj3DEElxdz47f8Edr7lA4CdlTN7BPZ9BjI0/oukONWzOaJHf9wcSgksbeUnmWsqPyr/tjwlfqROc262fbi2BW3MZpcsKHRRMtCbScVvwIDh7P5m7qlodIU6DdZbvHPzjtkAF1W+9GwkZ4vv18mCXZXnpLAfulKmYNwWcU7mSeP88frcoITsDMsvg0mNX90n3meFAuAFaEKHHVwUa5P+rcsctLbBoJIIgaEi1Sdh9qPWI5bprC6dCHuM1FPt8Xp62KRur8OT2ar/HqeXijVfziMd8jhKKCsY1aiu1YaBsSxZXZ0XgGBaOvcUQygTAoWcctQSLLkN93dagzfD+amExDSoN4cLRTj7yTvb0zF73efld1jQvC7fzkAFhlQradid9vxM2gbDJfKKPq 6GOLeMj/ rRHjYK+WUgnUGhb0hACM8cL22THSeWDRGjt4Zq2YLxPV1Q/sv7PLj4mlwc+Rha8+RMBlmprmWMfgNJMaiqVAjBladOfu3BSCXt9LHDQX9DNGl2F88wuTQY4Zby73wC6nT4/+nejO0s3ThpSIIcgFZ0Gd34joKv/Je04wXo7BYdCJiggx1/H6J3IhYLNx5f5nyIvkACeAQbA/FkkOn9mJCm5HFUUEsmQWDKwWQrZb212O4oh7yIbACozUnLsngQ6tDEMZUuYoD02E5HgTmQdCincGygLMkqaKwwZGmF3jDfI2mK022wZsqad9EiZI+aMwWoL5UAQHdEW/z/zRV6cgp+0GUsSgvdjgZr6d3zs+ZEKvgigYJfMm7Phx6xuni0Ob2zHVYDbG+Q+OBF/PCvtPsu6IFM9WSUoQFPHUw3YD55KNIs66N3JkkCO791WeaEOVFVqd9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently, the memblock debugfs can display the count of memblock_type and the base and end of the reg. However, when the following scenario occurs, the information in the existing debugfs cannot make it clear why the address is not consecutive. For example, cat /sys/kernel/debug/memblock/memory 0: 0x0000000080000000..0x00000000901fffff 1: 0x0000000090200000..0x00000000905fffff 2: 0x0000000090600000..0x0000000092ffffff 3: 0x0000000093000000..0x00000000973fffff 4: 0x0000000097400000..0x00000000b71fffff 5: 0x00000000c0000000..0x00000000dfffffff 6: 0x00000000e2500000..0x00000000f87fffff 7: 0x00000000f8800000..0x00000000fa7fffff 8: 0x00000000fa800000..0x00000000fd3effff 9: 0x00000000fd3f0000..0x00000000fd3fefff 10: 0x00000000fd3ff000..0x00000000fd7fffff 11: 0x00000000fd800000..0x00000000fd901fff 12: 0x00000000fd902000..0x00000000fd909fff 13: 0x00000000fd90a000..0x00000000fd90bfff 14: 0x00000000fd90c000..0x00000000ffffffff 15: 0x0000000880000000..0x0000000affffffff So we can add flags and nid to this debugfs. For example, cat /sys/kernel/debug/memblock/memory cnt flags base..end 0: 0x0 0x0000000080000000..0x00000000901fffff 1: 0x4 0x0000000090200000..0x00000000905fffff 2: 0x0 0x0000000090600000..0x0000000092ffffff 3: 0x4 0x0000000093000000..0x00000000973fffff 4: 0x0 0x0000000097400000..0x00000000b71fffff 5: 0x0 0x00000000c0000000..0x00000000dfffffff 6: 0x0 0x00000000e2500000..0x00000000f87fffff 7: 0x4 0x00000000f8800000..0x00000000fa7fffff 8: 0x0 0x00000000fa800000..0x00000000fd3effff 9: 0x4 0x00000000fd3f0000..0x00000000fd3fefff 10: 0x0 0x00000000fd3ff000..0x00000000fd7fffff 11: 0x4 0x00000000fd800000..0x00000000fd901fff 12: 0x0 0x00000000fd902000..0x00000000fd909fff 13: 0x4 0x00000000fd90a000..0x00000000fd90bfff 14: 0x0 0x00000000fd90c000..0x00000000ffffffff 15: 0x0 0x0000000880000000..0x0000000affffffff Signed-off-by: Yuwei Guan --- mm/memblock.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 45f198750be9..34230b258e21 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2045,11 +2045,21 @@ static int memblock_debug_show(struct seq_file *m, void *private) int i; phys_addr_t end; +#ifdef CONFIG_NUMA + seq_puts(m, "cnt\tflags\tnid\tbase..end\n"); +#else + seq_puts(m, "cnt\tflags\tbase..end\n"); +#endif + for (i = 0; i < type->cnt; i++) { reg = &type->regions[i]; end = reg->base + reg->size - 1; - seq_printf(m, "%4d: ", i); + seq_printf(m, "%d:\t", i); + seq_printf(m, "0x%x\t", reg->flags); +#ifdef CONFIG_NUMA + seq_printf(m, "0x%x\t", reg->nid); +#endif seq_printf(m, "%pa..%pa\n", ®->base, &end); } return 0; -- 2.34.1