From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 28/35] maple_tree: Add mas_next_range() and mas_find_range() interfaces
Date: Mon, 15 May 2023 16:26:50 -0400 [thread overview]
Message-ID: <20230515202650.3psyybdg64ptmx6i@revolver> (raw)
In-Reply-To: <20230512160857.820fc7a14256c1031c586113@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> [230512 19:09]:
> On Fri, 12 May 2023 14:20:29 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
>
> > Some users of the maple tree may want to move to the next range in the
> > tree, even if it stores a NULL. This family of function provides that
> > functionality by advancing one slot at a time and returning the result,
> > while mas_contiguous() will iterate over the range and stop on
> > encountering the first NULL.
> >
> > ...
> >
> > +/**
> > + * mas_contiguous() - Iterate over a contiguous range of the maple tree.
> > + * @__mas: Maple Tree operation state (maple_state)
> > + * @__entry: Entry retrieved from the tree
> > + * @__max: maximum index to retrieve from the tree
> > + *
> > + * When returned, mas->index and mas->last will hold the entire range of the
> > + * entry. The loop will terminate on the first NULL encountered.
> > + *
> > + * Note: may return the zero entry.
> > + */
> > +#define mas_contiguous(__mas, __entry, __max) \
> > + while (((__entry) = mas_find_range((__mas), (__max))) != NULL)
> >
>
> I can's say I'm a fan of this. The name doesn't imply that this is a
> looping construct. I can't say much more because mas_contiguous() has
> no users..
I got a little ahead of myself with that. I will drop it.
My hope is to introduce it to simplify the cases where users are
iterating over VMAs and want them contiguous.
I'll come up with a better name when I re-introduce it.
next prev parent reply other threads:[~2023-05-15 20:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 18:20 [PATCH v3 00/35] Maple tree mas_{next,prev}_range() and cleanup Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 01/35] maple_tree: Fix static analyser cppcheck issue Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 02/35] maple_tree: Clean up mas_parent_enum() and rename to mas_parent_type() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 03/35] maple_tree: Avoid unnecessary ascending Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 04/35] maple_tree: Clean up mas_dfs_postorder() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 05/35] maple_tree: Add format option to mt_dump() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 06/35] maple_tree: Add debug BUG_ON and WARN_ON variants Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 07/35] maple_tree: Convert BUG_ON() to MT_BUG_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 08/35] maple_tree: Change RCU checks to WARN_ON() instead of BUG_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 09/35] maple_tree: Convert debug code to use MT_WARN_ON() and MAS_WARN_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 10/35] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 11/35] maple_tree: Use MAS_BUG_ON() in mas_set_height() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 12/35] maple_tree: Use MAS_BUG_ON() from mas_topiary_range() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 13/35] maple_tree: Use MAS_WR_BUG_ON() in mas_store_prealloc() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 14/35] maple_tree: Use MAS_BUG_ON() prior to calling mas_meta_gap() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 15/35] maple_tree: Return error on mte_pivots() out of range Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 16/35] maple_tree: Make test code work without debug enabled Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 17/35] mm: Update validate_mm() to use vma iterator Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 18/35] mm: Update vma_iter_store() to use MAS_WARN_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 19/35] maple_tree: Add __init and __exit to test module Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 20/35] maple_tree: Remove unnecessary check from mas_destroy() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 21/35] maple_tree: mas_start() reset depth on dead node Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 22/35] mm/mmap: Change do_vmi_align_munmap() for maple tree iterator changes Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 23/35] maple_tree: Try harder to keep active node after mas_next() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 24/35] maple_tree: Try harder to keep active node with mas_prev() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 25/35] maple_tree: Revise limit checks in mas_empty_area{_rev}() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 26/35] maple_tree: Fix testing mas_empty_area() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 27/35] maple_tree: Introduce mas_next_slot() interface Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 28/35] maple_tree: Add mas_next_range() and mas_find_range() interfaces Liam R. Howlett
2023-05-12 23:08 ` Andrew Morton
2023-05-15 20:26 ` Liam R. Howlett [this message]
2023-05-12 18:20 ` [PATCH v3 29/35] maple_tree: Relocate mas_rewalk() and mas_rewalk_if_dead() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 30/35] maple_tree: Introduce mas_prev_slot() interface Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 31/35] maple_tree: Add mas_prev_range() and mas_find_range_rev interface Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 32/35] maple_tree: Clear up index and last setting in single entry tree Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 33/35] maple_tree: Update testing code for mas_{next,prev,walk} Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 34/35] mm: Add vma_iter_{next,prev}_range() to vma iterator Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 35/35] mm: Avoid rewalk in mmap_region Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515202650.3psyybdg64ptmx6i@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox