From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5854C7EE24 for ; Mon, 15 May 2023 08:40:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAD02900003; Mon, 15 May 2023 04:40:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5D06900002; Mon, 15 May 2023 04:40:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4DC5900003; Mon, 15 May 2023 04:40:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7252900002 for ; Mon, 15 May 2023 04:40:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 89B401213BE for ; Mon, 15 May 2023 08:40:18 +0000 (UTC) X-FDA: 80791842516.01.9F66F3C Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf24.hostedemail.com (Postfix) with ESMTP id 723DA180015 for ; Mon, 15 May 2023 08:40:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ehBz+j3a; spf=none (imf24.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684140016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RD5vUeFE3A5d4FsldbQHnKJtFa6t2QWFhZv+yAemSbs=; b=bFJu3/UziI3hSFdyAq4ODmHzkeGnkxhIF9KGTvq5ETuKUkTqgWdgpjkhiN+QlLrq/xsGrF L48kFkc98/G3xJJ6To4BfaS/JjyeW6gaCtoERdErPfuUOc6OE8LQ82UpfzMhyU0LDD0rGJ UA3Phl8njvsqyowoeJlUqgUk7KTFj4w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684140016; a=rsa-sha256; cv=none; b=s0CzvNuK2TLDN1llBoy8Zl+2JrfdGfdLWAOZIV98fEfPWr12TdD/wiaOOkwxI3KLqx38uo LuvRHSrbRp+N27ka+pax3g01DYh4vTaaVHpZYSBlhLa63g3a7tYSizljUxnsEZZtIYonml PjWAxPyjSYV+8utxShrLrpdj0whXoNA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ehBz+j3a; spf=none (imf24.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RD5vUeFE3A5d4FsldbQHnKJtFa6t2QWFhZv+yAemSbs=; b=ehBz+j3ahy4u5PW4uxa2uyGNJo EBFe6Q34nuEaAcRCI+tbeXc7I14zzi5e0u0+qZG7aqXj1MNfOu4KRMISLXOGqwnA5hH2j2eNrTkHu uQvvK793POjWSxg49Bbe9Huea69FbJY6OWwQVhEIhB0v3ZFTua6hfvAi2N1O7XtMkMCq+hB7KHr6a zLmj5NVEqXqcruefol8Zh/0kdINTJ9d0alQEcO5jwfieZwAbmNJOHWUD/XWacF58y3JIL6BVpFfeF KdBkyA4si0Bd8nM250rxBdgOPlkLy7SXTJXCnNvdpv+s8tyg9C137AV50ShsToAwqJmtGHX2cwYVL kPUWVCgg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pyTkW-00BQwB-2q; Mon, 15 May 2023 08:40:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9F4963001E4; Mon, 15 May 2023 10:40:07 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 69766202FCE90; Mon, 15 May 2023 10:40:07 +0200 (CEST) Date: Mon, 15 May 2023 10:40:07 +0200 From: Peter Zijlstra To: kernel test robot Cc: Mathieu Desnoyers , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com, aubrey.li@linux.intel.com, yu.c.chen@intel.com, Aaron Lu Subject: Re: [linus:master] [sched] af7f588d8f: will-it-scale.per_thread_ops -13.9% regression Message-ID: <20230515084007.GF4253@hirez.programming.kicks-ass.net> References: <202305151017.27581d75-yujie.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202305151017.27581d75-yujie.liu@intel.com> X-Rspamd-Queue-Id: 723DA180015 X-Stat-Signature: 1burdz5usc6mszwyqxfhw4fydnjpd1mx X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684140016-622707 X-HE-Meta: U2FsdGVkX1/lJqjbuOaL4dzN0fTMnl7ozEp1U5ab4su0P+prJcpZQIH4AkdDhu7BKiZDHFKrsMTd0zE6Z1IPxEy0vodwYTnfN2MhZYfxf1GifFRmqUIw17tJZcldeg1wPSPC49A8pi4GK+WRITN4qgTNhsgWF2jMl8Do0b6sP9+oshwkYx41//QtBpExOscnDEe+ynbfIivY7x25TXld09GEutypPRFhDLTimaqFKtSoZkpvp5vd2zJxBSM9I0A8V48Y99aKpWpO4mIiswlJvka3YMROIyRf0YapPeM+GN8jYEhS+0YMLRRsTkbqFmnsfUxesGHOUXA4Npr2OqTEt47omMVTxrU4uLnQOUUS8Imgz67bPwNh++RpFFo0MJpCCTbv6L/ttTrgRbBpSFD+Qiyj9Op8dFlo0U/4zPBAFD/uaHIvnFQSTTfP+MAHX+oUjLfNpSB1JMGDlI6qHNZDVjFgCaSYiAOdWMppz9y8c6iV8OqmdpsvxcxBIVlHCG1Gs+gh8ELVAkAf5WekYRM+KV35ifCgx54LoQcAQQcSqgmNRG5Ob4tANjUd4d/v4+eGe0y3hlg9LYr37/hJ75LIsoqmCtzqnIi2CwMUnhYGPlv7aAaRxfwGDb3bhfjWfysPZyvW+vIDj+xnzGnY77LCruZEjLuWIIeC6nAQs4PawG6rLBT1wF98j36I/tx08aRt5kbaZzTt1Kngy20eO8pxc/buySyvsj+EF0d+02rQF1U+/8NS5/Bwc7QSvDYJUMASgWLDcVAjHtRV+4w4xxbkAF0SluiGkscqt6HaxeUMl/uwSbN2zMrVckDWWFe8nUHdxue7BZdkSRLAwhBNtU4zIRwaO4YkExjas/4wcMvl9e3Egu8YVDt2tkM3YUxZpCPz3AClRJQYYFVGzBYAOZdZpRWevFFcE7FO4RowTkX2GKlIXjY1TVymRwUA0zC41NSo2OU338qRwDh+DQjhiGu xzll5HxG ZuHi3+ZE2klO2+aTqUIdAHB94T6UlT0OM9PISC2OPTeKAmBitMo6mTYrRNB/WfTKDnFDqoa+LmFtd5OnZ1qEILrzF5p+5w+AfK7FOFcKibNXKuVNppDqBDyDtgY7CmwWbxjr+3riDrvSG4Nc4T7Z+tVMLS0nrUv3RhOKIKT//46af3pzHprr/qs0ALVZbLYfFZwHbdzqvABSUnBoC8HLHUzK8HXk+uM0qAScLjLNSfIt6KOApcE6VVKskss9qBGVEz7mdu+3GBpDnJqC82FUvD/PiUCBS/YCbvqE+xA2dfbv4rzkaK9ATpLJj0ClWOjO3T3tLdSkQgIf76g8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 15, 2023 at 03:00:44PM +0800, kernel test robot wrote: > Hello, > > kernel test robot noticed a -13.9% regression of will-it-scale.per_thread_ops on: > > commit: af7f588d8f7355bc4298dd1962d7826358fc95f0 ("sched: Introduce per-memory-map concurrency ID") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > testcase: will-it-scale > test machine: 224 threads 2 sockets (Sapphire Rapids) with 256G memory > parameters: > > test: context_switch1 > cpufreq_governor: performance > > test-description: Will It Scale takes a testcase and runs it from 1 through to n parallel copies to see if the testcase will scale. It builds both a process and threads based test in order to see any differences between the two. > test-url: https://github.com/antonblanchard/will-it-scale > > In addition to that, the commit also has significant impact on the following tests: > > +------------------+----------------------------------------------------------------------------------------------------+ > | testcase: change | will-it-scale: will-it-scale.per_thread_ops -73.8% regression | > | test machine | 224 threads 2 sockets (Sapphire Rapids) with 256G memory | > | test parameters | cpufreq_governor=performance | > | | mode=thread | > | | nr_task=16 | > | | test=context_switch1 | > +------------------+----------------------------------------------------------------------------------------------------+ > | testcase: change | will-it-scale: will-it-scale.per_thread_ops -57.9% regression | > | test machine | 104 threads 2 sockets (Skylake) with 192G memory | > | test parameters | cpufreq_governor=performance | > | | mode=thread | > | | nr_task=16 | > | | test=context_switch1 | > +------------------+----------------------------------------------------------------------------------------------------+ > | testcase: change | will-it-scale: will-it-scale.per_thread_ops -85.0% regression | > | test machine | 104 threads 2 sockets (Skylake) with 192G memory | > | test parameters | cpufreq_governor=performance | > | | mode=thread | > | | nr_task=50% | > | | test=context_switch1 | > +------------------+----------------------------------------------------------------------------------------------------+ > | testcase: change | vm-scalability: vm-scalability.throughput -9.0% regression | > | test machine | 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory | > | test parameters | cpufreq_governor=performance | > | | runtime=300s | > | | size=2T | > | | test=shm-xread-seq-mt | > +------------------+----------------------------------------------------------------------------------------------------+ > > FYI, we noticed that commit 223baf9d17f2 (sched: Fix performance > regression introduced by mm_cid) fixed a sysbench regression, but > will-it-scale context_switch1 benchmark still saw a regression on this > fix commit. > > Furthermore, we applied the code diff in below link [1] on mainline, and > the will-it-scale score was restored to the original level before this > patch. > > [1] https://lore.kernel.org/lkml/d96164a6-c522-1bfc-8b37-333726cdc573@efficios.com/ > Right; so I'm thinking we can do that patch -- I'll try and get the whole lazy TLB thing sorted, but I'm not sure I can find the piece and quiet to think that over in a hurry :/