From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561C7C77B7A for ; Sun, 14 May 2023 01:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A7416B0071; Sat, 13 May 2023 21:12:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9576D6B0072; Sat, 13 May 2023 21:12:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F7E76B0074; Sat, 13 May 2023 21:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6CA536B0071 for ; Sat, 13 May 2023 21:12:27 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 323C114116B for ; Sun, 14 May 2023 01:12:27 +0000 (UTC) X-FDA: 80787085134.09.2F9CB42 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf02.hostedemail.com (Postfix) with ESMTP id 213F280003 for ; Sun, 14 May 2023 01:12:22 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Rb5E3BMX; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684026744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=V2tFk8QeHv0OSSZDK51MGpdrn9DJTwzpeLNU9IMD4wI=; b=8VQyxwy4ei394nBOB1UxQSbSWeQF/lOS0W6BX+qYCLIKt+iNkRzUKQJyQeE7X7fgSGxr3C 24XesFTU/9VNGMeAmsU/ISpkH6H/rhSfcJI+5A5XCrcjAzHxCznfUri05RGY6abJphCwAW 7QQ0bvZt44Hyc2zL0m1+J9rQ7wtHBP4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Rb5E3BMX; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684026744; a=rsa-sha256; cv=none; b=K7S7ZwjBkxZaTSzNFX1EbND1L6s2k91gu/whgFThPx9zY5EjS1a9ktqAEFaIseSziXjfdH VFX6zetorqlsKvFLwNI2gL+/B4vSn5X3zNhEankYMTUPGj7lJYI/HPgokUdIiFUfyBBuJ/ cSYagdSVDWibzwY5TE9IhJ/roJMtIZ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684026743; x=1715562743; h=date:from:to:cc:subject:message-id:mime-version; bh=BL3gXTlDPtjRQ02PdsakA5GhOQULnFBWoAr8tmwSARw=; b=Rb5E3BMX0/Cmv9HUI09aT98hfodVN7sId04psTAKKZZQddv0Zf157RRf PoVl0w/AxEVoNFVf0qrnQMyCbjzcmv99OGvrDwf1/t1ZGNdHMVJRNbhTy iXZSEn8GjhbXlfPd29FD3XHFRWtx3IONBcVgf9oo8mLL7UlWvCMx5Sa3r e/A2XEVldDa0sHuOfORXpMTvZ4munjgRFKF50oVa/byKX4pCgJ/qyI7dA r97WpSCb2E5tQCzw1sN0UGjcoitnRdWcA71bWU/3RD9QwmNXTbFzE6wht cdrZ94WB2KIidW9ng0TNpsURH3zJwkJUT3L8vTCbWCLcUiVsqJyHKAf+W Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10709"; a="330615980" X-IronPort-AV: E=Sophos;i="5.99,273,1677571200"; d="scan'208";a="330615980" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2023 18:12:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10709"; a="678052174" X-IronPort-AV: E=Sophos;i="5.99,273,1677571200"; d="scan'208";a="678052174" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 13 May 2023 18:12:19 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1py0Ha-0005lU-1r; Sun, 14 May 2023 01:12:18 +0000 Date: Sun, 14 May 2023 09:11:54 +0800 From: kernel test robot To: Shijie Luo Cc: oe-kbuild-all@lists.linux.dev, Greg Kroah-Hartman , Miaohe Lin , Andrew Morton , Linux Memory Management List , Oscar Salvador Subject: [stable:linux-5.4.y 1353/9999] mm/mempolicy.c:499:22: warning: variable 'mapped_pte' set but not used Message-ID: <202305140908.foLMWXHS-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 213F280003 X-Stat-Signature: 9fsam3njdcbcfz8iwa68mwbn7gocomsi X-HE-Tag: 1684026742-715257 X-HE-Meta: U2FsdGVkX19axj4r7Oo/I2y1OExGAkj/331Sum+175ukZgPOiGhKecgfkOHavn7MHOz8A1B5LUDze28auB26cbiFXBeLuE2flxGGv/b5oe0Dme0nHq9x3dv/9FniPb0OtJbsU/zpbhBhIb7MnibH5PR+DRlrj0qCSY8C5DIvMP7+jWxjcUVIPMsBU/Av1QZgDURM7O+kzNbJdoV+fze5DZjU9fxLlUWHVeCN7bK3tPc9im13Ap6T2F8Xk+dEd9bOviCo5EaISK5qgVMVjIh8pwBkxcuQ/3g1m+PpUdA6/rpoooNzsYyuZq6YIOOW8+Ho0OvA2+5MfoAAZSplCJoC3kVRVCG254yM3bpxEIs0EQuclEePXZXbeVTi6xHXYh9QqcXjdSGygy77JQK4WJehkLu8ulJPcoGsHLusSGs2bdyXllAc6dXVO8ecMmDSwAS84aYdnPReSewIWcw8jEDyHID09GeTCUPioa60E6eaefqvD++LjVds0tx2ywzIZkA6FWq9XrlZp4zK6U+E2Cr5jMvBZ74OSASZQ4TYnxuSBEMOHP2jT3tMa5bsXSor/XUExA8WfhUZTyXHsIsz/l5oqJqXB+yYdTHr++df1oBmVsipybkz0aAs+ojXEI+NShFQNHz0XRPnO74J26kIsRB5SWUAWKLUT7djDndrJrxuJ03p9Gsh61NmQTpGl5qpnQ5t4ldk9ryWbPXOYQ5nsEF+tHHtDno/Q5/H99I9Y3LLIsmt3KrmtpeTGa0tREq/bu6DLyMVPu7YHi+KawomS8OZPMZ9woSYJf2uqeb6st15S+8jC6ddTAUi8kzPSX0XAD6DZ2FUOj/4zVE5IIojJZSFKN1A4CHurFaeuYcZVMNDo0vf2ZXLi2s8G9GMqA1+fATjfmCt9ZirpE+60yW4wywy1aREsr2Oaru9pSALl+uPHOTasEUCaSr7cNNR4o9OW13UsJCsqC7n4nIT0yOfGq+ xkfZja03 yBwn8FTplwVK7DqyQQRX8LD75dIUbphpsip6FegHQiQo/4TmoHOkvIn9uBLoBfCJNVFhlC1DojwNcoMeqx7To1YsgWksABsT/LiR9OJYMhn7rElvlXgt/Cts8me4292/m++DOfad8hppOUwXx2GYfB50xEINyS+QgEnRlZN5J5kuVd1dm+HQx4lWK6mB2T/CRa9kMWXDg6vF3hHz3mJc5D5lECSKy7t1A2B7lLrxKKTZMN+YkpHDGYbP9hZ8SCAAnzz4KtJ/G+c5ox4gkPhu6RoZv6GKhGCrEOqXqLh9JsXLGXQWhusmucYhjhv2K6tvXMMt4vVQcKTzTPau3r+3bOI6K0YvBkrJz1zz+HKXhyigEgTMf1/2XzjJDJeVD14thx9QqPdELhQ1/E/uo4mYDsW0urG91DClHwJl3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Shijie, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y head: ea7862c507eca54ea6caad9dcfc8bba5e749fbde commit: c1f729c7dec0df04d62550d981af849f970a660d [1353/9999] mm: mempolicy: fix potential pte_unmap_unlock pte error config: ia64-generic_defconfig (https://download.01.org/0day-ci/archive/20230514/202305140908.foLMWXHS-lkp@intel.com/config) compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=c1f729c7dec0df04d62550d981af849f970a660d git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git git fetch --no-tags stable linux-5.4.y git checkout c1f729c7dec0df04d62550d981af849f970a660d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305140908.foLMWXHS-lkp@intel.com/ All warnings (new ones prefixed by >>): mm/mempolicy.c: In function 'queue_pages_pte_range': >> mm/mempolicy.c:499:22: warning: variable 'mapped_pte' set but not used [-Wunused-but-set-variable] 499 | pte_t *pte, *mapped_pte; | ^~~~~~~~~~ vim +/mapped_pte +499 mm/mempolicy.c 478 479 /* 480 * Scan through pages checking if pages follow certain conditions, 481 * and move them to the pagelist if they do. 482 * 483 * queue_pages_pte_range() has three possible return values: 484 * 0 - pages are placed on the right node or queued successfully. 485 * 1 - there is unmovable page, and MPOL_MF_MOVE* & MPOL_MF_STRICT were 486 * specified. 487 * -EIO - only MPOL_MF_STRICT was specified and an existing page was already 488 * on a node that does not follow the policy. 489 */ 490 static int queue_pages_pte_range(pmd_t *pmd, unsigned long addr, 491 unsigned long end, struct mm_walk *walk) 492 { 493 struct vm_area_struct *vma = walk->vma; 494 struct page *page; 495 struct queue_pages *qp = walk->private; 496 unsigned long flags = qp->flags; 497 int ret; 498 bool has_unmovable = false; > 499 pte_t *pte, *mapped_pte; 500 spinlock_t *ptl; 501 502 ptl = pmd_trans_huge_lock(pmd, vma); 503 if (ptl) { 504 ret = queue_pages_pmd(pmd, ptl, addr, end, walk); 505 if (ret != 2) 506 return ret; 507 } 508 /* THP was split, fall through to pte walk */ 509 510 if (pmd_trans_unstable(pmd)) 511 return 0; 512 513 mapped_pte = pte = pte_offset_map_lock(walk->mm, pmd, addr, &ptl); 514 for (; addr != end; pte++, addr += PAGE_SIZE) { 515 if (!pte_present(*pte)) 516 continue; 517 page = vm_normal_page(vma, addr, *pte); 518 if (!page) 519 continue; 520 /* 521 * vm_normal_page() filters out zero pages, but there might 522 * still be PageReserved pages to skip, perhaps in a VDSO. 523 */ 524 if (PageReserved(page)) 525 continue; 526 if (!queue_pages_required(page, qp)) 527 continue; 528 if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) { 529 /* MPOL_MF_STRICT must be specified if we get here */ 530 if (!vma_migratable(vma)) { 531 has_unmovable = true; 532 break; 533 } 534 535 /* 536 * Do not abort immediately since there may be 537 * temporary off LRU pages in the range. Still 538 * need migrate other LRU pages. 539 */ 540 if (migrate_page_add(page, qp->pagelist, flags)) 541 has_unmovable = true; 542 } else 543 break; 544 } 545 pte_unmap_unlock(mapped_pte, ptl); 546 cond_resched(); 547 548 if (has_unmovable) 549 return 1; 550 551 return addr != end ? -EIO : 0; 552 } 553 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests