From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Peng Zhang <zhangpeng.00@bytedance.com>
Subject: [PATCH v3 32/35] maple_tree: Clear up index and last setting in single entry tree
Date: Fri, 12 May 2023 14:20:33 -0400 [thread overview]
Message-ID: <20230512182036.359030-33-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20230512182036.359030-1-Liam.Howlett@oracle.com>
When there is a single entry tree (range of 0-0 pointing to an entry),
then ensure the limit is either 0-0 or 1-oo, depending on where the user
walks. Ensure the correct node setting as well; either MAS_ROOT or
MAS_NONE.
Cc: Peng Zhang <zhangpeng.00@bytedance.com>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index fd4f9f766cf23..ec4285e141d53 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5022,24 +5022,25 @@ void *mas_walk(struct ma_state *mas)
{
void *entry;
+ if (mas_is_none(mas) || mas_is_paused(mas) || mas_is_ptr(mas))
+ mas->node = MAS_START;
retry:
entry = mas_state_walk(mas);
- if (mas_is_start(mas))
+ if (mas_is_start(mas)) {
goto retry;
-
- if (mas_is_ptr(mas)) {
+ } else if (mas_is_none(mas)) {
+ mas->index = 0;
+ mas->last = ULONG_MAX;
+ } else if (mas_is_ptr(mas)) {
if (!mas->index) {
mas->last = 0;
- } else {
- mas->index = 1;
- mas->last = ULONG_MAX;
+ return entry;
}
- return entry;
- }
- if (mas_is_none(mas)) {
- mas->index = 0;
+ mas->index = 1;
mas->last = ULONG_MAX;
+ mas->node = MAS_NONE;
+ return NULL;
}
return entry;
--
2.39.2
next prev parent reply other threads:[~2023-05-12 18:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 18:20 [PATCH v3 00/35] Maple tree mas_{next,prev}_range() and cleanup Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 01/35] maple_tree: Fix static analyser cppcheck issue Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 02/35] maple_tree: Clean up mas_parent_enum() and rename to mas_parent_type() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 03/35] maple_tree: Avoid unnecessary ascending Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 04/35] maple_tree: Clean up mas_dfs_postorder() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 05/35] maple_tree: Add format option to mt_dump() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 06/35] maple_tree: Add debug BUG_ON and WARN_ON variants Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 07/35] maple_tree: Convert BUG_ON() to MT_BUG_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 08/35] maple_tree: Change RCU checks to WARN_ON() instead of BUG_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 09/35] maple_tree: Convert debug code to use MT_WARN_ON() and MAS_WARN_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 10/35] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 11/35] maple_tree: Use MAS_BUG_ON() in mas_set_height() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 12/35] maple_tree: Use MAS_BUG_ON() from mas_topiary_range() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 13/35] maple_tree: Use MAS_WR_BUG_ON() in mas_store_prealloc() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 14/35] maple_tree: Use MAS_BUG_ON() prior to calling mas_meta_gap() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 15/35] maple_tree: Return error on mte_pivots() out of range Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 16/35] maple_tree: Make test code work without debug enabled Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 17/35] mm: Update validate_mm() to use vma iterator Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 18/35] mm: Update vma_iter_store() to use MAS_WARN_ON() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 19/35] maple_tree: Add __init and __exit to test module Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 20/35] maple_tree: Remove unnecessary check from mas_destroy() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 21/35] maple_tree: mas_start() reset depth on dead node Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 22/35] mm/mmap: Change do_vmi_align_munmap() for maple tree iterator changes Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 23/35] maple_tree: Try harder to keep active node after mas_next() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 24/35] maple_tree: Try harder to keep active node with mas_prev() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 25/35] maple_tree: Revise limit checks in mas_empty_area{_rev}() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 26/35] maple_tree: Fix testing mas_empty_area() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 27/35] maple_tree: Introduce mas_next_slot() interface Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 28/35] maple_tree: Add mas_next_range() and mas_find_range() interfaces Liam R. Howlett
2023-05-12 23:08 ` Andrew Morton
2023-05-15 20:26 ` Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 29/35] maple_tree: Relocate mas_rewalk() and mas_rewalk_if_dead() Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 30/35] maple_tree: Introduce mas_prev_slot() interface Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 31/35] maple_tree: Add mas_prev_range() and mas_find_range_rev interface Liam R. Howlett
2023-05-12 18:20 ` Liam R. Howlett [this message]
2023-05-12 18:20 ` [PATCH v3 33/35] maple_tree: Update testing code for mas_{next,prev,walk} Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 34/35] mm: Add vma_iter_{next,prev}_range() to vma iterator Liam R. Howlett
2023-05-12 18:20 ` [PATCH v3 35/35] mm: Avoid rewalk in mmap_region Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512182036.359030-33-Liam.Howlett@oracle.com \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox