From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C7CC77B7C for ; Fri, 12 May 2023 17:17:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5586B007E; Fri, 12 May 2023 13:17:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A5AB6B0080; Fri, 12 May 2023 13:17:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76D3B6B0081; Fri, 12 May 2023 13:17:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 63BA26B007E for ; Fri, 12 May 2023 13:17:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 26BB31C8197 for ; Fri, 12 May 2023 17:17:08 +0000 (UTC) X-FDA: 80782258536.14.43D4737 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf11.hostedemail.com (Postfix) with ESMTP id 3C7994001B for ; Fri, 12 May 2023 17:17:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=6TzRO4dh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3kHReZAgKCB0LA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3kHReZAgKCB0LA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683911826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=g/vEoaxxlidjk6ZRnVQ6vBnM5rJLiZ0SFsw4oljX9Bo=; b=Ityz0yAXtor0sp+49Sjo42DdAE2KzoUXDMRseOCGna0gqHPzzoW05/2erHH/9HoLb1O7Nh wqSk36dnRCGNxNDuluFCRVLW030e/JTcg/rmkfBzkAN7Udi/zu4bIs6Q/KajWBXmyg9aTl MXs0yR6qPskMo8aNOVvO+DGVwb5nXL8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=6TzRO4dh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3kHReZAgKCB0LA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3kHReZAgKCB0LA3D77E49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--shakeelb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683911826; a=rsa-sha256; cv=none; b=HgEiRaPiw93RacFsaUJpFGbIwiUVgxWCc8sjRrksPmOc4FTwb4q8EcmncmkqzCgcHACCcU A1YKnk0yPSmzT0oDGfWO7gPqJT97RHIRY+L9nJ4hpfL4VnoR3NjD+QBzRAYy1RZJxZuqSf NDxuHXS+BgkX7fbkWuXMeWOBU8mqSXM= Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-645538f6101so34825085b3a.1 for ; Fri, 12 May 2023 10:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683911825; x=1686503825; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=g/vEoaxxlidjk6ZRnVQ6vBnM5rJLiZ0SFsw4oljX9Bo=; b=6TzRO4dhn5IQ9F9oBlZSna42ZOqtLV1QcfYJqq0S5da4w8udY31eLcwr/E03q3nFoB ODjOKKPktW+57iOsHRQ94HWijxeHVRQsNCKzBtLgwx52ZLMDichW/UVkpYTYMo5c+c0W C37q+PaEllbmgwGvnyQiCScSGXH2VUjfY+x9RPgqiCjw/Q824wEI2tVYxRUTa5OHSyKh EqLwh6+KXRPctS0apgFG1m5k2fJn1Mxh+A9hEQ/vmsThZr9DgY1FQaCJ0OwDCjLGIHFI dzA74UjBQoyNUMFHq06ENAe24xaZNGPz8dMoD+WWJaA7alhFLNTbdqDlZ4lWEuoihrbQ 7G+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683911825; x=1686503825; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g/vEoaxxlidjk6ZRnVQ6vBnM5rJLiZ0SFsw4oljX9Bo=; b=I4r4d48oWC8I79BxCJdJxbTCmSX38IVi+mbdTrn2dqsuknF+S5Tq1Dj50QqMoeVYWU hZsFRLyVF5WdC8NmSD5ewZ++UuQty2jDzN9lER7/iEiItee6KjkHfpYtRr8F8bHCam4p JsTb63B4bXABlrXCUf6nf8rE17rjNPpvDnVAtL/PUC7uESGC6+Xc0tmPP/6zu5k5fpVg UuId4k6fYty8WB+e9HTNlaOA7plbIBuwdIWNxCoAja3+J7hObzQTp8p2yFRP71FiWIww RTiEA/I9tgi9Drj7jyhf4RxKh/9FkefHMa7FBnqP/H7bZKMg2b7yA6dABHTCG+HwOZ8V aP3w== X-Gm-Message-State: AC+VfDysmZlU0lqiEqnAgdVZ7cDby0lBl/6yaN3KSC904QIx+xBjC9Z0 Udo1AtEiFzVp0ApwOqMWviRdI/wFOhNZPw== X-Google-Smtp-Source: ACHHUZ4Io4WMVWZF2N7SrfbUUa6wZY00VH6g2t/BdY1sGdWVyMUKJbLOj2L1LQb+1nfCVSe+9B5xLmBKbM7rcA== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a17:90a:6f81:b0:24b:6d01:584a with SMTP id e1-20020a17090a6f8100b0024b6d01584amr8353401pjk.0.1683911824771; Fri, 12 May 2023 10:17:04 -0700 (PDT) Date: Fri, 12 May 2023 17:17:01 +0000 In-Reply-To: Mime-Version: 1.0 X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230512171702.923725-1-shakeelb@google.com> Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size From: Shakeel Butt To: Cathy Zhang Cc: Shakeel Butt , Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg@google.com" , Jesse Brandeburg , Suresh Srinivas , Tim C Chen , Lizhen You , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: u3cz6cnxrsnokujezqtdwteimt3b3ern X-Rspam-User: X-Rspamd-Queue-Id: 3C7994001B X-Rspamd-Server: rspam07 X-HE-Tag: 1683911825-30341 X-HE-Meta: U2FsdGVkX1/SJj2rS8YTrOM78jBMuqm7tcmp9fdDpYQTOFyWwmBtDQLbC0zRIW8nUeZFTE2+C3s4RW5n3k4qXnlI7DqdCTQiPIN5F0XaasfAIXA1ky8a5Fg7i8dlCXYpRtUF4MTGUN4d/1lFqaoIDq1XZN56/ZmV4V7aqa4LX2rfp+cmSRQMoSbyPa8atxGDI87def3DQOMPTAH+WyenvJ9nzLltvoyEvoTNANq1CuHxd4sl1nhge7zeX+gYYiPUPp9eYPnmGI3xZ27BGSbCG87qNbcuKwQDDZcsmgR3AOUXhkYKxqavafxbnanqKnI5tf5SVlit0z8974ScCZuOrQ2mJzCNN71EW9PWYVqrOFMi+tcbwueilyAvKkagC+jAozSKTT7rR7wxllT4bO1NbnhKk4SKpv15funDTF/9esas2O0DSRFnOON/dTSPrTrL76pyRDmyw3jAGOC5SgrBVscWQbwPJ82FQiCXwakljiEVdUaLiPi10J4V5dFpsYVFNtg3xYnPpgul3nirriwz/oATLdkv+0vmFDesEJduw+EsINmhexMChNlquxj24McwmVtgJ+1jYLqyhokBDoH99oKbs5MDcMe4Lq0ad2cE8OXRwR/Ir3IPzO0+vov8+eULllm1fMPyH543lTrYZz+tYJYGFYeWHIcn9+3OfVTrEYA7KN4yCQl8o4VarslHXpAxssNYGOURJwTq+f5YpnLu7nZcbsf19YIe+hk5i/PZpwkzFuDJlYHb8buAj2xY+XHeibBowartc9zSWMj2UslGsmPvg6BeFuYoIXlt3y1vOpg87Atq6qn0I7jYJkg6U0liMigTze2nm6e2yr2rXH8dWnG36QhNGl5BU/ZelREzwsAQi/uqlA+gi6VqdCFahM0DPy1LvO5iTEJjrPQHlF5bmBYYXVFdO0DF2PqVjGVuyzRue3BQCKSqrWReWC3u5u6GhbCRo++SkuRdJGXskjt bbD2HFp6 8LdDk5WIxO08QFjq5PB/oRAnAG0nM/vX5iBxAJHVBJ6XfiJAULlSa2jAJAd7E0s/nKvL2nv8O0ivZP7CwmGa3iQNjRntjy10tGPrEag0UyhA7dxcfuSoJiuabg69R5YEYgvZ9Eoiz+AL+DhUEut5QOI2iEE8E9wrTqU0QkGROSENC+IY0UhTf7rrY9K7bAQkJd3qRCxvy/7P7lrRX5vfEXG3jNDzD4yRTmmV3+5XoJeIjSYvRFgjjm2gJxUm4OPp+zTreCTezCozVjRnb2gp0hREqXTkcfW96Axu8gQir7mFcZjLyRkSXUXvOkzSV42IjsBq1LjpPMP8pha92C2zebeXjCOIw6SCulLZJY63MrfcU6JhcgT2LvXVZiz3THNpu0oamiHa+vs0mI92bHKjn+i3gJsh/jsVXlFEtt3HGZ0eVLIcrtWOekRHrj/cbNYwUkDGLLFuJph9nCMiXhIL42daRidbnbzo7IWiRJELakTm/Znuk+kWMU3+rEobPtW7cV9Mg1WXcw916iezrPOmmztUDv/6VUi7/BuHfoHPB+O0QDWB9ZtaUwi7cP1xbgC3Hv+oGvfUIGPeKn3U/kc7lDEDCWWWZnOwGaUCroeXJ5a0KXT8Bm51BIEeCiM/WIMldHQbUMG3wWBqrnYN7fKb0AoW2N6m4CiTEUQiWZMLN4gmZ81qXtXukx6zcIJ9UjLW588ww3YLr6iYeFbaHK66AGUmkgFbdM6DByDeZbdTeb3+Q7Bn2sj7ZnZ3jdSl/MjWLVNJEtj982pNbuNuhI3qxWFGLkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 12, 2023 at 05:51:40AM +0000, Zhang, Cathy wrote: > > [...] > > > > Thanks a lot. This tells us that one or both of following scenarios are > > happening: > > > > 1. In the softirq recv path, the kernel is processing packets from multiple > > memcgs. > > > > 2. The process running on the CPU belongs to memcg which is different from > > the memcgs whose packets are being received on that CPU. > > Thanks for sharing the points, Shakeel! Is there any trace records you want to > collect? > Can you please try the following patch and see if there is any improvement? >From 48eb23c8cbb5d6c6086299c8a5ae4b3485c79a8c Mon Sep 17 00:00:00 2001 From: Shakeel Butt Date: Fri, 12 May 2023 17:04:35 +0000 Subject: [PATCH] No batch charge in irq context --- mm/memcontrol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d31fb1e2cb33..f1453a140fc8 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2652,7 +2652,8 @@ void mem_cgroup_handle_over_high(void) static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, unsigned int nr_pages) { - unsigned int batch = max(MEMCG_CHARGE_BATCH, nr_pages); + unsigned int batch = in_task() ? + max(MEMCG_CHARGE_BATCH, nr_pages) : nr_pages; int nr_retries = MAX_RECLAIM_RETRIES; struct mem_cgroup *mem_over_limit; struct page_counter *counter; -- 2.40.1.606.ga4b1b128d6-goog