From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2516BC77B7F for ; Fri, 12 May 2023 08:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9134D6B0074; Fri, 12 May 2023 04:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2846B0075; Fri, 12 May 2023 04:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73DBB6B0078; Fri, 12 May 2023 04:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 650986B0074 for ; Fri, 12 May 2023 04:54:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 302F4AEB6D for ; Fri, 12 May 2023 08:54:55 +0000 (UTC) X-FDA: 80780992950.03.96E85D1 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf14.hostedemail.com (Postfix) with ESMTP id D8971100003 for ; Fri, 12 May 2023 08:54:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ODOJ47oQ; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683881692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UdTCBd30b6ZvIMwIJq55vivU+4YDYpeOkD3ZR3QiuyM=; b=7Y745wbV1S3Qq8RFOB1JzYKMcMnjug4pQLy88Gwb6dmYotBZUcWi35PN9hn7oOUJK/eJmX g3prrKnNDmOWaWVqSG36JBGjeKes2dox5GkYHxXpy2R87OC8PcK86Cpe82YtQwp9/+eiq2 mSn/PEbujtQspBcmnwELvnf+Ff9PXGc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683881692; a=rsa-sha256; cv=none; b=bX94sfdBaBYBAuL2YFysMLlZg1Kv2Xu/BPYUB/9d/wrG9WMLL59KvvL1bG6wQqhOcntRt9 uxzpQ4X2irtGtInoTrAskRslcPTt1En8qzqey2MRK1pfZfVb/9YhLsXkFQViQLmPDHICj/ xQEumGxeFupp1aV1IWK1yex6+OhgJWk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ODOJ47oQ; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683881692; x=1715417692; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZLf5MT4SG1toK2Ewf11jOOLaMp++8Z7s0AFeltCagdg=; b=ODOJ47oQ82omkMlld64qDnn833E7ygdbLGpCIWkBTgXVWwObPyLKIZ1N IHZcYdmymXzZcrMAmyHZZPB2rM+cUO5V5RWt8IvS0IEBRQyzFp8AEWCUT 3Q7yao2ZXRIy8FSaFwAqAS2Lf7wUH8gXsV0oYvu0MfVvN++r28YGj4zzX QO6YJouLTSTQEzYLzpAYqAeoD5HM29Q8Jz4itrXfsQJgaIWoIegMURQNk u1PN9XB+E4t06qKaQ3K/Sl2SQxW234OetKTL+Ta1B2LTFt7VgyrdR84XK HDmKXirKVMUUZ8iVexs/rlrYWKct3eJ6LLjGmGgUmE5m3AzNjSQXpmofh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="353874492" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="353874492" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 01:54:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="700106937" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="700106937" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 12 May 2023 01:54:44 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1pxOXz-0004jE-12; Fri, 12 May 2023 08:54:43 +0000 Date: Fri, 12 May 2023 16:54:24 +0800 From: kernel test robot To: Vincent Whitchurch , Phillip Lougher , Andrew Morton Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Philippe Liard , hch@lst.de, linux-kernel@vger.kernel.org, squashfs-devel@lists.sourceforge.net, kernel@axis.com, Vincent Whitchurch Subject: Re: [PATCH] squashfs: cache partial compressed blocks Message-ID: <202305121650.kWn3uM2f-lkp@intel.com> References: <20230510-squashfs-cache-v1-1-3b6bb0e7d952@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510-squashfs-cache-v1-1-3b6bb0e7d952@axis.com> X-Stat-Signature: ctochhth3r164zfm4uo8efi7n9mx5rwd X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D8971100003 X-Rspam-User: X-HE-Tag: 1683881691-679529 X-HE-Meta: U2FsdGVkX1+852DX9NiQkaj2+YLF+OtAv19pZpTqandW3W9spNWOf40YcaWwDqT6RkcRkU4qABjHrWmyZn1Cb6yfTTh9CVZHdjf1cFbx7s70pBUV1OxcTtLKKS7DjuAI/s1jzYZ/qfPLcnuKzEa/0xVpKDo928XL0ru3Zmm89FaLfSxpoegJPWmV+hxg1DkptcEWe2NLi9+rud2e0XvFao9lzFYx9HJKAbmh6NsMN0XYKxmDlyzZS7yIH8r4ds5HZ2MteJXgd569JKpdzx79nsEG8YDkDJ5Q0jAfnYIN1jQa/UkAGW8r2QkMZxtB2Jhzs6v+BMZn3Yd+LwcmdE5JyJIm4aFmNihIkTz5GG/24N+xsntCUNC/yfHNuSnzfvxoHjzd2jLDpj8+LHawgMEa1ra6ybm+7Ft1hkwjTJ/hFzG8WwUDvdzN7HiQAQ+opN4LV5G9dI6Vri12EdCDTx1bSHILM22odvkfMsafP+u2fmYpb/jN8GkS290N/MBaxrovJefVMwOwlucJu4EAI0Xf74ZLmegTSX3PXwUwz9zE+EeEjwczjzSnAaMkD/23gVbe5CDhk+f9rCrxK+jDKuH5LWJVRxP+cMZGWyekE3j5D/KAOFj6R+x+xbB3XjrYDMJNvMfZnvtQA9LGreGACSpcLlUfGzp17ukaQJFrwSEm07QjHzJWhbmLnWtmdzELGVaBO2nqbfAE/AdWymxB2eC6ysBV2tbH0Xh+9q8AZGrVSe5iOKGdYH9D/DBu79e9FSTUPB5C2RT61EC5iwS1v+W2fF2pbbUsfMYnhX6m3yeTKdfI/UWN5wxMcce4NZRzzxd7/4su34BG63rASTMe0Vl7cQGdp77ycuLiT+0RXQRDv7f8dgfueOcrFwxTiZ5Kx3gko7jnDwIfS/y+w2iu2VwfWQEza1ParqhlOIFZHWjc299ii/jfBnRddeW+kBWxvok5etQUtPpLxC1r8hMz2vz uQHd1JuO SCVCp3oHgsOREjgoxKlgphdANyEIv1jqb0StiiRQml2HtJ07HoX3KY/OvMdHBtqlKb9EvEaRYM/zypGprxIKE6lkQJHv4lZgGa2++mYnwgOMMAwGaDBO2CGT3voF4j/P7Kv9IbJbvSECNaFMYNfp4FWBMaaAp7zSkgpOYPkbj2f/Fbyd7FT0EixcUSUjj4rYLogxemZaecnGdtMBlNpCSTeQoL+D9e7lj0SO26BPoLVIySdjMYEQthZIk6zpRP5YaCDUy96iqL9IJqTgvF/XNaHTAlG8lwLtfKDF5vr96/syYhzsChQGp2HkEmswFyERo95sJqiKWOFDbu2UsXwk77hNPO2NhwCEXp/7Dasmssp0luAZXscPxfUxg0tATy+elIpDrFhuqQ3idVditFMtZxCCkUWPbz64CzNEq4gsN8ZoBhvUqyq8X3Oal+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vincent, kernel test robot noticed the following build warnings: [auto build test WARNING on 457391b0380335d5e9a5babdec90ac53928b23b4] url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Whitchurch/squashfs-cache-partial-compressed-blocks/20230512-143553 base: 457391b0380335d5e9a5babdec90ac53928b23b4 patch link: https://lore.kernel.org/r/20230510-squashfs-cache-v1-1-3b6bb0e7d952%40axis.com patch subject: [PATCH] squashfs: cache partial compressed blocks config: x86_64-randconfig-a014 (https://download.01.org/0day-ci/archive/20230512/202305121650.kWn3uM2f-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/3ca22c93f1faf376ecf133f84d0148497284366a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vincent-Whitchurch/squashfs-cache-partial-compressed-blocks/20230512-143553 git checkout 3ca22c93f1faf376ecf133f84d0148497284366a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/squashfs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305121650.kWn3uM2f-lkp@intel.com/ All warnings (new ones prefixed by >>): >> fs/squashfs/block.c:168:5: warning: no previous prototype for function 'squashfs_bio_read' [-Wmissing-prototypes] int squashfs_bio_read(struct super_block *sb, u64 index, int length, ^ fs/squashfs/block.c:168:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int squashfs_bio_read(struct super_block *sb, u64 index, int length, ^ static 1 warning generated. vim +/squashfs_bio_read +168 fs/squashfs/block.c 167 > 168 int squashfs_bio_read(struct super_block *sb, u64 index, int length, 169 struct bio **biop, int *block_offset) 170 { 171 struct squashfs_sb_info *msblk = sb->s_fs_info; 172 struct inode *cache_inode = msblk->cache_inode; 173 struct address_space *cache_mapping = cache_inode ? cache_inode->i_mapping : NULL; 174 const u64 read_start = round_down(index, msblk->devblksize); 175 const sector_t block = read_start >> msblk->devblksize_log2; 176 const u64 read_end = round_up(index + length, msblk->devblksize); 177 const sector_t block_end = read_end >> msblk->devblksize_log2; 178 int offset = read_start - round_down(index, PAGE_SIZE); 179 int total_len = (block_end - block) << msblk->devblksize_log2; 180 const int page_count = DIV_ROUND_UP(total_len + offset, PAGE_SIZE); 181 int error, i; 182 struct bio *bio; 183 184 bio = bio_kmalloc(page_count, GFP_NOIO); 185 if (!bio) 186 return -ENOMEM; 187 bio_init(bio, sb->s_bdev, bio->bi_inline_vecs, page_count, REQ_OP_READ); 188 bio->bi_iter.bi_sector = block * (msblk->devblksize >> SECTOR_SHIFT); 189 190 for (i = 0; i < page_count; ++i) { 191 unsigned int len = 192 min_t(unsigned int, PAGE_SIZE - offset, total_len); 193 struct page *page = NULL; 194 195 if (cache_mapping) 196 page = find_get_page(cache_mapping, 197 read_start + i * PAGE_SIZE); 198 if (!page) 199 page = alloc_page(GFP_NOIO); 200 201 if (!page) { 202 error = -ENOMEM; 203 goto out_free_bio; 204 } 205 206 if (cache_mapping) { 207 /* 208 * Use the __ version to avoid merging since we need 209 * each page to be separate when we check for and avoid 210 * cached pages. 211 */ 212 __bio_add_page(bio, page, len, offset); 213 } else if (!bio_add_page(bio, page, len, offset)) { 214 error = -EIO; 215 goto out_free_bio; 216 } 217 offset = 0; 218 total_len -= len; 219 } 220 221 if (cache_mapping) 222 error = squashfs_bio_read_cached(bio, cache_mapping, index, 223 length, read_start, read_end, 224 page_count); 225 else 226 error = submit_bio_wait(bio); 227 if (error) 228 goto out_free_bio; 229 230 *biop = bio; 231 *block_offset = index & ((1 << msblk->devblksize_log2) - 1); 232 return 0; 233 234 out_free_bio: 235 bio_free_pages(bio); 236 bio_uninit(bio); 237 kfree(bio); 238 return error; 239 } 240 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests