From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB232C77B75 for ; Fri, 12 May 2023 08:54:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E6946B0071; Fri, 12 May 2023 04:54:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 196B46B0074; Fri, 12 May 2023 04:54:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F226B0075; Fri, 12 May 2023 04:54:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E9FD96B0071 for ; Fri, 12 May 2023 04:54:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B8558140C8A for ; Fri, 12 May 2023 08:54:52 +0000 (UTC) X-FDA: 80780992824.19.03440EE Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf14.hostedemail.com (Postfix) with ESMTP id E6353100009 for ; Fri, 12 May 2023 08:54:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NlvRKmvd; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683881689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gb++VNpt5XklkPK+TgE0ofuvjDBHdAeI0WFIyGynP5g=; b=8PW5D1q7AoaBEOJWO9Aw+gL/0lETvR2u1R9u6yj6zRMeWU1MjE9LonNRsWUFbX8iaWPOjc sOq0ZhWbNSZNwqrnMJq6eMJz1Rij/w6qpfjSBUoAMt1ExUrdekpsD1Vg4GDdU5/Lm/fLkY elW2R2sR98bQTziBhxNHb+ZYtMaxY+s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683881689; a=rsa-sha256; cv=none; b=XvnjzxYfH2+6NBnp/24CFieizSK3ahzwL6vTyqbzMb/iNF6m5PR0Q05NJc06ZDnJk9TC5S QqWVKs29+7hNtO/roDRF1pBTY5+QUYkBBhKVOQmpFAgqdW6YsldgupMM5+oF8FsoJaLgxh M07Swo172s2EU2eFYxFOlYcroiHRKI8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NlvRKmvd; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683881689; x=1715417689; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bpwPWVXhPzXzGldUZ9YGfL84iDla+D57ECet7awb6b4=; b=NlvRKmvdigkQzRZA7X1a9Hg4yIi6ZHyeSdBjgE+NxxmetQ+bqBEfzBq+ 6sos3WQVITMz1mpg9+UIbSoJU90CzxP0jgrZzB0Yleb9jNecoYkvkpbZP ufE2JO9+aFFAnFfkEqjZu16S5GNMWNrYY0MqjoLcnpS3MEBLbMuQcOK5V z09EUJ0+1Md6aPWn6PGX7u956g6+8pbEOAjQtsDJeQn6RKcqdsJPIew/Z iVnDhWywLgkcvdIms0FRjXitIY6CRxoMAna6xqO3jlP7IFWA6Tj8SKBoP gTlZCRzDBYg8WV0yqrrTG1fm9KsKOVcwehQjVYj+7jkd2/0lX5wr5Z1jC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="353874484" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="353874484" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 01:54:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="700106936" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="700106936" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 12 May 2023 01:54:44 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1pxOXz-0004jI-1I; Fri, 12 May 2023 08:54:43 +0000 Date: Fri, 12 May 2023 16:54:23 +0800 From: kernel test robot To: Vincent Whitchurch , Phillip Lougher , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Philippe Liard , hch@lst.de, linux-kernel@vger.kernel.org, squashfs-devel@lists.sourceforge.net, kernel@axis.com, Vincent Whitchurch Subject: Re: [PATCH] squashfs: cache partial compressed blocks Message-ID: <202305121615.T6PJo2hI-lkp@intel.com> References: <20230510-squashfs-cache-v1-1-3b6bb0e7d952@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510-squashfs-cache-v1-1-3b6bb0e7d952@axis.com> X-Stat-Signature: 5hmo9drgax6d1x8teqjm8fc78139bew8 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E6353100009 X-Rspam-User: X-HE-Tag: 1683881688-698433 X-HE-Meta: U2FsdGVkX1/oGQJJleNTzoXZCyi0eT5XrMfzUTJxk/Db3ArDpyiOml0cdANiOpygrj6o5UXJgBQ2ZtBwvb+UZErbGu/bYMcruUg+JHOb8gD/bLyH6HBq+WokUUfCCngwUP+woi8FRrYq9s7fWl5ubJV7sHpudI2sW32rEVv5SrHpsA85RVZ7XmkOGqvDmqQJZ9aSTrwSzASJZYUKwA96kAKXmL5C0TOwwjBdPMEAH/EJuYj69HjfY7yTbVN+awqtwB27LvZshR33kfZn9W2YKPE/01kfVYo6rqo/5OeAmHBMOTnATyasHMcZ42eXyTShTTk/SR8SqGCv5tCQRii+eSGLy1xmrapJ//MZAGoPEFDck00glNO5jpVnvCX84d+Vo5D++X0DA2rHhQ6a+Ra+5uOg46xb6VeSP2USHb8CxBiu4s8Vu9CBUnHTFx7FwAZy9pgSoS9zB2xdezXRFKH1f+lr7jhOkYzgjh1JtN59z6lFGnu0R8TUSuy/S9So+y5Xgh9g0wy4NV/DnKGaSFq9Bp/Uegsd9re9LXOWlJz3DiUUdUpjbmir7xHXvafslTvM576TVe4oIDR4ALu1PG8uN/Hk5MMCkHLEsqRhoTirnApYe24Q65bdQM+yjuIUhXN00uU0wRvi6mJeeVxH2hdtwIRg34oyXrfzvt6YpJRQvK1Pk0wf/YxdVO3kezuokaXb4hfFJdgoFttUjEl/tlDt00Z1OpWELQziDto750ZFPDEL4jm/W27ZGEGWlwMnrgQjTwy6Bc6yopwazjStzJqxW6X3x4x7QChtQ5FMLM7ppVPV2HJpjjPJjOHCiw1+u4BtEskJL/VoCUi0vHdd6AZnAiwqq6VaU57P+mSqBN7XAhq9K1EwFl/0JepZgjKFKZuXZE2ugtsadgF9LWP46bz1LZCP9QO/NMD6QF6h/6nqHUupohVW+JT8whIiOpYeQRryHrhpoEcBhXwZw/keVMX 6q4vwBMY YIjADvkIEEe9akcgPw/MGpz/+waMDUbdUaGoPxJlIePXlIopfA8SN94WkcmjEh9x/z6VNny8eBn4OkCZG4VZQtQ3vCMGEqRRw3Np+kU1xFEBT8GusEzY+iW8hZZ5cszPS64bkl6PSKhzjZ4iK7OGSkl5WA/7bIv+BrDZUqvF2Y/sa83ujIT5sZ5niXAwMY1KrjHyUGD6WHPN//SvabSOLXoSkQmqjEc6dVP2VfnelbyY6uymmq82Rwmbp9gumyuUonHUWD/Fj9+NFNGz/moDM+qVSTBUhsA1kccckCZOOQzWsKaQCUPqTqmq2ARqNOODtO9+vqRYSMcDrvytpcL6Em54VAZp7zAP8CjaJ4n0svVTeEQ3LbP3k+Oo9Nb3AO7zVAuXCaBZl9dA16m9IHgfdp7WD8PJ6RElCTNZDzI9oDJmrl0E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vincent, kernel test robot noticed the following build warnings: [auto build test WARNING on 457391b0380335d5e9a5babdec90ac53928b23b4] url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Whitchurch/squashfs-cache-partial-compressed-blocks/20230512-143553 base: 457391b0380335d5e9a5babdec90ac53928b23b4 patch link: https://lore.kernel.org/r/20230510-squashfs-cache-v1-1-3b6bb0e7d952%40axis.com patch subject: [PATCH] squashfs: cache partial compressed blocks config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230512/202305121615.T6PJo2hI-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/3ca22c93f1faf376ecf133f84d0148497284366a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vincent-Whitchurch/squashfs-cache-partial-compressed-blocks/20230512-143553 git checkout 3ca22c93f1faf376ecf133f84d0148497284366a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305121615.T6PJo2hI-lkp@intel.com/ All warnings (new ones prefixed by >>): >> fs/squashfs/block.c:168:5: warning: no previous prototype for 'squashfs_bio_read' [-Wmissing-prototypes] 168 | int squashfs_bio_read(struct super_block *sb, u64 index, int length, | ^~~~~~~~~~~~~~~~~ vim +/squashfs_bio_read +168 fs/squashfs/block.c 167 > 168 int squashfs_bio_read(struct super_block *sb, u64 index, int length, 169 struct bio **biop, int *block_offset) 170 { 171 struct squashfs_sb_info *msblk = sb->s_fs_info; 172 struct inode *cache_inode = msblk->cache_inode; 173 struct address_space *cache_mapping = cache_inode ? cache_inode->i_mapping : NULL; 174 const u64 read_start = round_down(index, msblk->devblksize); 175 const sector_t block = read_start >> msblk->devblksize_log2; 176 const u64 read_end = round_up(index + length, msblk->devblksize); 177 const sector_t block_end = read_end >> msblk->devblksize_log2; 178 int offset = read_start - round_down(index, PAGE_SIZE); 179 int total_len = (block_end - block) << msblk->devblksize_log2; 180 const int page_count = DIV_ROUND_UP(total_len + offset, PAGE_SIZE); 181 int error, i; 182 struct bio *bio; 183 184 bio = bio_kmalloc(page_count, GFP_NOIO); 185 if (!bio) 186 return -ENOMEM; 187 bio_init(bio, sb->s_bdev, bio->bi_inline_vecs, page_count, REQ_OP_READ); 188 bio->bi_iter.bi_sector = block * (msblk->devblksize >> SECTOR_SHIFT); 189 190 for (i = 0; i < page_count; ++i) { 191 unsigned int len = 192 min_t(unsigned int, PAGE_SIZE - offset, total_len); 193 struct page *page = NULL; 194 195 if (cache_mapping) 196 page = find_get_page(cache_mapping, 197 read_start + i * PAGE_SIZE); 198 if (!page) 199 page = alloc_page(GFP_NOIO); 200 201 if (!page) { 202 error = -ENOMEM; 203 goto out_free_bio; 204 } 205 206 if (cache_mapping) { 207 /* 208 * Use the __ version to avoid merging since we need 209 * each page to be separate when we check for and avoid 210 * cached pages. 211 */ 212 __bio_add_page(bio, page, len, offset); 213 } else if (!bio_add_page(bio, page, len, offset)) { 214 error = -EIO; 215 goto out_free_bio; 216 } 217 offset = 0; 218 total_len -= len; 219 } 220 221 if (cache_mapping) 222 error = squashfs_bio_read_cached(bio, cache_mapping, index, 223 length, read_start, read_end, 224 page_count); 225 else 226 error = submit_bio_wait(bio); 227 if (error) 228 goto out_free_bio; 229 230 *biop = bio; 231 *block_offset = index & ((1 << msblk->devblksize_log2) - 1); 232 return 0; 233 234 out_free_bio: 235 bio_free_pages(bio); 236 bio_uninit(bio); 237 kfree(bio); 238 return error; 239 } 240 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests