From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE4EC77B75 for ; Fri, 12 May 2023 23:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 625386B0071; Fri, 12 May 2023 19:09:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D5036B0072; Fri, 12 May 2023 19:09:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C3556B0074; Fri, 12 May 2023 19:09:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2E83C6B0071 for ; Fri, 12 May 2023 19:09:02 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E0C1A141043 for ; Fri, 12 May 2023 23:09:01 +0000 (UTC) X-FDA: 80783145282.26.F9C131A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 22590140003 for ; Fri, 12 May 2023 23:08:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=c0MRyYLX; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683932940; a=rsa-sha256; cv=none; b=bFDAwi4XlrRoiMsM5m9LRUcunb5ySOde7hYdcjQ3MoPvye0W0N+3Ww8WOkU1MlLdilk8pE /x1TcrzUmvT5TdiH9sk+0LLmBZhZ8wHRiE3DS4yjR6zuHgqrBpaV25P7ApBZo5SlR7U/2B AqbFJkVp1wc+yHih/htwatGw9t1K0xE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=c0MRyYLX; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683932940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pp8jBp+PsN/KMldJE1rQSHhwMY1J2qwORnODvcuEea0=; b=oOoKZacOr/7LkZK147tVc3H2j2E975ivn6Y4Aw7c/mPA1VrImDOt0vNZ/9oGbl5ImSvFtv W2D2nI8FAW6tHljiNyFDTmDLbbfWUeJCiKXHTsuxilHitx64NPURtVxp6eGAuygLg+Ta/S gWNhWpcK2teG94sdsAeW0DZIEYKGebk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07B9863B93; Fri, 12 May 2023 23:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49237C433EF; Fri, 12 May 2023 23:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683932938; bh=Mk0cOSfhCixEuDzvt2XiRg0i4N/m7HIfr5wXU41qV0E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c0MRyYLX6acmKF76NQOtyZWZ9eRLBl4A06U2rk+oVL2P9zyDaObrSP7IdDzbnbF0+ iDssMPwLUZTXENtU80yA+bqatKc+THPd/I/uQv0Kpr7wn81R8cxMFIucaB7RCbqq7f 5Q2a4Y0kTItOMXArku6gJoTnGpKBrIgcWIamEAbQ= Date: Fri, 12 May 2023 16:08:57 -0700 From: Andrew Morton To: "Liam R. Howlett" Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 28/35] maple_tree: Add mas_next_range() and mas_find_range() interfaces Message-Id: <20230512160857.820fc7a14256c1031c586113@linux-foundation.org> In-Reply-To: <20230512182036.359030-29-Liam.Howlett@oracle.com> References: <20230512182036.359030-1-Liam.Howlett@oracle.com> <20230512182036.359030-29-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: jzrdtuu8apj85iaoow8uqfb4mgnf3ym6 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 22590140003 X-HE-Tag: 1683932939-444785 X-HE-Meta: U2FsdGVkX199XtotaY0XCkiNClEiUn/GrDBhNQQOxjk/bGVd2kJk+YF3E3vDnEu/YE+XZrS6F63nMzP4TlYRqG3dZciJ6pCujtd7+ZTjmwtk8HP7XEAmvY/aFJYuoH1rkzNWAL19VxSpY68HrolNpdJKAS/ff0CaDmf1YkN9vJQhk1JA58Fgiw4jcIazHlu3wN8Nul9Cvhr/MPKcjPWM3+h3UzGVtdFv0zh3FaGnK2FpRx1ivEYk337KlqL2tr/8q0MfAFTs3oe4rsCahP/hOJ96BWfQagaBG31EO2+2wd3hgVTogO7Qy0poW53jDZ9WmuFG5RcKEEgpxoHrrVL++vAyhn6UF+69azmCXuo8h3SoziZpLp7inErWh2yNwf2ffrQkDbxi62Jo3mScSkCsTzgrajXNqVjmb5Qm/qWGlyn3OeHKbmuC1//uAbXLtEW0RmqnAvlLZRIUsqpfTsX9TsCOu4EIs9pBR/GRyttlE7uDkQvYaQwXzItUtAkspJh0ahrUvAcFWnrM6rO30jr6CzWfdItIwslJzTcvG82jZATU8Q04FMSh2U5dwLbMWW6fTzycDp0cClSa+sy85QHW3VjIcbUpYMDCFd+ADqMFjMZDiOojOhuxGdlMU6Bw73EAR5gB0yi6Phmb3Y9tXXPvvGnDDobenZ6BLL/j6vFUo7HUZu05iVcVIxV+trCLCEiZo2uHJ+5pyl0L4w5oW4wVz5p/drRz3A9TRqWH9fahvMG7HmmHSpPa+aCY8jVoryR72Jdo/dhpYCZTH8iYhlr/ZFi3ume0+KSE5RVWe7PWNDP3VK8R+HAJAB9wPglz4wYt1MU6jTbKLrI9uiEh1zuVB5vWHwzpiLTqxZIiFydZo4u9e+V7p50f6vw3l/dTCORz/12jzvlAuP0nrTqgd3xtQrJt6frlUwEfopNowKvZTowlx892Sb3Y+jj5zYjla3ThAtVCM/DQDjOqyupVi3e XlH/fcM1 salr0q0bx525cXYo52qH+CdX0P5u78rAzsAgnycd9re+dW+REbs3SzFdVTPHdsJbH2U0G2xgETqchq5k5ckXg78cM11j4gqQ7gHAij09YbBhf46enDVJXGB0tT1JxLsrli4sU/q24pgaVY3jE/mVrsIwymKmSGqx1ogfTlbXgKKpWEN3j1KNO9WJ9WOdZsttxH/7P45hgUMJQV32y2DY5B1/uP+X1tUg0S9y5aPP7lGkkaqLOTlylajMo92oXZIe2cg8ikS8FxWQqD8irCdN7ZMc/8Sq8053oTmwa4KLa+nDmxtI7rsVCUaiGNXviJnp6kF0bw07QKsxq3f04vZ/F7+CWT7m8oAMBOkMhczkcftOIQpGOlqmA8ATOBUh7MQGlsmBI+wwUwYFu7HY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 12 May 2023 14:20:29 -0400 "Liam R. Howlett" wrote: > Some users of the maple tree may want to move to the next range in the > tree, even if it stores a NULL. This family of function provides that > functionality by advancing one slot at a time and returning the result, > while mas_contiguous() will iterate over the range and stop on > encountering the first NULL. > > ... > > +/** > + * mas_contiguous() - Iterate over a contiguous range of the maple tree. > + * @__mas: Maple Tree operation state (maple_state) > + * @__entry: Entry retrieved from the tree > + * @__max: maximum index to retrieve from the tree > + * > + * When returned, mas->index and mas->last will hold the entire range of the > + * entry. The loop will terminate on the first NULL encountered. > + * > + * Note: may return the zero entry. > + */ > +#define mas_contiguous(__mas, __entry, __max) \ > + while (((__entry) = mas_find_range((__mas), (__max))) != NULL) > I can's say I'm a fan of this. The name doesn't imply that this is a looping construct. I can't say much more because mas_contiguous() has no users..