From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF428C7EE2A for ; Fri, 12 May 2023 03:52:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47B2D6B0074; Thu, 11 May 2023 23:52:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42B876B0075; Thu, 11 May 2023 23:52:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27F166B0078; Thu, 11 May 2023 23:52:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19F9E6B0074 for ; Thu, 11 May 2023 23:52:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DF04F1C776E for ; Fri, 12 May 2023 03:52:43 +0000 (UTC) X-FDA: 80780231406.21.333D289 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf09.hostedemail.com (Postfix) with ESMTP id 8EF3A140004 for ; Fri, 12 May 2023 03:52:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nVa4p4vw; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683863560; a=rsa-sha256; cv=none; b=lsy/dehwyCOroJ4CPNQBuzGSY3cmGoL+6NXtAhhJJAGkTBZZCAqtGgW5NPkpbrKnawKHQ9 JCkS3a59XTJnXAwjz5kI56n8sMjEcmv7loYceB/JVaqYr/sFEniOmk1ihvp8nwKi45Jf/y a1Sdu1EpT8b/MnW4Ww9omsXL8sJCcHA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nVa4p4vw; spf=pass (imf09.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683863560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2FH9uVjw0YT21VM29UQPh/jIJwniaZFnNQDG2H+A5GA=; b=8EIdfBfckHAi/mMRPiUDiduv9kYCxUbvhxZ4U5qwlObFMuKTKNHdtwDXeTKlOGNMXMeMQG e++W+5YFqH5Ia6KcqHxvMqXguWRmZU5qLWlu1BovFfV8gdZzi1kK+fbxLWtBM/24FBpekP mOqTLbH8VR2WwLYEb7PvwE0y4bordhU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683863560; x=1715399560; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=J/jdt5J/MbXbSHrSga9SWJu2XrGCkbNisrV5j1w7pfo=; b=nVa4p4vwlGRLq+jxdc/tyfzejadmoOhZ3MW/FiRy5n5iIuAk7cYpZ/sZ oNxTO6z+nWssygejDZXDi2+jvhjr9sy8jKHAmj8yZb3HAI7XQnOMf7it3 x3PGgWrFK435JUIyDec/fywW4WeHE/FI0owQ+e/5zafGsFLap0ebB002K BUsK2GJNyDLwdGFR76JDXQDWQ9OjQlZnAsrvX4AD0BV8r8DOmAUoU4cf/ Qqx7+NuIYeEWiCyecSDV6do2ON1/HrQbRPsALBWGVwznlTrWOsaVvQiBi YGNNc1m2moSyO4DBPpkJVz6zDQrwrDeVnZIJpaYw1wEcmkapGMuHVRu/Z w==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="348190516" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="348190516" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 20:52:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="1029898974" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="1029898974" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 11 May 2023 20:52:35 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1pxJpa-0004T6-20; Fri, 12 May 2023 03:52:34 +0000 Date: Fri, 12 May 2023 11:52:21 +0800 From: kernel test robot To: Peter Xu , Linus Torvalds Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, LKML , Andrew Lutomirski , Johannes Weiner , "Matthew Wilcox (Oracle)" , Josef Bacik , Andrew Morton , Linux Memory Management List , linux-fsdevel@vger.kernel.org, Dan Carpenter , syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com, Christoph Hellwig Subject: Re: [PATCH 1/3] mm: handle_mm_fault_one() Message-ID: <202305121127.9uKHOw3S-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: gtw63fqkem763bd794797rny8aufqmh6 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8EF3A140004 X-HE-Tag: 1683863560-361248 X-HE-Meta: U2FsdGVkX194V/kEDOVp8+6gnT4VWFTEtsk/XKRAPc5ZjyHnXp+Iq1cDLWCFfkW7TrB76A6+jGTuQ0xOS5+83XgZef0bKcUw9FVAHpn5gQhPMg7ibWWeEroP3sUXlQT8HnAjFBwQ/KIsVPoCAfZqfcd7k4zXKuVIiJSFbU5BhglkMLbTP/mRdDTLoLcHJMKH6pbM5uZSfaJVUxSFgTxmKkk+g0PHkxvBOjh4Mvl1AOpa5AGQg/IV08gUfabCgm37Y8BxZk4QH2oB2By+uYYR0Ikyv3moozIP9fmwDX3r7uJzADoq2KE49gskBd51s71KmUSvUTfq+YZVMNF2R1z8VfFhKEwkfF6HSEXtxBf8Oyv1ZmCfsBvcXdrQvOTYsv+PbJ6nHQIvTdUhEDsVJaMnN4AC3g3Kw4d6qgNlSVyje545k0FBpS2fZTHc13cynKyZyosBx7heOxHiqFR8AY6+R4FIuTVWABgfNfH3mGnCY6Lo/lEVyEv3VJHJQKp1ytLmSbhklTHAfpByre+/chinpxF2VNPY/dADeB242xyBFvtTs21SyNrcIEx39stWnfMy4h8+UmYFYW961U3HLeBnWakC6jj3X9rAUkaBSxsSXHUKtRKEj2X5xqiqYsU5LIzorwqsWTRTWzb9vBCjea+LCsMWGjE0JdjYR3E6S6zAAe9zTWqV3/+pf4hZiZ1chN1XKI4fGH5C8Cv+TNzLpyX9fBhQ7R4ap9e9N8XcVK/PZBSnIbGsRIa6q8feO+RwdLeUyeuEhpp60nlESN43d3PCVilRx3f/EE52UMz6t1VDjZ2I4ZO1ZtDgbzC0iJgkrV2kewtGHlhh9kWPtZndGB2Z7gvCwfEwT9IGb7WJjnOWGkXjjE2+RfxVm+2XHoE8TnpQNmC13QCPvAILxSkbx3mvIaSqNK0pvzfW5FqDpbDoI0sn/ekYfgr0ESeuJ0rVvy8Uccb2gSC4LWnm9U5ITON q12QCQun SvihKzXwVMubbTQ+mh7VeKXg+RkJRstLnV+gLuyJ1R5MOv8NFStwUZsWn3UirdZfZ4naXkhmbj/R1rHKiRY+7Bu3gurS6y4Ffma9jl+UcTW/fKWjUmW1lgORWAbT3ZnlTFVD7dMBsHfl7/6Dhh9fHu/mX3uszgjd89Sm1A4XLhY0HcNYwPCDZ4sjKz9VvsZne6nNQQqCsBuE5RxKJVnd0vEov4RapsSb8YeisU9d9lSS9GtGXNkiSEDMuaZe0lQBDat1PxrDljWZ54KFbuCiEYoUkUyOLb5v4d5aP0/3m4xzmXySGQjkX/UChNxfk9jTS4mdCZipeisYlmxKGbXwKBiatEZqoh5mTiaBugPIjPBaQIafaxyrnBngsIgKh+bg0WBhRH+6dqUI/Er+UffhhQNIWQ60C4btJyF+HyPirp2Dddwq8qsAH3piJhkks+OBB7dZuz94ltR9TEw/VCbH97afSkQ+0iMtuUNJgedUzlOVKcgpMRVA9X+n5xRhJhMRhN2eD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-handle_mm_fault_one/20230512-081554 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/ZF2E6i4pqJr7m436%40x1n patch subject: [PATCH 1/3] mm: handle_mm_fault_one() config: x86_64-randconfig-a001 (https://download.01.org/0day-ci/archive/20230512/202305121127.9uKHOw3S-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0a03a4870c8a62e3ba52a0f9b50b307f509acb2b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Peter-Xu/mm-handle_mm_fault_one/20230512-081554 git checkout 0a03a4870c8a62e3ba52a0f9b50b307f509acb2b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 prepare If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305121127.9uKHOw3S-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from arch/x86/kernel/asm-offsets.c:14: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:20: >> include/linux/mm.h:2371:6: error: use of undeclared identifier 'fault' if (fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED)) ^ >> include/linux/mm.h:2396:20: error: use of undeclared identifier 'mm' mmap_read_unlock(mm); ^ 2 errors generated. make[2]: *** [scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target 'prepare' not remade because of errors. make[1]: *** [Makefile:1287: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:226: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/fault +2371 include/linux/mm.h 2362 2363 static inline bool 2364 mm_should_release_mmap(unsigned long flags, vm_fault_t retval) 2365 { 2366 /* The caller explicitly requested to keep the mmap read lock */ 2367 if (flags & FAULT_FLAG_RETRY_NOWAIT) 2368 return false; 2369 2370 /* If the mmap read lock is already released, we're all good */ > 2371 if (fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED)) 2372 return false; 2373 2374 /* Otherwise always release it */ 2375 return true; 2376 } 2377 2378 /* 2379 * This is mostly handle_mm_fault(), but it also take care of releasing 2380 * mmap or vma read lock as long as possible (e.g. when !RETRY_NOWAIT). 2381 * 2382 * Normally it's the case when we got a hardware page fault, where we want 2383 * to release the lock right after the page fault. And it's not for case 2384 * like GUP where it can fault a range of pages continuously with mmap lock 2385 * being held during the process. 2386 */ 2387 static inline vm_fault_t 2388 handle_mm_fault_one(struct vm_area_struct *vma, unsigned long address, 2389 unsigned int flags, struct pt_regs *regs) 2390 { 2391 vm_fault_t retval = handle_mm_fault(vma, address, flags, regs); 2392 2393 if (flags & FAULT_FLAG_VMA_LOCK) 2394 vma_end_read(vma); 2395 else if (mm_should_release_mmap(flags, retval)) > 2396 mmap_read_unlock(mm); 2397 2398 return retval; 2399 } 2400 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests