From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9632FC77B7C for ; Fri, 12 May 2023 03:29:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFA186B0071; Thu, 11 May 2023 23:29:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAA926B0074; Thu, 11 May 2023 23:29:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C726F6B0075; Thu, 11 May 2023 23:29:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B4BEE6B0071 for ; Thu, 11 May 2023 23:29:43 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84B8BC0EA4 for ; Fri, 12 May 2023 03:29:43 +0000 (UTC) X-FDA: 80780173446.12.0334CF5 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf18.hostedemail.com (Postfix) with ESMTP id 2D92F1C0003 for ; Fri, 12 May 2023 03:29:39 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ik5QT32i; spf=pass (imf18.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683862180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QYLfLzW5CTwY7cd/T3XCV9I+rsz0dV4rGC2IrETPLzY=; b=lRdAzN5wmI5Y6y8H2iULURbvId+jWsPHVClIEMgSySHZyTb67ViBv0EgA5r225Cn15C7rD r5Y9mcbioCFL7G1N0TcLfPbc6pRzg0wKlUKqkmCgiWHeMkP16DpdB/4pViGbCYvT2WfHKa X0d6UCCgaXBiXZbPfaciI0da67whCqc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683862180; a=rsa-sha256; cv=none; b=PoWhcikPRj2ut2ugQ+QW3vH3CyoTOJb+BDcIQC7iS2rGjscWOI0lq7cRfa2BvZLbL6xwZ+ byfQzBhF3ESvMMwtp/tSl3Rrx9YyIN24n/qN4RnB9hcPS2UyXW2ZTfIq5HNgd4zNVfzhw4 WPV8GXU6/74EtjZQef1SKDeogL6xEzM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ik5QT32i; spf=pass (imf18.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683862180; x=1715398180; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lBlSQ3BMuIsBMzqP5MXr7LJILFqu/kbdes1s9Q9K/0U=; b=Ik5QT32it1GLmAbCDCl1iR0RiyopGUbjpm1vQ0OL0mITPq6caZOa4osG TBvdbqscqn/3XKffAnPa7IFDmIJikQmGecl6Zj1r/eyUUqN1caMH8wNz3 4cj2MJbEyIv93KfmRteMrWIB/kOyu5G/QGjurPGTzEIO9TW2q5XkQfB2J IlUIgQq+Cte33WvgG5c570+g+ZfkM8GA9tGAdLH3LVUjNOHlC+vYZWQlR S2kkFQnplidUYH4wEYJT3ySwR2IrTf7OtbEeJXPsFXgHIJlM6U18geyWu guP8imUtmj+1JNbLObaDIDCkBbMLkFoE4sKktAyoDhyCibiP/jC6YgKhi w==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="335209088" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="335209088" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 20:29:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="844244719" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="844244719" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 11 May 2023 20:29:34 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1pxJTK-0004SC-0g; Fri, 12 May 2023 03:29:34 +0000 Date: Fri, 12 May 2023 11:28:57 +0800 From: kernel test robot To: Peter Xu , Linus Torvalds Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, LKML , Andrew Lutomirski , Johannes Weiner , "Matthew Wilcox (Oracle)" , Josef Bacik , Andrew Morton , Linux Memory Management List , linux-fsdevel@vger.kernel.org, Dan Carpenter , syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com, Christoph Hellwig Subject: Re: [PATCH 1/3] mm: handle_mm_fault_one() Message-ID: <202305121114.JAbwVHjS-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2D92F1C0003 X-Stat-Signature: 94j9ghc4f16qki4bnzbjug9hx7pghp54 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1683862179-457334 X-HE-Meta: U2FsdGVkX1/icEUG9OEY19YmtFCB++6HItqZRAbFWPdnyT8Xl/EJguSi5pmJ2j536HuQkSaWTvyRfrI2KrRG8fZvnfojQ9Appjon0INvAzMq8jf5vuTIl53ZHyOJRY4BSWMSFBBVhwXmGhr/+tFhj77wRqqqbFIMF3TFxh8o9CaGIeKK5QlGozM4vg4c/pn3PvmppIH6mdbPHA5LdoHz7/CwUeXiIxu0vTdlAyCCtv83vSPoKhV1fiJ3sP7RadZrgqV17/InfnHjtwuTgio4xvCXS0J+so9XTjaKbpeFuYnT7JSa3n6RbgYBMQiZzjKGcfVn46Am/1UhyG4cTESH5Y5cWreUmABsb3LPyhXfXXrm9qqD7zaY2JbZ+3RUrn9mKNU2DAptnIaBK+P/Yi0egsEABpB2+EnD9niBxrXHlXbkvB3nR/jKZ/kWeCnGS+Hn2oORqTZJ9FRICTezPzyaY2hT4QVBHy588yvokjFwvmYajp0yoDavJXZna4GLaJyHzU8VZFa3ktlPr1kTpj37dp5b1ryNTIbLPdfKnIL0Vteya+w8fbywKrFukZEdUD1fLgiIi6J1MRuxkJFxJxWaeJo1YPrLAEs6Xq3B3piGTIXUGlpMiAnI2wUw5fWGaI3q2D3FP+s32fcdELyHoUoCkrczxU87zdmUvz9IKf8aF3Sny7Yk/CNHBmGkjtgcVQD42ifnBS40R4RoB0peLJSTmaGFjhW3w5ZzBMHb2CnlKFxnkEkwTQAAzp1lnqGuHgVCs44GVdQEmnh6pZOkwdbG6ghy+ehtTcpeV77qlyJMIwp4PpzbCLeX4zyuwQ9yPjW3XY4GX2GtbLtrbvTrRdachqNe8clnIyu75KQvAFvhouAKHR0bWrVp31t5ONeravsJ/opl+/NuKOpyBIEYHNSJsKX24U+SxNo+7f9nc/ICmPOuI+Joou6EoyGO1JXcARxcrWUlzFwmZP2199xTMPV 8PU/LWAs tTMdObtkur0B3rKbba/DuTJOyvViDAck8l+a13ATe19flnLvbRehRrpZwaG7YAPCbefszoEb7MZPevjuwW7jgiq9YuGYEb7VtLMjfNJ5EOdvLtffVbsC8sl2WMXWcbAD3lWqAXSit+6zEd97zdR18iCdvYU381GD5hRrdiLPT+NyB9qHDUeWpF61rDSxIBlkIpcYToV/b/SF2oX1n/8fZlCbizvSKiBfMHNbgSVGXPaalFracCXzsR6nGM6gkxu9qd39uI1zSVkUdDU8oFiKtgavwa8cs15VGPJsd1idAibkdxqJT/TBY7Ic4apw26o5s/oxW+Eu9+b2kXc5lusGm3TEDFNqdDz/QaqCV5VFVsxqS7opw81f+ClLpHU+jI6J2UdzKtgqtqZVqij8TamG3k25iqQoE61cuhN2nJ3CU6ZhWOUVuorVQ0G9+Wl+qmS7rca/6WAd4PTtZIJcaJ0JNOjyNYS7/2F1Wfoq8pay7Xa4fHXIa7rHrFHLNSyH/67N7hSjuH79rFSlHnzA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-handle_mm_fault_one/20230512-081554 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/ZF2E6i4pqJr7m436%40x1n patch subject: [PATCH 1/3] mm: handle_mm_fault_one() config: x86_64-randconfig-a014 (https://download.01.org/0day-ci/archive/20230512/202305121114.JAbwVHjS-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0a03a4870c8a62e3ba52a0f9b50b307f509acb2b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Peter-Xu/mm-handle_mm_fault_one/20230512-081554 git checkout 0a03a4870c8a62e3ba52a0f9b50b307f509acb2b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 prepare If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305121114.JAbwVHjS-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from arch/x86/kernel/asm-offsets.c:14: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:20: >> include/linux/mm.h:2371:6: error: use of undeclared identifier 'fault' if (fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED)) ^ >> include/linux/mm.h:2396:20: error: use of undeclared identifier 'mm' mmap_read_unlock(mm); ^ 2 errors generated. make[2]: *** [scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target 'prepare' not remade because of errors. make[1]: *** [Makefile:1287: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:226: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/fault +2371 include/linux/mm.h 2362 2363 static inline bool 2364 mm_should_release_mmap(unsigned long flags, vm_fault_t retval) 2365 { 2366 /* The caller explicitly requested to keep the mmap read lock */ 2367 if (flags & FAULT_FLAG_RETRY_NOWAIT) 2368 return false; 2369 2370 /* If the mmap read lock is already released, we're all good */ > 2371 if (fault & (VM_FAULT_RETRY | VM_FAULT_COMPLETED)) 2372 return false; 2373 2374 /* Otherwise always release it */ 2375 return true; 2376 } 2377 2378 /* 2379 * This is mostly handle_mm_fault(), but it also take care of releasing 2380 * mmap or vma read lock as long as possible (e.g. when !RETRY_NOWAIT). 2381 * 2382 * Normally it's the case when we got a hardware page fault, where we want 2383 * to release the lock right after the page fault. And it's not for case 2384 * like GUP where it can fault a range of pages continuously with mmap lock 2385 * being held during the process. 2386 */ 2387 static inline vm_fault_t 2388 handle_mm_fault_one(struct vm_area_struct *vma, unsigned long address, 2389 unsigned int flags, struct pt_regs *regs) 2390 { 2391 vm_fault_t retval = handle_mm_fault(vma, address, flags, regs); 2392 2393 if (flags & FAULT_FLAG_VMA_LOCK) 2394 vma_end_read(vma); 2395 else if (mm_should_release_mmap(flags, retval)) > 2396 mmap_read_unlock(mm); 2397 2398 return retval; 2399 } 2400 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests