* [PATCH] mm: memory_hotplug: Fix format string in warnings
@ 2023-05-10 9:07 Rick Wertenbroek
2023-05-10 16:28 ` David Hildenbrand
2023-05-12 5:56 ` Mike Rapoport
0 siblings, 2 replies; 3+ messages in thread
From: Rick Wertenbroek @ 2023-05-10 9:07 UTC (permalink / raw)
To: rick.wertenbroek
Cc: Rick Wertenbroek, David Hildenbrand, Oscar Salvador,
Andrew Morton, linux-mm, linux-kernel
The format string in __add_pages and __remove_pages has a typo
and prints e.g., "Misaligned __add_pages start: 0xfc605 end: #fc609"
instead of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
Fix "#%lx" => "%#lx"
Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
---
mm/memory_hotplug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 8e0fa209d533..9061ac69b1b6 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
}
if (check_pfn_span(pfn, nr_pages)) {
- WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
+ WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
return -EINVAL;
}
@@ -525,7 +525,7 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages,
map_offset = vmem_altmap_offset(altmap);
if (check_pfn_span(pfn, nr_pages)) {
- WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
+ WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
return;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: memory_hotplug: Fix format string in warnings
2023-05-10 9:07 [PATCH] mm: memory_hotplug: Fix format string in warnings Rick Wertenbroek
@ 2023-05-10 16:28 ` David Hildenbrand
2023-05-12 5:56 ` Mike Rapoport
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2023-05-10 16:28 UTC (permalink / raw)
To: Rick Wertenbroek, rick.wertenbroek
Cc: Oscar Salvador, Andrew Morton, linux-mm, linux-kernel
On 10.05.23 11:07, Rick Wertenbroek wrote:
> The format string in __add_pages and __remove_pages has a typo
> and prints e.g., "Misaligned __add_pages start: 0xfc605 end: #fc609"
> instead of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
> Fix "#%lx" => "%#lx"
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
> ---
> mm/memory_hotplug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..9061ac69b1b6 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
> }
>
> if (check_pfn_span(pfn, nr_pages)) {
> - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
> return -EINVAL;
> }
>
> @@ -525,7 +525,7 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages,
> map_offset = vmem_altmap_offset(altmap);
>
> if (check_pfn_span(pfn, nr_pages)) {
> - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
> return;
> }
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: memory_hotplug: Fix format string in warnings
2023-05-10 9:07 [PATCH] mm: memory_hotplug: Fix format string in warnings Rick Wertenbroek
2023-05-10 16:28 ` David Hildenbrand
@ 2023-05-12 5:56 ` Mike Rapoport
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2023-05-12 5:56 UTC (permalink / raw)
To: Rick Wertenbroek
Cc: rick.wertenbroek, David Hildenbrand, Oscar Salvador,
Andrew Morton, linux-mm, linux-kernel
On Wed, May 10, 2023 at 11:07:57AM +0200, Rick Wertenbroek wrote:
> The format string in __add_pages and __remove_pages has a typo
> and prints e.g., "Misaligned __add_pages start: 0xfc605 end: #fc609"
> instead of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
> Fix "#%lx" => "%#lx"
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> mm/memory_hotplug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..9061ac69b1b6 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
> }
>
> if (check_pfn_span(pfn, nr_pages)) {
> - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
> return -EINVAL;
> }
>
> @@ -525,7 +525,7 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages,
> map_offset = vmem_altmap_offset(altmap);
>
> if (check_pfn_span(pfn, nr_pages)) {
> - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
> return;
> }
>
> --
> 2.25.1
>
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-12 5:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 9:07 [PATCH] mm: memory_hotplug: Fix format string in warnings Rick Wertenbroek
2023-05-10 16:28 ` David Hildenbrand
2023-05-12 5:56 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox