From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FD7C77B7C for ; Fri, 12 May 2023 05:56:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 278186B0071; Fri, 12 May 2023 01:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B646B0074; Fri, 12 May 2023 01:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1189B6B0075; Fri, 12 May 2023 01:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F40866B0071 for ; Fri, 12 May 2023 01:56:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CAA3C80376 for ; Fri, 12 May 2023 05:56:06 +0000 (UTC) X-FDA: 80780542332.10.4B5F466 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 1C72E1C000A for ; Fri, 12 May 2023 05:56:04 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AZAvrCPi; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683870965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=785mKCMYbbHwy3Zc9qBnsbvjDnOyAW4pwx82ir1h7Zo=; b=LmRLvj7s0AJqdvYL8ZaDpzt9uNpgdbaHU0NiFuxhyFGIgHalGEjT4Li0vnIRV5pfg98/f2 hjoemfMn+jpEyDecotACbiil+RY9qhigAgfUEGS7Tvn/+z4RIZqjBJuORhxw9/FxLbXhIU dmKdix9z/bbVxtfiJ1WH23oueNC4lck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683870965; a=rsa-sha256; cv=none; b=0H196bdjfTyUCgMYegZEGcaiWr9G1Vhc9QaOWRjB84dtUOIPXSU5D8fWau9ld4HEwOAVm6 D6ys6KO/CEE1uFC5rnrur60PBNizXjPT/579KVYQzY2eQw/1leyromkNsLw/JXw2AuRpy0 lm+xJorlojHUVZ6j+SHXtyt2G1lmT+E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AZAvrCPi; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA75D651C4; Fri, 12 May 2023 05:56:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE6BFC4339B; Fri, 12 May 2023 05:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683870963; bh=zFLjxJcoqygPEa3FU3vOWPjgI0sHhm93uxHO43ygYeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AZAvrCPitPX7thRA60FDRBXcj0NX4oJG3KZPQwQKlwhu1nwYHP3lix77osMKiaXXj h8EsKY3Emo4ahgnHmhqhEj20EZLKcP9qy7HASmMbPYaRHQYb/aru4zixXyKvgKD3QH CRek2j1FBMxtWyDeKBrciauu7wmteeM4or6KDUMr6isLXt1z3N+D/HdYuaWi41ZwkS 031eqbI4S9tdczzdpFfK/mgpuMvjFmIzeSfNUGfVdi21kk+MxSylIQJCZ/iC0TBYZM /xbmKHCR9ftWQlsPX/et5mqus0Qslq9BMvOcs9N97ujuAw2fwSaLFdjr4WC6HgoeMU C59MxF+s9AwzQ== Date: Thu, 11 May 2023 22:56:01 -0700 From: Mike Rapoport To: Rick Wertenbroek Cc: rick.wertenbroek@heig-vd.ch, David Hildenbrand , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memory_hotplug: Fix format string in warnings Message-ID: <20230512055601.GG4135@kernel.org> References: <20230510090758.3537242-1-rick.wertenbroek@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510090758.3537242-1-rick.wertenbroek@gmail.com> X-Rspamd-Queue-Id: 1C72E1C000A X-Stat-Signature: 5wfjhy9rnoxeuggces1ezrcqxhbui479 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1683870964-734865 X-HE-Meta: U2FsdGVkX1/0D2vUf14afeEgOaIPzFn2v+ODwTm6DZbkqsG1BR3KzmLFR8VFnm3qOzeipe1NBhbnzocVEPpkb4gGqBHyPk7wIaFZD+mE5pS8yToW47sGdf/RwhIBnjMF9tPT6OorvfBz26I7wZbX2ojvTzua63zGA6DdC/HY9XSxOWyPuAQKAKU1yUonK+KU1jq7uwxm+5RFya74E2nxu8NNvx8TLhqTlySz8hN05NccBwjvvK/R3y/DWDJ9+42LFC3UFqxVELAYXbS27Q6naqVL8L/bFtqFpTkN/IFgP9pgOiYPdpDGgh1kqJwUXDNMaOAlxZn1zQEq3Sswh1U0gJXqFI4xuc51ImNnqzKrlNnkFgwwM099HVcJBDVVxON7zVVcT+ZuynasfMYcDpTCb/IiGg2I1a9NZguQyiXHskQFywnNL9l7CtiZyezE+g2KrMRaFpHF25dF1yEV+EcFAc8QNVt7TqbFvvHxUVjL+pgucczS2sWg4lrGwjzsf+FM+FjWDP4g2yLMY96vyprsSWFXHQxwqL1kfZoEpWbBSwYCCKG5b9XveQFpwVafuR8Ioysu8SHnNvzP182IsfYYwns1nQxlsh73VKKVVN3+VjwCwEbPqYe4Hr9Wn8GN4O6eOQyE1V+SlRYZlstZRLMigIb8yxj62id/93/lLzoahO80GrzfnkETj4UKAdnJXfJYszHsPLtb/1dUMXoWfjz7lY+vX/FjXBcS8RPNZpt61INnEmr0mnTjhfsJ85B6VykbLPiHFgoojkSC9PrXkkcQ0HZU2R3F1rbK4aB1nOcIo3b8dK2hp2yX+EHJ0NntBLpVa64kkBE/01Gv9EoTdm5kKEPBzHP+n/WQ45ptXvMYBln3di184AJo4Zzw9YcVYovj7XlwUlF7xy/ZXVyz0kX45HN7m8Hn94QG1fm4st/kna9BvzrIAyTHy6aUrfN7Ol7dDsclJNVommrAyUu8J2y Z6v/5mio jwMIspVPkH1nQDcjcRBWe1nHT5fdR0E61oSeMdoVtxEJnzBmZ7pilyqG1H4tgOYIGOnyUxsO83B6c+CSotzXadCbcCxqUVBoPK/VZ/f6YPRR8LukQxtoaswhQ9BdQIpwybvnKQhN5CK3ORRup5c/6o18kYj+ixDKqHF/bdzNwzHVghRiU3aESyzcUx5iEBXsOVLevzD1RJ6ue0lBn0gS9Qpx2PEh5BVrIaP9/Ng3foQLdxmHlvJx53zzDacyD8+nZz+lWy6SuIIIBY2Z2ZgVWjbMLmkuehdoDPT1MQI3qaZPozoXddkJ4Ehla0PpdWum0QWAd+AxYwKxUfoF0qiqRnnqp0Cy03vAG+4/BLtR1KHbH6jylFowM5ICtj2V70T0Y3Y8tApRCdYxUCcWAjNrZhFOZ0s+qx5a1eINVLM6PvhXI3iCkjEt3rg1RcMT9qu+cEw4Hw0VABXTYDEEY9+U+vu+DgHB3lVRmkS2FphDrkr45mEI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 11:07:57AM +0200, Rick Wertenbroek wrote: > The format string in __add_pages and __remove_pages has a typo > and prints e.g., "Misaligned __add_pages start: 0xfc605 end: #fc609" > instead of "Misaligned __add_pages start: 0xfc605 end: 0xfc609" > Fix "#%lx" => "%#lx" > > Signed-off-by: Rick Wertenbroek Reviewed-by: Mike Rapoport (IBM) > --- > mm/memory_hotplug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..9061ac69b1b6 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, > } > > if (check_pfn_span(pfn, nr_pages)) { > - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1); > return -EINVAL; > } > > @@ -525,7 +525,7 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages, > map_offset = vmem_altmap_offset(altmap); > > if (check_pfn_span(pfn, nr_pages)) { > - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1); > return; > } > > -- > 2.25.1 > > -- Sincerely yours, Mike.