From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A72C77B7F for ; Thu, 11 May 2023 21:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B8C6B0071; Thu, 11 May 2023 17:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BBBF6B0074; Thu, 11 May 2023 17:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 583456B0075; Thu, 11 May 2023 17:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 45F3C6B0071 for ; Thu, 11 May 2023 17:18:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0802EA095C for ; Thu, 11 May 2023 21:18:49 +0000 (UTC) X-FDA: 80779238778.09.81FF33A Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf23.hostedemail.com (Postfix) with ESMTP id 32A27140013 for ; Thu, 11 May 2023 21:18:45 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=DRDZQies; spf=pass (imf23.hostedemail.com: domain of 3tFtdZAgKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3tFtdZAgKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683839926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wFv5ci7ov6TO/nbE/lFV0e8LOwHUTHRp5fyIeOp00NI=; b=fYTWWzM5xsXQSEyojdJ7CmSn+JVgKb21zBZaN45idQ6yJUpOFfsMvZCIbgXDUMnTRVZS9/ WCGRPV8LvLimvIOh4S72g9YcwXltxd2JpX1QrTxT+6JJHk4xb3oOuis2tTL4cp+3Dwf0Gq jnSBdCUk4wWw1xXKqiMdEsL1VRcJTYc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683839926; a=rsa-sha256; cv=none; b=u09RTQke+3SpUYylCntNpJd1P/W0FZ1LQRY1sstLhH0uAC2eTgOo85GISyTfelW75wddRc chtJhp2h0SV9HydOBSd4XT9HbVkYPfCmEY54+3086kmThjNf32zFsvNFOVPo030jQUsHi5 a6l5+sLQAfQK/py2yLksDv5Z071iPdI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=DRDZQies; spf=pass (imf23.hostedemail.com: domain of 3tFtdZAgKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3tFtdZAgKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-24e3e52228cso5034828a91.1 for ; Thu, 11 May 2023 14:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683839925; x=1686431925; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wFv5ci7ov6TO/nbE/lFV0e8LOwHUTHRp5fyIeOp00NI=; b=DRDZQiesqpSkMtadBPnXaSLFftLOF2tRVveccLBHVnBfk/IjvUoQA1Vknb0qgMsFbd ul40I6todx42bog/6ILqg96UcxIK20g7/qxVXO8QgOpBrtxjLfYfJ3yb7AbTA509nJ45 vVEgVqAVXuEAW3i7m6KpNZ8E7yUqe9DG3mXiQ3HPPZBITzC95+Q2dKAzmolVjjK8pwj6 a9Cs5cxJHtaEZmMYpeJlaDWPHHQqqVCMIVRPH7naWvhq4An6q1xPYDSHdHn8VQ1eQ3Qq 1xo4xpza4/4wjkUjYkP6SbE4ymEBfN6VGHOcKr1q1VYLux/W7k50O5Jteg6uKDtjsnQ8 c8RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683839925; x=1686431925; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wFv5ci7ov6TO/nbE/lFV0e8LOwHUTHRp5fyIeOp00NI=; b=eOvlrofBXOYzQV4W1JZTjLHiJX4HkKNlKJffovfXrnq1Vbs5WkR/DMq0gI8/ybbyh+ GX00qv39l3Y3HSFlSGzLkOLCM8JqhBVGvhvOUp8wcavrFT1ajB/cOaSNi10wr97eX4ZI 1ZKJW+VjyGmFgnaK1zdMzeOuqzR0pOBzYuvET7sNM8kQg0zAAofS1OBg8hp0vBe1qyrp pPMw10bvs3cTpUbzbIMgYjLU61FwzMVYUeDr+lj2G8ePwADfKULA4wmwIMqwZIpmZodI 44rR2mVLNY1IvEIjf23ANcsNcA9S1NvRSrGkhjqZ6tO67zLKXSrZ+xoQiJAhtRuiruau USEQ== X-Gm-Message-State: AC+VfDz4TjQMczSXG2wADexZvUrYIEFhS5Fh81uScQMhly7v5B/s3GeQ IGdEBC80Oy8HMJmDYmx/28ivhdRuHN/Yag== X-Google-Smtp-Source: ACHHUZ4PXc23wNbZ57OaYuyrz4g91w8e/qPsy9n7oPI4nIMZ/vilFYfLVvhoPfhYvHpXoc9YoMMWey8UgDoT4A== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a17:90a:ff95:b0:24e:2288:6d with SMTP id hf21-20020a17090aff9500b0024e2288006dmr6663468pjb.0.1683839924818; Thu, 11 May 2023 14:18:44 -0700 (PDT) Date: Thu, 11 May 2023 21:18:42 +0000 In-Reply-To: Mime-Version: 1.0 References: Message-ID: <20230511211338.oi4xwoueqmntsuna@google.com> Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size From: Shakeel Butt To: Zhang@google.com, Cathy Cc: Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , Brandeburg@google.com, Jesse , Srinivas@google.com, Suresh , Chen@google.com, Tim C , You@google.com, Lizhen , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 32A27140013 X-Stat-Signature: 769jjtwoxsp8bj4715nx1os4e79phpga X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1683839925-366079 X-HE-Meta: U2FsdGVkX19g1iUW7ehFHmWuReo8Nqiqw7AKII4+MgNtWypfZ2pZlfxmJoxpsL2EdwqqNeMf2t52o64Cb1tNKXHiPuMkwHjFjGJ9IiZ7IY+olPI6ZHWY/xgrTt07mb+gzaEoZX5sOZnBB17PFsAsKmiJXEcOkkNt2dXnE+zTH5ajDMrlwsSN5AOSRzfapfQCd9rE3yvwEqceHM79BCzUUg+WbiTBdv6TVjOeKPFy5ZZ5hspRHtipAwSivO1Uq/lAGJNuWFGqF8mI14sRX6X0oKggF4BU3iZqYaw4zaIUL1Ouz7vIuTU4LZ/bA6wrw3nQQAQ9C+P8/2GPf1ry29g7pgW8vjG79TVpP89wTbhxBNq01rA9sNL+zPoj2Y6cuEEEaYsWgvEL7shKM3Ftx+hyXSDizSXWhEWm5UlxtnkmYfG8IRTqjlGZgYNyRBvHy6uj6SbauQN+WJdY6Y6gbw9hDaYu+RBk1QUjGSFF3BoIr2aN97SIZoEoGh2UTszoGFIun2g5crTTLZ9e6URUVS2/qlV/i/DJtygbD+MTbxxFrxtZYf4Z2sJl3uUxA73Io3Ru5+YBEPJbKL/CcwMUXvvkm9d9zEKT2WI44EpuNtgypH6x8OZdv/8qYngqjis5CS/zMlrpfK03M5+X6f/QAtC7sclanfUyvlBn2V1L0pmsiAQzxykj3GZuxOBwoo7o8KsS2eNhiFbQsDQrAX0Kh4wHUPZsRFBMcEIXY6s0BxqmqgkyENFhVFBUFlNipvbVjNzdmp/n+eE8E7lQciGBv+T3toCtiHAeR88r/k3zs581lTSB31MIk99x4y9oYfmWnuuysOUwVCZywyX1REAdOJbNPKvJJQ30+ofqYCamYnj+A0ZpveOKziaDXz0SbLf9YUrT9HBuNVgD7VX/K/BoNoBxg3XILBFKdub+OV3xGmeJylLd1WwqIWRJyDt0z6SK8tVw8n3OnJHu9B/yKW7BTh4 /cnYdnNq oLt/wMk61b7pWVS74FLdyQk4oqR3GBBcc1HpuV0NwqIquP3M7GMm+zICQXyroluVPDo+9JadBq0e6/8GOgsmjwtlEZ/Zk+JFH5JsPtLEbBKhn5Q6aDh/kkZPlG6mKViqYMNROZZO+5huy8xAW9j6v3q1lCGFRRQ/CfhQONpPq+jBoZpxRM9Xa0mDe4TOzYTJSy2Giqh841jHy36Bcvc4c9/tul7foWpwC7QDAaN87soaGE64Ym9mHWmKHecptF9svrrNpv6F4ljfoQX/oIj5l8cIEywujQdjM/s4pL9SCbePZHvGJ4/aXCwN8ZM+CQZ2iGaMK2BHpF4hieZ23V6Oq36eyIJdtxIkhhL1lNlmmnXHNEBwQcjanEE1CcQYgPF5U/cF1/tf9IMR/dlZn6Mu6VcJIHxZ9n7iM6Zz/jNNfygF0YyInefNqLzbYWwiIc4pML03j5esNQN+5w/fEP5uvYMS/Po0aGVQ0ww8Wyufujm+a4PVqGRh5JJDh/w2JAtX9rnVBCf17mwBdcAsdAxEaJG5VUTg/+PkAzrWDhgwZvEknNA+Ec2edqac/uXotV7B5flwT+dutcrjCwV1gbbVRvDyZR/zptaPSkJKVVRptlToMB7Zgq/LYvbRGx3N9sW8LBiODzMFFAkol6o+EY9DBUjDwA/ZPFn7/XlvhoF2Dfmw63Gki11AUir3f0Arj9N8X1Coe2z5GuRyUMKJf12b9uLcU2uZj9c/asR3r5W1sL0EYz+kO1jaKJUyuI/n7u64vVuczfgFPW0SAdyQ9zjien1TR3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023 at 09:26:46AM +0000, Zhang, Cathy wrote: > [...] > > 8.98% mc-worker [kernel.vmlinux] [k] page_counter_cancel > | > --8.97%--page_counter_cancel > | > --8.97%--page_counter_uncharge > drain_stock > __refill_stock > refill_stock > | > --8.91%--try_charge_memcg > mem_cgroup_charge_skmem I do want to understand for above which specific condition in __refill_stock is causing to drain stock in the charge code path. Can you please re-run and profile your test with following code snippet (or use any other mechanism which can answer the question)? >From f1d91043f21f4b29717c78615b374d79fc021d1f Mon Sep 17 00:00:00 2001 From: Shakeel Butt Date: Thu, 11 May 2023 20:00:19 +0000 Subject: [PATCH] Debug drain on charging. --- mm/memcontrol.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d31fb1e2cb33..4c1c3d90a4a3 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2311,6 +2311,16 @@ static void drain_local_stock(struct work_struct *dummy) obj_cgroup_put(old); } +static noinline void drain_stock_1(struct memcg_stock_pcp *stock) +{ + drain_stock(stock); +} + +static noinline void drain_stock_2(struct memcg_stock_pcp *stock) +{ + drain_stock(stock); +} + /* * Cache charges(val) to local per_cpu area. * This will be consumed by consume_stock() function, later. @@ -2321,14 +2331,14 @@ static void __refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) stock = this_cpu_ptr(&memcg_stock); if (READ_ONCE(stock->cached) != memcg) { /* reset if necessary */ - drain_stock(stock); + drain_stock_1(stock); css_get(&memcg->css); WRITE_ONCE(stock->cached, memcg); } stock->nr_pages += nr_pages; if (stock->nr_pages > MEMCG_CHARGE_BATCH) - drain_stock(stock); + drain_stock_2(stock); } static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) -- 2.40.1.606.ga4b1b128d6-goog