From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A43EC77B7C for ; Wed, 10 May 2023 22:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AC976B0072; Wed, 10 May 2023 18:52:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 335BF6B0074; Wed, 10 May 2023 18:52:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6EE6B0075; Wed, 10 May 2023 18:52:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 052206B0072 for ; Wed, 10 May 2023 18:52:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C2965A04E5 for ; Wed, 10 May 2023 22:52:07 +0000 (UTC) X-FDA: 80775845094.21.DD4E72D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id E1F2340002 for ; Wed, 10 May 2023 22:52:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Erg8wLct; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683759126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3KYw6EP/jsQ2HwAD57HvkcL5uEoSTGGpm3noezkYaPk=; b=lnTo+cJyHI7zHSdjNobddofxB9mZbIZHLCKhjcbKD6EqzSeaa0z/QxLcpTqbOspsqiikXc phwsDPy5RC2nYseyNSWV6U5YALjFgItJDBiYgiSXwwislM7JS+2V1jD4aNXf6gJ8c/RfHb oUzJdAGTVgXqumn8MpwhiY7AvnfiC38= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Erg8wLct; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683759126; a=rsa-sha256; cv=none; b=oWIQ1LfvH24//E7k280GtYYoZUJBgPg9OJC8D6jh6G/p0Y7SES8YYbyjj4e5Cs/3d/vfhm Du5n1Zup0O/+XcKdPyIr/Hc8dSHWlRmcLnviydNj3RjnXcrqWsVTaGWZ98DOue/fcrQxi0 mtv8O/GP3+14hT+B/3pKFm4K73F6QUY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC04064093; Wed, 10 May 2023 22:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75E3DC433D2; Wed, 10 May 2023 22:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683759124; bh=SfC29pkbPFsP7SvqkKQKsejqsVIjIBqmlouYzbhT+ZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Erg8wLctyK2t2eLGbGIDKzcYMYdynzb6YP0fvPYdtvmRCA0HIUkXiKkOf4F86i4On /gAoGwte4tnDWGWIrYUDuYIg+I9Znik+4KZVnp+lMxH3g2x/3Fe3eDa0iD7K811y6r n4pD/uLiIJGwrvwTzme6mcOYZfRdLIABA20NFbMM= Date: Thu, 11 May 2023 07:51:58 +0900 From: Greg Kroah-Hartman To: Ruihan Li Cc: linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pasha Tatashin , David Hildenbrand , Matthew Wilcox , Andrew Morton , Christoph Hellwig Subject: Re: [PATCH 0/4] Fix type confusion in page_table_check Message-ID: <2023051108-lens-unsocial-8425@gregkh> References: <20230510085527.57953-1-lrh2000@pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510085527.57953-1-lrh2000@pku.edu.cn> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E1F2340002 X-Stat-Signature: 4ed5z3e9bb5karpj46pct9k4gfqnft91 X-HE-Tag: 1683759125-908936 X-HE-Meta: U2FsdGVkX1/A3MSFcJHJnEun/C0zJpaylybB5pmSSdwPRbp8vny07V4gn+BaYyh+oBUrqZhRJ+Yr56EeOHH7rwzBY1a/ZF9fMKzxWqZViHAfsYomSfrqZOhXJ/NrXPT/Z0IPwyFESlA1NYMOHdIlrJWhEVBhvgWK5LINX5CSxFViGF/XjNmWanoRzGhvVAJp78YKHiUGkd3GcwkfUruWyoYeSpWgOVntLv0gQ4YfzpcF/zZ7RXZmjqVGOglQi5t2Rr/FtW5FVf8X7uftKmhw3JrNtgiKJuMsyB2RKrunGfbsUdNccvjZ+0cBq3LB+LbNgMdbbE6xbiT86Mkq4knJewUXfG3IdsGS7YQOp1MhJhAdwi2REl1cbLeRZ5jw+I82zzbKcqYnBnrNMD+CBICJ8RI/el6nsLTiZv6MMaCL9jymPQzoJOta6v1XS7wSdC4uqzFOdBx58fVvrSLFdyjiVn8jpJBSMsFYvEvTChrwxlorWqfU0qyVFbxXnGRF/d+MKHaHS3VrFOYWS+NqH2G0ox3uDaO0PIOHBfE0b926UKWwfwEZbP2UGV4zFPAsoiBC9c3qERy306BIQjEhD+dE6skGgqg/+4iGzdmDNT0HzQ3yat6mx3QAE44RgTxn9ACYidmgagsJWOk6qflwUXG+jPpzepRp7ZY5+1cwMuP5T6asez9sXB7AzTmQFlm7yN8UJCuQk7psmSQTJ7B/nBcpEVgS9sB6r2c1ZuESxF5PeNalyKbBxDFJGrQ9YAjJ60SPvGZ3dfSYYYlW9vQPnrrlVPYi0ZitW21RLKVKNp0nU54hO1aFkQ0LS7VCKXfw9wcnXjR/akY/1yDPRBY9dLN+UbN1ybEobP5U6Gx3nhcZ+z3Xq0Y9AHHMvMEnNGFYQKd6Eobar+awrrJU5h+z6Smj1BCYmoUUvLxzG0EzssZ2Fws0FzPC6IkFEo6gFuYufjbXAkWtOTB2wq4of2MRyku 8bvbpett 2Hm9PqQct9FIER76XOn8aaBYvPZkvfDrkYhF34ZLtDE8rG8o/4ZQkRBqMBawlEVSCWnjYCFKy25/dlAkBFWw3IXzY70oF1h8tWATM/uE7Y+v/ukAiCthHefNeFNCK8duxFVUeBXwujwb/ASisCr9oLavHJdFv2tmcsRKnT7TanrMMWTACboKf+3fX2hjp7wdcFZezssgCwLV6odHYvzU1Hk6uBouM98jAeAAsr8H61sd9w2Z5Fx1ZgvbgcFLim7XC5TOxDQSlX5XT3a4GblQJ6fh4YgduYDZjP7u7+EpD7rAIml1QxROmC1SQ3xkVSZ1jzs9Rq85aIgBZrK7h1XogAmm8vzDH+b6pwxL7lGogxS3gDRV5pgILN3FP8UArL35Ogcen9EKoOFtrPr4x8Poc6+selHUn/mUb5VRE3SR7b9ncCXP9YBD0AlQeRrGd/jBG5X0+OKxF3VJqQYGM0k0Jen7uMfHI6Ah3fj9HE96lRV/RV51Swd9QE8+M9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 04:55:23PM +0800, Ruihan Li wrote: > Recently, syzbot reported [1] ("kernel BUG in page_table_check_clear"). > The root cause is that usbdev_mmap calls remap_pfn_range on kmalloc'ed > memory, which leads to type confusion between struct page and slab in > page_table_check. This series of patches fixes the usb side by avoiding > mapping slab pages into userspace, and fixes the mm side by enforcing > that all user-accessible pages are not slab pages. A more detailed > analysis and some discussion of how to fix the problem can also be found > in [1]. > > [1] https://lore.kernel.org/lkml/20230507135844.1231056-1-lrh2000@pku.edu.cn/T/ Can you see if you can implement Christoph's proposed change instead: https://lore.kernel.org/r/ZFuZVDcU81WmqEvJ@infradead.org As it might not actually be as bad as you think to require this type of churn. thanks, greg k-h