From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65278C7EE22 for ; Wed, 10 May 2023 08:55:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F22A06B0072; Wed, 10 May 2023 04:55:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8FC26B007B; Wed, 10 May 2023 04:55:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB3F06B0075; Wed, 10 May 2023 04:55:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CD2A6B0072 for ; Wed, 10 May 2023 04:55:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 373711A0699 for ; Wed, 10 May 2023 08:55:51 +0000 (UTC) X-FDA: 80773737702.19.9FB5C17 Received: from zg8tmtu5ljg5lje1ms4xmtka.icoremail.net (zg8tmtu5ljg5lje1ms4xmtka.icoremail.net [159.89.151.119]) by imf16.hostedemail.com (Postfix) with ESMTP id 104B2180006 for ; Wed, 10 May 2023 08:55:46 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=pku.edu.cn header.s=dkim header.b=ZmFL1Miz; spf=pass (imf16.hostedemail.com: domain of lrh2000@pku.edu.cn designates 159.89.151.119 as permitted sender) smtp.mailfrom=lrh2000@pku.edu.cn; dmarc=pass (policy=none) header.from=pku.edu.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683708949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uc/joagnVnWX0pVL8sA/swhhcGx1a7P3dQTDyW7FP10=; b=2fRxQlsYVTS46WxiECpP6pB07UdVpRBVTCP/2Hljv96h7dL+4clwDJoqyM2+/QAlRbOrk9 VjdI7BKUKvdIccbP9yJnwq28l7qBaeuv5y1T6ZPRXMlHXu1B2KSyGZbzNyxkzDf9JIRBxU YPFfumuFcAEplW4CVZpDfl0HBxOiANc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683708949; a=rsa-sha256; cv=none; b=xOo8PHbDeAXmA1oBkWWkbdjzWtmZqJHbx1QrqKDRrs4Lp6uCNztQqR8WJvrQ9KbTy/oW0z iyKllkrZALP/PgcENyjFQyBe6zisT0IMursvLDnTJzkeXZtMpByqRQe3DBx0RNa4CgHMwx DvNtiXzj3gP0K8GT+N64PLMVJg7RX7A= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=pku.edu.cn header.s=dkim header.b=ZmFL1Miz; spf=pass (imf16.hostedemail.com: domain of lrh2000@pku.edu.cn designates 159.89.151.119 as permitted sender) smtp.mailfrom=lrh2000@pku.edu.cn; dmarc=pass (policy=none) header.from=pku.edu.cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pku.edu.cn; s=dkim; h=Received:From:To:Cc:Subject:Date: Message-Id:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=uc/joagnVnWX0pVL8sA/swhhcGx1a7P3dQ TDyW7FP10=; b=ZmFL1Miz+iwxUAejxmnXZrzMvhWRO2gTDNymFiYKOFmOJx2Phg n86fSt1XcCM1orEYX0LJ8T7Z57qLiHA5O81og7eaOHCblqDcOVLLfy3XPdMK7Mvo aKEwhnHrpWzNksDyzH7/HBiexN+Atn1CCGgm+sIUKlxloB2ZQEE2gI3E8= Received: from localhost.localdomain (unknown [10.7.101.92]) by front01 (Coremail) with SMTP id 5oFpogBnb2cIXFtkW9d5Ag--.63159S4; Wed, 10 May 2023 16:55:42 +0800 (CST) From: Ruihan Li To: linux-mm@kvack.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pasha Tatashin , David Hildenbrand , Matthew Wilcox , Andrew Morton , Christoph Hellwig , Greg Kroah-Hartman , Ruihan Li , stable@vger.kernel.org Subject: [PATCH 2/4] usb: usbfs: Use consistent mmap functions Date: Wed, 10 May 2023 16:55:25 +0800 Message-Id: <20230510085527.57953-3-lrh2000@pku.edu.cn> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230510085527.57953-1-lrh2000@pku.edu.cn> References: <20230510085527.57953-1-lrh2000@pku.edu.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:5oFpogBnb2cIXFtkW9d5Ag--.63159S4 X-Coremail-Antispam: 1UD129KBjvJXoW7Kw45ZF1kZrWfCw4UCr17KFg_yoW8KFWDpF W8K3yj9F40qFySvr1q9an5WFn5G3s5KFyUWrW2v3sxu3W3Jr1SkFWFya4YqF17tr18Xrna qFWqyw13C3W5uFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBF1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AE w4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2 IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW0oVCq3wA2z4x0Y4vEx4A2 jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAac4AC62xK8xCEY4 vEwIxC4wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02 628vn2kIc2xKxwCY02Avz4vE-syl42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxFaVAv8V WkJr1UJwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUQZ23UUUUU= X-CM-SenderInfo: yssqiiarrvmko6sn3hxhgxhubq/1tbiAgEEBVPy770DbwAZsE X-Rspamd-Queue-Id: 104B2180006 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: f1shyhquz8ng99xh8jujzdp4hfodm6sm X-HE-Tag: 1683708946-123915 X-HE-Meta: U2FsdGVkX19vNce3UtauUI8JhGq2lZ88BGy2gle8QkwuF8k5I6+ZuuXjTPR5fA1X9HgqRM6C4gZ7kafBExWvBEepsgEsmzW9QDy3CcJviXVmnjC/IctsAQJHYC2DVDXo5ydAqxiheteeSH0hPD/jgN+owq9hLC9NfiPJK2tAfKjWyTsfFSffbLaRSmhLAMvspX5QdEWh3FAcAsBDynRiU7ypiRVKuriiATyOFgDFud6doi5ufuWX9Vb6+TcqUaIUQ3gtVuwfa9UWjkThtp76RXbp9czdydmEqbf5MkW/abNrflouzvgPUV/I+hY7TrZD+GB1thuSRFbu2xunvO89cuFItjXtEJ9vYzOXsOGRiGqo/jEFSVAH7mCAmbJOPczZeXv6DoejYz9QN9sY9ctCrZgbCG8ceYqzyrZEffoQDF/CFq4SWe7vItUMucbB9gGAl9eftGhMl7sHq4l05XpTlOvl5sgvNHxv6pU/a14yZXfhuPhiRXTF4ZP9Cbb1Xf3e05nKUWeRputc9Q43yfiWNdn1vtLlXkRH4ytJWwXvQ2Apk3bnI9I3j5cv/dm1TdHoP6xfR5VbpLrbeP/Zx/CUeN3slMHr+KwweYU44ysIvcDoJxE8SpPKZotysPrt0d9OggL5jvIf8g8IFFmNKIkVbuE8/Pxw/k5JTA3O6eO0Shn4K40M/i9gQMaUuY72TQKVqla15qckVvf/vNEFoqwUm2N8lzcKezr/A19OGAnkdD1u4yFnhUkUVhIlPfprf//Dr2rFrO6lMbARXs065D9c9PnDKE7XiDTy70S8GXPKRBv+rK3PI4d/u+obS0OTvTNScTGAj3EC/7oPNRqpGNmmNsDQr8xhByOgnv2fe5oF9lNewV/E8ZtXT6VjvE/pTg0egSQ6GD7HD4IzFr/d6NLRU02YEhZIZX6yW5hrEaTK7sAtJSEe3WMMIViZmX4eF+jh9pgDyaGNNLVRTBh7avk DHJEpszF qTrla46bMmIvjrvkcDkGAdxwRGqTCufWDcDk6GewxEsVzFrhAS71UeDOHlTziqvA6FcGiYfaIiEgCxCSMXg1ilCJdmWm2OY7dsetzJoVXYiH/MGu9v3FI6utyxBDXT0NqJgtFG4fhsX6PNiaYWf3OmeNo6boqBWjcSLtcNfn/iHxxR1MfIV7AnRYDyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When hcd->localmem_pool is non-null, it is used to allocate DMA memory. In this case, the dma address will be properly returned (in dma_handle), and dma_mmap_coherent should be used to map this memory into the user space. However, the current implementation uses pfn_remap_range, which is supposed to map normal pages (instead of DMA pages). Instead of repeating the logic in the memory allocation function, this patch introduces a more robust solution. To address the previous issue, this patch checks the type of allocated memory by testing whether dma_handle is properly set. If dma_handle is properly returned, it means some DMA pages are allocated and dma_mmap_coherent should be used to map them. Otherwise, normal pages are allocated and pfn_remap_range should be called. This ensures that the correct mmap functions are used consistently, independently with logic details that determine which type of memory gets allocated. Fixes: a0e710a7def4 ("USB: usbfs: fix mmap dma mismatch") Cc: stable@vger.kernel.org Signed-off-by: Ruihan Li --- drivers/usb/core/devio.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index b4cf9e860..5067030b7 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -235,7 +235,7 @@ static int usbdev_mmap(struct file *file, struct vm_area_struct *vma) size_t size = vma->vm_end - vma->vm_start; void *mem; unsigned long flags; - dma_addr_t dma_handle; + dma_addr_t dma_handle = DMA_MAPPING_ERROR; int ret; ret = usbfs_increase_memory_usage(size + sizeof(struct usb_memory)); @@ -265,7 +265,13 @@ static int usbdev_mmap(struct file *file, struct vm_area_struct *vma) usbm->vma_use_count = 1; INIT_LIST_HEAD(&usbm->memlist); - if (hcd->localmem_pool || !hcd_uses_dma(hcd)) { + /* In DMA-unavailable cases, hcd_buffer_alloc_pages allocates + * normal pages and assigns DMA_MAPPING_ERROR to dma_handle. Check + * whether we are in such cases, and then use remap_pfn_range (or + * dma_mmap_coherent) to map normal (or DMA) pages into the user + * space, respectively. + */ + if (dma_handle == DMA_MAPPING_ERROR) { if (remap_pfn_range(vma, vma->vm_start, virt_to_phys(usbm->mem) >> PAGE_SHIFT, size, vma->vm_page_prot) < 0) { -- 2.40.1