* [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning
@ 2023-05-10 8:47 Rick Wertenbroek
2023-05-10 9:02 ` Rick Wertenbroek
0 siblings, 1 reply; 2+ messages in thread
From: Rick Wertenbroek @ 2023-05-10 8:47 UTC (permalink / raw)
To: rick.wertenbroek
Cc: Rick Wertenbroek, David Hildenbrand, Oscar Salvador,
Andrew Morton, linux-mm, linux-kernel
The format string has a typo and prints e.g.,
"Misaligned __add_pages start: 0xfc605 end: #fc609" instead
of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
Fix "#%lx" => "%#lx"
Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 8e0fa209d533..446abb088b51 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
}
if (check_pfn_span(pfn, nr_pages)) {
- WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
+ WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
return -EINVAL;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning
2023-05-10 8:47 [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning Rick Wertenbroek
@ 2023-05-10 9:02 ` Rick Wertenbroek
0 siblings, 0 replies; 2+ messages in thread
From: Rick Wertenbroek @ 2023-05-10 9:02 UTC (permalink / raw)
To: rick.wertenbroek
Cc: David Hildenbrand, Oscar Salvador, Andrew Morton, linux-mm, linux-kernel
On Wed, May 10, 2023 at 10:47 AM Rick Wertenbroek
<rick.wertenbroek@gmail.com> wrote:
>
> The format string has a typo and prints e.g.,
> "Misaligned __add_pages start: 0xfc605 end: #fc609" instead
> of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
> Fix "#%lx" => "%#lx"
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
The issue appears in the __remove_pages format string as well,
sorry didn't notice that right away. I'll send a new patch.
Rick
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..446abb088b51 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
> }
>
> if (check_pfn_span(pfn, nr_pages)) {
> - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
> return -EINVAL;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-10 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 8:47 [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning Rick Wertenbroek
2023-05-10 9:02 ` Rick Wertenbroek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox