From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E3EC77B7C for ; Tue, 9 May 2023 14:05:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24B0A280015; Tue, 9 May 2023 10:05:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FAA5280012; Tue, 9 May 2023 10:05:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2B9280015; Tue, 9 May 2023 10:05:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F1D37280012 for ; Tue, 9 May 2023 10:05:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 42DC01C6A2A for ; Tue, 9 May 2023 14:05:51 +0000 (UTC) X-FDA: 80770890102.05.19DBE90 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 482FEA037B for ; Tue, 9 May 2023 14:01:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=moSfqhSO; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683640877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vywYn4RmCVLAoap8lx8gWfnn7MwY1TH97r5zz9PtGI=; b=P4EfXffjmHq8WAfie42yn4rv9a531XTvy0zl+rv1KCwekwfMKAQlnjCzYazvkIKg4GBBtV mP+YWlvmk9yjP1TCRxXjbvBoQEP67RAxK6uwU6tnCf0yTbQbBcMacAxFe14K8FNCT4ru2Q ZBAR6+F3xwjTFGDx8lwrqCeunE/OsRg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683640877; a=rsa-sha256; cv=none; b=xZqB9Hg6hIgj01H0HxZi49Cc5qHmJ2lRCGdb8NHiyMteyTP+W3dMyEr2KgablpmdEPkF1R qTNy0HbX8ZwH/3hD7QodGpLpH5e+3MxOO8lu8gIM+DCRigkwI5Ep8I4QWhcGxZ6WoPV6AU VY7XM6tr5nrNYuwDKOhJ/jP6SXjIk1o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=moSfqhSO; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0DCF646B9; Tue, 9 May 2023 14:01:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C9BEC433D2; Tue, 9 May 2023 14:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683640866; bh=mj33fPqfFt4lD4T+X1wHRTl3U886tC9uw2mp+55gJvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=moSfqhSOtlwaW3DesFw9Yd3yQt5Tk+EMUei/VbgLVPhXyhWvIb6o7+02NyLbqmfKK PmAYPR0Nygfx139UU9NT4Bz74V/nJIJZ80C6DpTJB0P4uDezHrtW4VPb3k74griyS1 lZHYnvd9BAiGzXdE5/Lj9MJmlCifUAEpoDg7L+LA= Date: Tue, 9 May 2023 16:01:02 +0200 From: Greg KH To: Christoph Hellwig Cc: Ruihan Li , syzbot+fcf1a817ceb50935ce99@syzkaller.appspotmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pasha.tatashin@soleen.com, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: usbdev_mmap causes type confusion in page_table_check Message-ID: <2023050934-launch-shifty-0bbb@gregkh> References: <000000000000258e5e05fae79fc1@google.com> <20230507135844.1231056-1-lrh2000@pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 482FEA037B X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: c98raposdbad6ifonuk4k1bquf5i78ma X-HE-Tag: 1683640872-356021 X-HE-Meta: U2FsdGVkX18VsYDyg/Dbdp17P4gk9W07oMxHpULqofoTssGRGczMAHbcvOglgx+4XB32WpWQ2gyri6Nl1hPwz4F2O0OqIHRP6mDZDMnXCID6OMuhXBYV026gGNDOsX5fpAX4ti1BY+4WdE2yppi6uqCNYoPHOYhXVGzXQfgGIvOZs3DiauYcgQw3xhi2DkT8iLUHnwwSthzJsoYClqZ9USgjHBoMIyZ3Zg6vK57+PFSvPXcRyktAS1OQQJC2iLBBdTH9bUs9WbwOuvIQNfJsnqRmEp0an9ZZFT69vupBrHR4WAGiZvdBzL6JM5Ut4BNVrX0nU3RjySbiajgF5tV2UinO1tQluz500kAXrulPNZkjFAbCSaXsb87aR6FVx4WMW8s2XKH+ohWK612AS/tIU3qMY9E+Iw0rVY0seOjCv7jK9PLlNJ/Qf+egJevDQ6SLLiPprhH29T4q6k4cdcJKsJez5bloL3STiL6BVrSz/uks8257zp/XD+VLU5ePRcxY25s2pVXyq4QPFdAp3msAin0NUYwTQlqp+LWmODBejsCCfC2rKkSkYsVaZvkkyUep9glOYzyMp2EeEAVxS/9UqEGy+mQqwRyq8WDJkYx65JuR1y3cnVIOudfzHbPz1CKKhmkb2e/bqXyJ4TDiJwqjlGCezXZRF8hr3aC7EGHyF+AHnU+Sr/mboZgajLrweiP0TZo2JrYT27NdLiyCpSfCuMup94dKPeEIoCO4E8XkrgaY9fbDjz/sQ8DFmnaKMYA5y80chzFz9qpncjqh00pWpfKvT4+7yaDFb1zRZfk62BXbryNgGy1V/RHMpwJGMnGvI9X78+rT9gQRj7FjLhju5SAsr3dqjV7wrzs6E1b1733333oZGWeIwyfgz0m0vI8hyMpxDDb9DzYgz7fFHjq037T4pZqmBiZhgwCDfM2rvut/HHlyt7Rl+59qAQLEoiVrWagaohzdKChbR7wKnZ4 Vtct2ffW /P6AQJXj96CyQuefXyuWCyzJmmsxh6seJVld7cdZoQISRsDs70WVv2A2sqDcM37reEhaqAfbQzChvLf0f1QPsD+cRpKvvcf07CgKhs3FPcRN1K+A79zQdUqoMf+QnqQV6sZtxQg2GkK/v2ibL89tq1uVf441L1DA4oOv3gYrvTynGA72d+rNuFU+t14+HTkK6GiJX+WRqt5raZMrCh6zXuW63lvfP6CwfLiXenv90YVSNUhCLK4AUhb8SgH7GDfWyCCgjBhgeMBJkhcXqsL4hkwVoxVnd110amyp/4LUID9PdDp8P8iO1UkR3Dn06xW6Nj30jl71VrbWVEb4KOQAHvoCHmLDjy9g/ViuWvQZOMbbhkf5Bd8opXP9gYrJhjB2MYxgZasN01kgIlyq0n6QIPR37HECf3EKwNzeDuHskOlBLx30BCZyTKGVXXjKCkoeK4lm1l6vL1lTPBAY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 06:25:42AM -0700, Christoph Hellwig wrote: > On Sun, May 07, 2023 at 09:58:44PM +0800, Ruihan Li wrote: > > static int usbdev_mmap(struct file *file, struct vm_area_struct *vma) > > { > > // ... > > mem = usb_alloc_coherent(ps->dev, size, GFP_USER | __GFP_NOWARN, > > &dma_handle); > > // ... > > if (hcd->localmem_pool || !hcd_uses_dma(hcd)) { > > if (remap_pfn_range(vma, vma->vm_start, > > virt_to_phys(usbm->mem) >> PAGE_SHIFT, > > usb_alloc_coherent and up in the DMA coherent allocator (usually > anyway), and you absolutely must never do a virt_to_phys or virt_to_page > on that return value. This code is a buggy as f**k. Odd, you gave it a reviewed-by: in commit a0e710a7def4 ("USB: usbfs: fix mmap dma mismatch") back in 2020 when it was merged as you said that was the way to fix this up. :) Do you have a better way to do it now that is more correct? Did some DMA changes happen that missed this codepath getting fixed up? thanks, gre gk-h