From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CB0C77B75 for ; Tue, 9 May 2023 23:12:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 797106B0071; Tue, 9 May 2023 19:12:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 747576B0072; Tue, 9 May 2023 19:12:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60EC46B0074; Tue, 9 May 2023 19:12:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 51E056B0071 for ; Tue, 9 May 2023 19:12:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 16B5316050C for ; Tue, 9 May 2023 23:12:37 +0000 (UTC) X-FDA: 80772267954.06.CD35376 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 3496F40007 for ; Tue, 9 May 2023 23:12:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="V/SS/seC"; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683673954; a=rsa-sha256; cv=none; b=F435sCvdE5iFx8lE3qu8DlzXQT0qZiE7MW/4ldoqlgZFRJB0VKRZEEzR58bUVAzZDAGvQx D5hMNgCN7K3qw9ab5AEweqQTSBBZ7/fIQP+OO4brqQR/6VCYk6zuNvcz4siXxPFiCqhJFE 0QuB2k3NhG6ffRRqFv7wM5qdNZGTdvs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="V/SS/seC"; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683673954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wsD9KB8rwhL64R3z0V/KzY3XAw+m5P7lxWeCSSUszJs=; b=ZG/DXt8oHC0O50WcfNi5K2uhAmk4M1y5zLKyqOdZqj7WhGO2xiRckXzjbiARhlPhhoc8d9 bKSNoNyyJ1eGyuOxDOkHDSoWgznTCqCC0CwdA8AISK8Z/vJlxgbKU7OGcmXuGcQuezIdW5 O+6zV4rnRQL6oDxir3/gb2+poUhrB1g= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-3f39fd9eea1so5634831cf.1 for ; Tue, 09 May 2023 16:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1683673953; x=1686265953; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wsD9KB8rwhL64R3z0V/KzY3XAw+m5P7lxWeCSSUszJs=; b=V/SS/seCW6G94qinBxjSyu9biSNd7gbCvHXWG2nG4L36DeAdFpwXzYXeshDgDG1AfP X2FyMvg1/FowUZX0WD4D1qTfUSXkRERi71kSsUP+9LYKPvbTCDmI/VPhU8v9JGV4bl0S RWSlYSmHsKNRW/qgOqnwRBqYTMVuYbOUf0LArDCrr/eV6QzAoEiqNGskDz0O78dS2Xv1 2jnhMEp+fYja823/X0rZKpWIDbG1qGUW6nLp2CswGjWRoTZ8PVY9kAWRI2TlcT3cMl9f kiGw0krw7koDpyauv9FtcmQQvmS3ApdkL/Y1D5aw14+t7Bym7BetXxwMu4rhGimBOe+G dkLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683673953; x=1686265953; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wsD9KB8rwhL64R3z0V/KzY3XAw+m5P7lxWeCSSUszJs=; b=WryO/hY/SKG7HmOAAa3HCsUcyENscBYW7fLTYtk2hyrwutrLxMrI+Ro3Ewct4tXpON 9FCKy9mnNsw5RgzY0D0EJaTX/hu/rYV/VeWEsq4SFe2JFYJgwgAHfY9xBbn+MAmwc27F 5VDGVQPEnKI/s2XVYvFFtE5HkKN8yymEnndJJ3rNs2b3rseCsE1scZjvhMH6OPV7j8PN jxQuAo7mBKTW7pIPWNTurwwPEckyN+xkkm3uJTUHjNHsC6GeR2zB76lOp1xIiC7l+x/F W3fEoAziMwhrZsXxZIAEWZI+ix7Cyro4dglWJ4OTMps8PbMI2b9fhv84b7vzdo7dhOTy 74xA== X-Gm-Message-State: AC+VfDww6T9QYbvpu/Fb86jX2C7RPE2f9DU4kHnNSF2I3at0pKKw85xA DgG21HUh0bdfydcmbvvH8HPLnw== X-Google-Smtp-Source: ACHHUZ5HcpALAJLmzD24rKvBmc0u/Raqmedf771QLeg9nT6avZ51QXzeOOU8CHWG1PUL8meDrpGNLA== X-Received: by 2002:a05:622a:1307:b0:3f3:9489:1c2f with SMTP id v7-20020a05622a130700b003f394891c2fmr8790569qtk.33.1683673953171; Tue, 09 May 2023 16:12:33 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id x15-20020ac87ecf000000b003ee2fb84d0dsm894866qtj.11.2023.05.09.16.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 16:12:32 -0700 (PDT) Date: Tue, 9 May 2023 19:12:32 -0400 From: Johannes Weiner To: Tetsuo Handa Cc: syzbot , syzkaller-bugs@googlegroups.com, Andrew Morton , Nhat Pham , linux-mm Subject: Re: [PATCH] workingset: add missing rcu_read_unlock() in lru_gen_refault() Message-ID: <20230509231232.GA65434@cmpxchg.org> References: <0000000000004c3e6b05fb414be2@google.com> <610781bc-cf11-fc89-a46f-87cb8235d439@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <610781bc-cf11-fc89-a46f-87cb8235d439@I-love.SAKURA.ne.jp> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3496F40007 X-Stat-Signature: aywfpkkpz47z3irqwspkkyyesy3jhsne X-HE-Tag: 1683673953-882367 X-HE-Meta: U2FsdGVkX19m0lAwJZ6AewbWy2YOzTAwhq5/Xe5dNYyAs5YYrStNR+syLeuPWD2XVZQCnbuFgIm4uiOJ4LUMu2/683aI4L2OzqI4yG3cCCmB9T6FZTeMIJUBC+GoMqlZX6AkzPoGW7WH4YOaSweSGs1U2ib36HvL/e9YmTWSzTnUtAjaBSWh7Q5j/b7Kz2PYbIi4yd/F8LzHBADTgvjreyRrM9xpItkE5Pugv7grNZAcEigEq3fCoqQWlugIYK4svB1tKu2+eeiKEKq34IWGSnxhT6aDBHGD09d4ODlsG3RAZNHf3K2ueUOUVU7UNhLEDqubtf3PUeU/FYbTGUCb8mJ5r1AUd2o0M/6aDioQ8/BfNx5Z6wWMPBc+IYo2X82s3JL5MuZaok8gt7zflyq9j3NO69RDfZkTrpV4TYQcDhK8Y6PqF3D5g+Cp0IwjseacKjvuFRtehuzHEtjEX8RMxWtg3cT9dbvt3m3crYcn1b+aBbGy/nxLtAH/goGsWZovFQhOHFDxV/WDFrgkcRmddPwyLOs6A5uhBGpAnctDB4iznkJEaM20AkZosVwTJBfui6AwpJgoliizLs+Wl17dv9fni6PoRqZ3o4jECq8HmpHZjuHEwLm5MThAM1Hq2+kLm15jmuYv1MzDCZVX8l18/qjIsanmVzp5ueDV7YNRVQ1g0YetzOQG/FNfj85Os+X1PNUu6mzrBx9Tm0+nEwYSIWQsXsEeGef4SkK1cQ5Juq/jPXWO+iQVrQoZHIjUkw9H3Gxrw8H0qEJXvqwbmQBSaw9VVEzd0ZGUkGQvQR8W04GhnOQgIGuIaMvYjS/GfsrhhDxcHVwDqjmIDi3eJCVXz0sVMI5m4BKrLBiMkP673lc0nU7xgpxeJKLWFvirev+pDfUb49Mq1zh8mTS5a102upVBy3caZDrPuRxXuRpLOymGQk+921kFiVSZRIDIJysEShq/ynbkMm/Abwit/8b pjItMhm/ 6VTXMBLhjmWndj0irzcLTAHUCbYpUEcEz1B/bFe+ddPKvGit1k+ltZaAD/EZ5nWLGdK1IfilzlCeJub2sf6r+Lqu4tMj2JELaGovh4i1acpUp1y39k/HG89e923EFseayxb2y9qgbAeLmqop3eKRyp74t4+Bw2y8s2oguheW84Su9yWo7YfeXKibt1ALfqI0rnUciN3NxFxwZBRlTxeyRia/ztLm3pKLC5KkXqvye8xIr9ePZy950zl+t6nrwfM/i62DHTynfqTBGhfdeNRK8wS9aOJLpIJN3FZmla6pohbyaErpkLqaFrCbYJcDSYdxPpCVJFuwM374JhE7YcHNoMwO2A+pwukZWZwMHdCElc5inZGePfq0KCFsi/ujDuKoHj/q8WLVnEQPPEj5x97/2ujttENostQ6OZPBqatan3oT/wwVzu5CU1LHvxrX27TJyhB/I6T6RtPNA8ZmEKCfH0xNSy5Lr3qdHMdqytV+0wlrS1uDrS3Zv7TLVtHcbfFV4E/ybM9xo+TDQi9NCVaYXjuH/9AAO71lc1rtSILPuoizfwllbH/AHGGqNMni+DUOeFFWSYkxkQoyx8S9EywxSd9OnDZEp1KSGhjjtxOUztn3qa6icA5BbSXVTswc3Xc52YBfbznpFuFOhzN4wXMcaOcCigqrwJSSQfiqnznR3+GwXpARgjsqLuiTNFyJWg19zAYSZRtZ/5TyrxoFEfM6OTXITGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 07:22:55AM +0900, Tetsuo Handa wrote: > syzbot is reporting sleep in RCU context, for commit d66c718d28ac > ("workingset: refactor LRU refault to expose refault recency check") > missed rcu_read_unlock(). > > Reported-by: syzbot > Closes: https://syzkaller.appspot.com/bug?extid=3c6cac1550288f8e7060 > Signed-off-by: Tetsuo Handa > Fixes: d66c718d28ac ("workingset: refactor LRU refault to expose refault recency check") Oops! Thanks for the fix. Acked-by: Johannes Weiner