From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 550EEC77B7C for ; Tue, 9 May 2023 16:48:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE6EF6B0074; Tue, 9 May 2023 12:48:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A96096B0075; Tue, 9 May 2023 12:48:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95E276B0078; Tue, 9 May 2023 12:48:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85BD76B0074 for ; Tue, 9 May 2023 12:48:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 54F9E16049C for ; Tue, 9 May 2023 16:48:57 +0000 (UTC) X-FDA: 80771301114.04.4A28276 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 94BF4A0003 for ; Tue, 9 May 2023 16:48:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EkyD9qXG; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683650935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SVQG4Zgmuu8EjLZWfeX2Ew6g03EIwbDi6NCIZDAEexo=; b=gT4V04iJDaK38PvO2fA7Tofw64lxztSXNad36bf4+ocl0taTBWqkR5BrlE0+jih/zGjXgA qnmbOrd6i0N7B70+IUHD2LOU5c3C/BKg0hc7wZ3Fs9LvbdTAtUIhZx/K94wj3fIpSWW2IV ugC0un5cN03Xh3+fXq9TdpZOJ1TajE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683650935; a=rsa-sha256; cv=none; b=KCoAbGZML2Z7ElPo6XAcJw0vDTwXB1/aQbMh709PWNzcAe0yfkIqH7sTRGKAk9Qoh/NvX8 8bQQRzakIb9V6i94UhNcB3PwUYMyYDN+Ot1ygwWz6KYyksJcq5nGON4jTBOfxIuoVWBeXP jB5IE0+W0jD5VZCdhOpMAvUaRmgcZAs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EkyD9qXG; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7884F633D1; Tue, 9 May 2023 16:48:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ADCFC433EF; Tue, 9 May 2023 16:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683650933; bh=/5mgumQsRWcCzDVcW6dKY3+mva/nAJpSN1nWmyf57wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EkyD9qXGv6gqLuWoxG7a4O/2aL77tF6C4CjEFN5pbY1qgoYmUgdl6YB0ErIZrSbwx 6l5qij0vpzrKEr0RUgkZgW96SXq5sSiLT7kS1XTwbHyyvAN2nAkOqRQkVA0y4UFbHM JFn4bQsYzFSx2fskfwymVNAvXzfy07AsWs3oCQl/bjFs7tZQ0cou2/DHgmN6yArTne SdquKQ8yztySUb72ETE7u+Fn/2PVbTHPUKdyY394XjU2uJA4yxP5Z5KM/bl8C0GS+y gPIRZcDY9QGNqM/jAAeCJ2E8vAMz9FsIHgEQDZWglWacFL4jIjCx7IYjHOBIqfLuZw jAx3PvLiwTjQQ== Date: Tue, 9 May 2023 09:48:51 -0700 From: Mike Rapoport To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 06/12] mm: page_alloc: remove alloc_contig_dump_pages() stub Message-ID: <20230509164851.GD4135@kernel.org> References: <20230508071200.123962-1-wangkefeng.wang@huawei.com> <20230508071200.123962-7-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508071200.123962-7-wangkefeng.wang@huawei.com> X-Stat-Signature: jx8h6ar5bdihu5fk9h1eqnfenp3d9zpm X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 94BF4A0003 X-Rspam-User: X-HE-Tag: 1683650935-50590 X-HE-Meta: U2FsdGVkX1/dLghPM5l8Xt0wXFTPm4iw3ZHfaVXP0CHhHFehp6ChNvYjGuZhPEpJOWQ4c+3nk/O8l2cHRdhAoYoZ/p3++tYNkqXnxvaN8Sg/1RHE2eHEv7XnyUhWdDTq5YQWPwBmhlgwvv7wKHSdm1eiDMZzHGWyCyr5n+m9oYdXgCo0mduYN2BrGbP9TpAp3rUsoG2kFMHfNADb3CX1mQKPt0SXQcX8piDXJejQNhc7tdQ8L0/0wGkcPPCMSGY6ApehcCo4DtIc1gt9LHVou4rpbtrttLR1KGzrc94vWOrwedbXThpKOsVXRbBww1tXGpqK1Bt72i0UqeGxKikOAZSsHE34sCDvDc2ZLf0afLh/EZzG6opLQCgkKC+fnQJmIYpwglCrAU18wtze3DM9PcBGeqDuK/oif4S8IE/52cPCInJvXyKHbjVh1BIk5vLDRCwDLa9SLAiCsWYlb+yUvYyNPtHIYu4AvD0yfWEF4qFkZYtm9CLA+IIXzkPgiLadrNsLnbB/yypppNhc1b+IVWBS8LmTi5xLwmdpGWJXlNrSsNdKzpbyH2fXjErJARD820ROCD3uAdHJwTjvtfailjGcaiOZ0A1Ltz7Fh9DLicRf274VcKB6J5N3MlFOwiWYxxUzFyJZL4Sg8HhAIGyqsFGkzGf7KEcMDcz2l75F+sK/P+Z0sUfCo+ZseA9MhwAtPwXajsSDfXqXbQrW+R4md96Sf3MQSWHZIqTB8GiK8wLLQFzr7HAEU+yHw8U4rIfLSOEGeapZHwiINWNYMF0V/Q2zRN0EcDd3iW7CZQvvQD//jEZecNaAPXNIuqKetQbSGI8NxG6mdbzPbaOJ1qSnHVbK6dF0f96wf7zBzbx//NM6wubqA2w7pNYgMFrPCK8yewLoADk0P8Il00gLdoFn5jnSV5+6UrLItLiaLRHthfg9tmH6i0vrW2LCz2GlSVY2qkcdTYW7YBia8gRXOQM 7MAZbW6t HgUW/rt0palBd0/PrlWN+mvJL05aB4uk1e/UKEW8oTfbLIUAYCTwtxRhV1Qe/uqTfZTXZj+3IZ7h9CI2UIOZk5kMiNlwHArB/kqwVLszrEgeaVn2P5CTu99OorSzjxgZ5Mjj0eqWLKa9AM+W5CYYXzolWf3fgEnfuYuID0OtJf2tNse8ploVUGv3nOj7I39ma48dMaMAF85JG4bV3a8OdIFHt5RmZCARvTGS2uPhzKBhkM48w8bWEjRcbsvRjgqhycoJ6jZxH09oyDWgK9qD+HkhzCSKY/bolmuH5Dt+A+784FPyA4HJMJOgH5+RL5v6I8RoeyPbpaiHK0nXcOfRHYAxSvlfoBv6Ap7FIPPjC9lPTW4sQIrcvF0oXvksglJ3rHrCM1h0bfUfefwK8Wjn3SAlETCsweNrORRqt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 08, 2023 at 03:11:54PM +0800, Kefeng Wang wrote: > DEFINE_DYNAMIC_DEBUG_METADATA and DYNAMIC_DEBUG_BRANCH already has > stub definitions without dynamic debug feature, remove unnecessary > alloc_contig_dump_pages() stub. > > Signed-off-by: Kefeng Wang Reviewed-by: Mike Rapoport (IBM) > --- > mm/page_alloc.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 348dcbaca757..bc453edbad21 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6161,8 +6161,6 @@ int percpu_pagelist_high_fraction_sysctl_handler(struct ctl_table *table, > } > > #ifdef CONFIG_CONTIG_ALLOC > -#if defined(CONFIG_DYNAMIC_DEBUG) || \ > - (defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE)) > /* Usage: See admin-guide/dynamic-debug-howto.rst */ > static void alloc_contig_dump_pages(struct list_head *page_list) > { > @@ -6176,11 +6174,6 @@ static void alloc_contig_dump_pages(struct list_head *page_list) > dump_page(page, "migration failure"); > } > } > -#else > -static inline void alloc_contig_dump_pages(struct list_head *page_list) > -{ > -} > -#endif > > /* [start, end) must belong to a single zone. */ > int __alloc_contig_migrate_range(struct compact_control *cc, > -- > 2.35.3 >