From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A91C7EE22 for ; Tue, 9 May 2023 20:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 449786B0071; Tue, 9 May 2023 16:51:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2A46B0072; Tue, 9 May 2023 16:51:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224F46B0074; Tue, 9 May 2023 16:51:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0DDA76B0071 for ; Tue, 9 May 2023 16:51:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C5AF7120545 for ; Tue, 9 May 2023 20:51:08 +0000 (UTC) X-FDA: 80771911416.02.9968375 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id AAE3A40015 for ; Tue, 9 May 2023 20:51:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SAeTk2Th; spf=pass (imf01.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683665466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PNiIZHyonT4Lc3v22Wd8EHVvgd0ES2GAsHIl3w6taTA=; b=4/ViEh2ol3GH4Coqycxthd+go4g2uoz/GaZbQftD4CHW39smlXwQowJbgAqFwF2GiQ6o2w e7yLs78ak53BMhbSZRdmsuohEbOedIh3M5WXcwS/kWJnYi/ZbVPch+cOuwstCJ3oaY8yB5 Yck3vZ3xmrE1PRYmj+5vx/OP3l0aYzQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683665466; a=rsa-sha256; cv=none; b=tMHffXpTSJ1/NV9AolqznTABUyzo64PwJQXSrD6xwJAGhnLih5VB/1uFdJGwGrnC7EL45z EFuCbzJtuds9ypEbQFudJqIGP4i0cKySyo/zmdeVMIXt72Z5Op9ILg/9VmHbLLDVllQf8F H8TkUiUFP00vgFNLiDSKhwgbZRE5+pE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SAeTk2Th; spf=pass (imf01.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683665466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PNiIZHyonT4Lc3v22Wd8EHVvgd0ES2GAsHIl3w6taTA=; b=SAeTk2ThdripM3HdxcC30tK7PwUcp+Rw8rfp994YqkwTknrFGGy55qc+B6CDulQxBBraq7 JMCAcMLt50Dw+KYBqcYFv3bYl8ae5KxJOs1LHFBhLuzJjfz4Wf9VacYVYam/jt4kJNdEw2 vVmWTvO2TrtQLmxXsFuILzflnu9kbBw= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-278-SmHFCy1YNnSOEwZCW0QTPA-1; Tue, 09 May 2023 16:51:04 -0400 X-MC-Unique: SmHFCy1YNnSOEwZCW0QTPA-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-506e62603f6so5871150a12.2 for ; Tue, 09 May 2023 13:51:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683665463; x=1686257463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PNiIZHyonT4Lc3v22Wd8EHVvgd0ES2GAsHIl3w6taTA=; b=AxvVPYo23ak4vNNoPAvVxzqkiMZnBc17sYaZ5Yb7J+ioyoyydFTQ/qlm0WIJRydc4D C0cRlFvCZ2USLIWGrzkUEh3STCg93v9CG//W0v/ENsYGJ03k6TG6E1lPqK1uxycshbzU +eAIEm24qetiV8ybSlEMXpTqnTKzqQlj4SF2VCP9Ncxg7AskRfZwNM7ksgxZeImp7jFD IvGK03srj/L4GDuk/w8B4VphVdjPtBZMpSwK+kvjjM+/3SIs1RdiA+DP6cWfzHiudva7 2q+V0fqKOJbo7HynNziHPrNgU7gJsfYCrF8cdRvax4TWaVB7lZv2Du555dWppWBoLYWs pweg== X-Gm-Message-State: AC+VfDypXGoGMxd9CjsQlZQdJpG2GpAWE60vFTEwB/zPfm3LYMTzWOtU ko1GOdB0PBQ+CcZsf6tDiMkgm4wP3Fpl0HPTPWVutPErA1/XMapPrWTWAMpU6mDIlW2QgNiq+eu RDfREoqek2MA= X-Received: by 2002:a17:906:4fd1:b0:94f:21f3:b5f8 with SMTP id i17-20020a1709064fd100b0094f21f3b5f8mr12867376ejw.21.1683665463523; Tue, 09 May 2023 13:51:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ64Z2n6Cyo1Ac1tIrysTfZgGptf8iyw8BdvNxTLiJKqxc+sT/Z3BRYol16b0K6FWwTa13f0sg== X-Received: by 2002:a17:906:4fd1:b0:94f:21f3:b5f8 with SMTP id i17-20020a1709064fd100b0094f21f3b5f8mr12867347ejw.21.1683665463199; Tue, 09 May 2023 13:51:03 -0700 (PDT) Received: from redhat.com ([82.180.150.238]) by smtp.gmail.com with ESMTPSA id h9-20020a170906584900b0094e597f0e4dsm1735890ejs.121.2023.05.09.13.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 13:51:02 -0700 (PDT) Date: Tue, 9 May 2023 16:50:53 -0400 From: "Michael S. Tsirkin" To: Yuanchu Xie Cc: David Hildenbrand , "Sudarshan Rajagopalan (QUIC)" , kai.huang@intel.com, hch@lst.de, jon@nutanix.com, SeongJae Park , Shakeel Butt , Aneesh Kumar K V , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jason Wang , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yu Zhao , "Matthew Wilcox (Oracle)" , Yosry Ahmed , Vasily Averin , talumbau , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 2/2] virtio-balloon: Add Working Set reporting Message-ID: <20230509164528-mutt-send-email-mst@kernel.org> References: <20230509185419.1088297-1-yuanchu@google.com> <20230509185419.1088297-3-yuanchu@google.com> MIME-Version: 1.0 In-Reply-To: <20230509185419.1088297-3-yuanchu@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: AAE3A40015 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: wwsxrurp5gy96zu19ewmby7xa5uncob1 X-HE-Tag: 1683665466-757512 X-HE-Meta: U2FsdGVkX1+0VISDVpr+tKLPG6cte8R/s6sxpcKPKGbmuKWaIQHIdf5q/BIn3suF5ciLPW3EfGAG6TCFIMcQSlRnwHAH3CanSY22eR4x3daUlEgsLPZcmn3zfIMQVoQA23gIGOghptJdSW2MPBD3UnDmfqQnZXDaLndJrH10i43KoyHlpbF1iPIoPGcWfwmxX8guZdsQvcbETUsRL9gxcGroefZNkBSDBl5eibVuf1+T7+YR8uw7lxjKUfGxkZDNPwhCyne101gh02xMXMncPYXc/qdvEQRUBXK4kb9lLlaQP6BTPVWMViNzBFumn4T745OSq6sfUAW6sFzKVhBQ1OdvNNPs4jFUv295MUSEscwIPiWZ5O82z36HK7nx06c0SClZK1YubJBzOL9L1HkZE5H07BomSSmYRLRjPhT9PL1OtqQeAR6AT4Wo36a17VMNwgW7Z38IBMoGAJbwEod6OBkUbMtTe22INH9gYCpuw1+eOh3s7l69vxf1KDfT1myhCfbfnM55n2Qim8CQhF8IE1UL4qopjcv3k8RZ9ERvfDyJGtGZWfFCs6dH/C4LZOV8PiJOR1yxlsnGDs9ycdRQxpwEgdDdmFn6ZsxgOOKUiouao4/wzffHSb7i4jEHSnZldQm/CoEfb8yvzbgjyNy1/9olxKlH7cZ3tDrTYmrAJhWGdpyhter85M8OEpuyds5KQKcNQGi2FGHyAGkkVe7aw4p5E3PMgL/MAdqkLu3VbQRAw5YCFoWkpw82qCBRiNVZuYTfn3scJ7rQPISfNyvIX7C4x/m4+OwVVXcj9emhUYvvrffCP/THtEhMdfRE9UB5nXUrY3q7/33+Nqp7HkdXDJ9aDavbqwwWXZ7xYEhYxX++sNhMBQGHED66EEMuiPuiBycjYqIxgXcZPqHCmbyk4IuXiSSnWc5vyqelBt5Ms25u/FudWdwY1AlvJwQplRSPOpkRUASD8ijhLdkZw8E P/0+ZlBv 78hhvd9/ZxQeJrhpiZ6eXeHjKINpc8Orc1hqoDpJE5Nl/97rV8XZS1dFGhlIx7XMRy2wXQ5zAkCagGw5hfGtAkEk+Owzdb0WaRjjHZTTNlITvc2jWDrHxtyeBOr2Q7HGzkq7hBhiKr60NYmQNTvbkQ7F4inwFytSIuVdoRe1eg34bOW/ubwt1I4tYyNnLH8qVYBVP9rM0vi7cBe02+kQf9uk+byEPmXBKF8UnyCchrzAt0BksSoHesG9hHdrHeTJJ3tnp5hXcbCUHnb+fhmzKe7LzGD27Yrir2CTq5j/9Vzvf3/QBBODh2W5GWU6/gwBEm1UzHqrbwviFMjmlrgPT7ZOCuUpgjy14ZpqyxV+a+hfN0YtGunNg4eSD3+cXuRNe7qhC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 02:54:19AM +0800, Yuanchu Xie wrote: > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index ddaa45e723c4..06d0683d8d8c 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h Any changes to this have to be documented in the virtio spec and be sent to virtio TC. > @@ -37,6 +37,7 @@ > #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pages */ > #define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisoning */ > #define VIRTIO_BALLOON_F_REPORTING 5 /* Page reporting virtqueue */ > +#define VIRTIO_BALLOON_F_WS_REPORTING 6 /* Working Set Size reporting */ > > /* Size of a PFN in the balloon interface. */ > #define VIRTIO_BALLOON_PFN_SHIFT 12 > @@ -59,6 +60,8 @@ struct virtio_balloon_config { > }; > /* Stores PAGE_POISON if page poisoning is in use */ > __le32 poison_val; > + /* Number of bins for Working Set report if in use. */ > + __le32 ws_num_bins; working_set_ pls. eschew abbreviation. Really __le32? Is 4G bins reasonable? what if it's 0? > }; > > #define VIRTIO_BALLOON_S_SWAP_IN 0 /* Amount of memory swapped in */ > @@ -116,4 +119,22 @@ struct virtio_balloon_stat { > __virtio64 val; > } __attribute__((packed)); > > +enum virtio_balloon_ws_op { > + VIRTIO_BALLOON_WS_REQUEST = 1, > + VIRTIO_BALLOON_WS_CONFIG = 2, > +}; what's this? > + > +struct virtio_balloon_ws { document fields. > +#define VIRTIO_BALLOON_WS_RECLAIMABLE 0 > +#define VIRTIO_BALLOON_WS_DISCARDABLE 1 what are these? > + /* TODO: Provide additional detail on memory, e.g. reclaimable. */ Well? If we don't now hypervisors will come to depend on this being broken. > + __virtio16 tag; > + /* TODO: Support per-NUMA node reports. */ Same. This is ABI we can't merge with unaddressed TODO items. > + __virtio16 node_id; > + uint8_t reserved[4]; > + __virtio64 idle_age_ms; > + /* Track separately for ANON_AND_FILE. */ What does this mean? > + __virtio64 memory_size_bytes[2]; > +}; > + > #endif /* _LINUX_VIRTIO_BALLOON_H */ Use LE for new features please. -- MST