From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95F7C77B7C for ; Tue, 9 May 2023 16:43:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5911D6B0074; Tue, 9 May 2023 12:43:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51AC96B0075; Tue, 9 May 2023 12:43:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BBFF6B0078; Tue, 9 May 2023 12:43:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2AD346B0074 for ; Tue, 9 May 2023 12:43:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EBAF71A04A8 for ; Tue, 9 May 2023 16:43:51 +0000 (UTC) X-FDA: 80771288262.04.3D56E45 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 0EDF04000A for ; Tue, 9 May 2023 16:43:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tHZcLTJ6; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683650630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wOOxgLH7twDjF39Xnd024gW9rj6NCQA/u6ltoAZRj48=; b=ao9QU2MvJyuLkM0fJ8PENBqOtupyIg7wMdVQWRjXaWfIv2OxBgcFhy8drEQVreoNbNF7qD Smx90KcA1nBXUzHqPrSE757G0wDxVR3R6w5pwp645yXd6qAbB92Z6knvp8o8VTyw4dq22z K8Hk0D/G9M3j9+VE51M4dpTNH/djw2M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tHZcLTJ6; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683650630; a=rsa-sha256; cv=none; b=fsOp/9IgXPEc5mJAVNB7CT9x0q6aTYMm3k3GuAyFaYr88QYa8jkYml3jPqsOk4+BRyUxqv 0yXaFZqokeNxKg4LfLX9o1ixsB0JeJ2GtDXBdFd65cN78CAbqLEtfE+LtcZk+D35m+M33p KtK8fD5KsbGfYVmLshpfn+np9yuYFUo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9431629D9; Tue, 9 May 2023 16:43:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4528C433EF; Tue, 9 May 2023 16:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683650628; bh=GH4ozPy6BUps1/YzqMqfSKcfN/+aGxS7E5VYZMBfEkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tHZcLTJ6DhykdVVMqHJKEDZm2sxaYZVHw0gZWB8Q2QiIf9fGDT+Ii/NXmKjks2rg4 9L3hMi4JKoEbtWSM5aR0t9iz+mvr97o7YV8lEYhrg95CfDcf3na0yv/OwaW7ct/QQE xtOapeboqMo+rZ8zieUimyvOKnnG0ZTzMdjIaYfVlxK3IARoSXgIrTDo8zQsiVx2II lN6KQB4U+RpSNFKHXFxWEIK6/1ewhUl3BDYu1f60a9M3Q/PaJWzGNkK7/QU9Kv8au2 xb3ZuDsLzYM9vgzrykTdbuzqci7XtLBQJc9CTrh5moVUabH5ETISbwqpNuW9HWlal2 GYJrgl+D4PE9A== Date: Tue, 9 May 2023 09:43:45 -0700 From: Mike Rapoport To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/12] mm: page_alloc: squash page_is_consistent() Message-ID: <20230509164345.GC4135@kernel.org> References: <20230508071200.123962-1-wangkefeng.wang@huawei.com> <20230508071200.123962-6-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508071200.123962-6-wangkefeng.wang@huawei.com> X-Stat-Signature: 6wyrgnxgphg5azbtn6gygfkmbedbzhsi X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0EDF04000A X-Rspam-User: X-HE-Tag: 1683650629-458344 X-HE-Meta: U2FsdGVkX1/6P5SqNP9LNclHpUSdF0uTHMIcs3LU7QgC4b+lXhgfZEE0AJDdPqbMT5/oE3mqqj0p1byurHN4BbFvWTgg3G8Eornv4MW2c3hj7KClM82Am8lUQr3xMMlVIYe2S+OVlTO7CeApa2UBHLQ65fWtj5qexLdCzlFSNo5YN3hC3cvu2b5uq9gUdgN2hLnwkgoSzpwAPpIIrKoDC9av5MZqs6VtqMAonUnZA6CPjDc2Voa6CERqeNwpojQ0vVk2yM944IF2Ak1LjCmKah3S2E/gMLyAtJ2PoJ8f5HhbjZ7mqth8xO0JY2in/qN6jLuJAKYFEXCuKNcWGzMJ2vzhWenRoEKWNHtY8M+9jH3qhqv1u4Y6ZjlYW4oE95WXVWcjpxfFn6zCgSXHqwH7wvVF9z25ZdxJJOJda23Srja/p2dO0e1VJHQRk6G/5j5zB2wR4jvNkcX3RvBZVq8v495+rov/+6JpI11L1DdUzTPJeV500oA48vzcQrRRKelHYf0x/C1Ioy2MKRxPvSU+bMfGmM5ATStqKIcapQ+EmfVG3TFxF5id2tOT3wtMsEdGYHT7ZOAx8QCHb8f0ZeBTc37oRZYuc62AzlWeUWNm9KxRytAwRn4Dc2OWiKuhl2BXt/sQY4iQUqqZBZm+b2aknQqIx/ickx9KC87XYh2Pp7sXZpqr4RaADaQJoJzZcZnN4D/Ogf6JO4v1i0x6mmZkFEHYFL0UYRDZPZjJvuBJ4g7XYI+MUmKWASJ6pSDX7T1t65YkF+caBUVjrxA8cfczvyr/8GRruWiqT0Ao/zRvEacVHp0FTW96Fkm5ioDRy7qWxAiRmXT5VT5qrNRan/uYNtP4jMqdeQSeKtgtcpR3wW+f9GKIZwg4ciMu5aYqqvRHDEfkGyDoDsshLz+ltTL3Us3ucd2LOqR5rhKuX8v6epuwIT0hqbBGmhzB31ytCkT7cUAXltYdvtagPIGzpIz iyjilc8N Dvxn0ooEbGlSXV3Z+Iab4UVjAHwo2uINR1Ufdv37BkySfgw4+r1HV6qkRCuaqtPg1vQEo4FAMEbBNrCPt0VQgZ+9LNDsmlh0Ya6H2TSLhZIeUgCZbNj2nC/bQKol/qGR0F94AjFvQfFNFbRMFdFt0QenGN+OpRfykmpNVIjp7Ror22XE29yC5aHQRkCj9VhTt2TSrwi6o7g2aM6gp7zv0I/Qt1suOl0fyJK/QGWllm0wa+N0RQGPmqgmCj/oHEdKSAaGALmbomzE+XoYOCtv6JFzBZF0PJYe6qlzet3Wt+JwUZowgt4IDVnZd6j0PXHm6Je1YekmofstxgghbDP8pQL91PWlSmNFWnF4dOmS1IS1seXNnHVPTEH6H/Si3GTS3aXJU2EcrXDYzbhhtXdZhfYX1jgXySXIXhWxm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 08, 2023 at 03:11:53PM +0800, Kefeng Wang wrote: > Squash the page_is_consistent() into bad_range() as there is > only one caller. > > Signed-off-by: Kefeng Wang Reviewed-by: Mike Rapoport (IBM) > --- > mm/page_alloc.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9a85238f1140..348dcbaca757 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -517,13 +517,6 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) > return ret; > } > > -static int page_is_consistent(struct zone *zone, struct page *page) > -{ > - if (zone != page_zone(page)) > - return 0; > - > - return 1; > -} > /* > * Temporary debugging check for pages not lying within a given zone. > */ > @@ -531,7 +524,7 @@ static int __maybe_unused bad_range(struct zone *zone, struct page *page) > { > if (page_outside_zone_boundaries(zone, page)) > return 1; > - if (!page_is_consistent(zone, page)) > + if (zone != page_zone(page)) > return 1; > > return 0; > -- > 2.35.3 >