From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD36C77B75 for ; Tue, 9 May 2023 16:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A28886B0074; Tue, 9 May 2023 12:39:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D7DA6B0075; Tue, 9 May 2023 12:39:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F726B0078; Tue, 9 May 2023 12:39:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 79C4B6B0074 for ; Tue, 9 May 2023 12:39:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C04580635 for ; Tue, 9 May 2023 16:39:00 +0000 (UTC) X-FDA: 80771276040.30.5819E20 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 8949A40015 for ; Tue, 9 May 2023 16:38:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OYFk8gZt; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683650338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UmeWmtGgXwV1/Kshtgfyz6RKC7MB+adTITE1xS2g1Y=; b=qU+nLxnsXVWqKoDS2pXVqT6xBTGG1rza94xrLc4n+Hg1kRXxoB0/9UbHWuaNQADMWCTNbe SGnSSW1U1b+QzxDchv6P8i2rS/EGr7KQ80MVL487i41KjOkb9SL1iyS6H4KnJtk9uz+Agd ksmAKHJ19PIH8EUiZfACr/JZiHCBXhY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683650338; a=rsa-sha256; cv=none; b=LvAt4evRn+yFT3qHs+jlTdCSiWjK0kUzYXIGjS0jx/7FAj5M51zoK4hAfv4GqT32nph7Af lJH9PPyZhl78GfIjV5P/2lgewlOICPXfGtG5Sx4v8kJiUdIVityWOKepjNleDNjzkwuQz3 lFKfYk1D/+rIWICXuB0V7xODmdokOP4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OYFk8gZt; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8B27E62974; Tue, 9 May 2023 16:38:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E537C433D2; Tue, 9 May 2023 16:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683650336; bh=CNIoMSTpu9Fo0eEfWNQNIpTO1qX87mPTP8s97bQPs98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OYFk8gZtCaUB0GFVyA5nY2s6X6XAUcoBMqiiEPrWaxX20vmTkcN36Z9hNaCqa8e9F KFRlXdWA9a5Fqib0SKZEI8Va0aCzwr25HaZdj3HiFHP+hRK3GuoSRgOffpg1iY7UES yQMj/+ro7KyYSw4v0MqnRnKf07fEFz7qsVvVwGavLZqlc2DUMqqFCXzWdKW5SDgbNI U0M9PyPEpi3gGZppjIyijComU7HywJ/O52d+zYQbX/NMmeASZFdY13ZodyKNIiF5nK vAjsOkIGwDN6wXDgvSlvb4nn6NUp3T9H3teuWJUNV92VCEkQFHYGQGW033Fjxbdm7a SkEKmOv/I9HUw== Date: Tue, 9 May 2023 09:38:54 -0700 From: Mike Rapoport To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 01/12] mm: page_alloc: move mirrored_kernelcore into mm_init.c Message-ID: <20230509163854.GB4135@kernel.org> References: <20230508071200.123962-1-wangkefeng.wang@huawei.com> <20230508071200.123962-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508071200.123962-2-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 8949A40015 X-Stat-Signature: z4rkwsj7y8mhry4qapn97q3ft9c9ummn X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1683650338-249300 X-HE-Meta: U2FsdGVkX1+nSTtEu+yp5CsmOihZ88cb9e3SOAIWOzrAm25Hh1PJezFYpgGhcLxNzebNbgJzXKP5GmkUPe1p1ejdKzTtYbK26lhkDYZSxG4BpVJo6TIvQJG74bCaVDLdND82EciTAd2WVvq2y9pwyTFSS6IGHZ2hkJm0X1uNPuPDErZ0T/vSIpZnQjkE67M4b+61ioLEfOAUmzeGhK0Ifc9YNgh4E1TCZzMvt+PZpKe4GlTALNOCIlnaPFlt99WAXHVQGvicr3607gmKICkbhVFh2ss3PFRyc5AlPsQ2jSiRZL86AtEBdSV1me1IAVlqcEM3SFozUlJhF1Y/42oOio8UIkThHubf6bd+uwx8tgIL46QQFNQ29Em/DGZsdxxlLw8BuJA5I/W8ep3zs81hM78f8jr+GBKZeMDz0vY44j3UbnNg+m1Tc4g8X8nK0gWieKBJOvSCMh7OctF6xCIKhNQZB4q0WCVV2ELW1yzZSmKvU76DsqAU5Yv4KDOxWfwtrmHZrjCo2C0qTDAsa+MLb9Ej0e9ecQ8oZ3sp8fH8O60whlcYfV5ZwxWiu9NUTn79rOHNUnkZ8RMKh2D9y9eDz91RC7BDvvGy5rqD5L2wdIddsC8O20MoFjxIRcsghqXgWdx2qiKt4xSjAL4PTFWSdpGfHJFoKW5KbTxIZ9BsjgOcWlI7u8lGLb+mWvvmdsXnFYbErzpBC0L0zTKw6mimiISkeytuBkP0jdCVM5sIafL/uQbhaGsaCqXwREjHMUDi9NCY5meusKsbgzkQ6lHbP5UHD8upELPbwo2IB4d1djjcmpKx3XEG+EER75eWNnr0SGBswg4kjz7bfukgiFLL3THM/2o8ZIOX6sTzWe/aiAKKvs1acXOka35yTS/eieZpcaejDDkOhgBLNTgoJW4CQ0NvOeEPdNMrtboaRjc8CB0kuARtMi1dZIkFzHiESE9qcYANOgyTPOo+gL156Le Tl8Pi5SR 4ZZTV9qUNtX4V0GgBfeiU3qSbD0rhAlXvnYLBPvPDV6V227VzsTk7XqF2tIyll7N1D2eGmrBAQ36XadeWLjSrEeFae3idAyRop1lSMuXwnER5Y5m/i7+/ITPKJEH0YtBo1Ns6Wo/9kEtlsueVMqRnp0oj6CHc2wAcGB6+GilNU7HOvS62Paw5E4G3Eu+rsAmlyFWCGJZmpgwj2CzLiPYlG2ClTKjzSkYOxqGPsYtEFGFfdy+q9ZCeDNb0RDm29seNRuOjQtMAz75CbFPIVGKe/buAIAz9HUUQVcxDiAQ01lGN9TAT773I3RJMfOUk3NEnHIYOBhJURn/fBhwPPj6nKjL5UyyTzJr/i9a6J5dkwwaCijEyVOawsiieKoYz75q3EWl6KNC27Ha/NOjbwSZVGJK888vIQVROHRF9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 08, 2023 at 03:11:49PM +0800, Kefeng Wang wrote: > Since commit 9420f89db2dd ("mm: move most of core MM initialization > to mm/mm_init.c"), mirrored_kernelcore should be moved into mm_init.c, > as most related codes are already there. > > Signed-off-by: Kefeng Wang Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 2 ++ > mm/page_alloc.c | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 7f7f9c677854..da162b7a044c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -259,6 +259,8 @@ static int __init cmdline_parse_core(char *p, unsigned long *core, > return 0; > } > > +bool mirrored_kernelcore __initdata_memblock; > + > /* > * kernelcore=size sets the amount of memory for use for allocations that > * cannot be reclaimed or migrated. > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index af9c995d3c1e..d1086aeca8f2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -374,8 +373,6 @@ int user_min_free_kbytes = -1; > int watermark_boost_factor __read_mostly = 15000; > int watermark_scale_factor = 10; > > -bool mirrored_kernelcore __initdata_memblock; > - > /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */ > int movable_zone; > EXPORT_SYMBOL(movable_zone); > -- > 2.35.3 >