From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98129C77B7C for ; Tue, 9 May 2023 16:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E9DD6B0071; Tue, 9 May 2023 12:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19A436B0072; Tue, 9 May 2023 12:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 089226B0074; Tue, 9 May 2023 12:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ED5B86B0071 for ; Tue, 9 May 2023 12:38:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C6FAC1C73CE for ; Tue, 9 May 2023 16:38:44 +0000 (UTC) X-FDA: 80771275368.20.38853A3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id E6053100005 for ; Tue, 9 May 2023 16:38:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tYIPeqQC; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683650322; a=rsa-sha256; cv=none; b=lGXquNhiCbzYGKtyy/ye5HPdpQbrKf7mpfsGdTmkzSR3XIcipZ/M9idviFDwhD0Ny0bNKF 0fUHq3m9mfhACuvznFeJ5z4w8aSqupTWBHk99Gqne2nfNj7MN915F34b96+wYD2R5aRhit Q/dddTAfC9ILskj9fWql0oGCNzrILQY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tYIPeqQC; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683650322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BE1xb7fC4l64NOr1S0HyOfWso1NssMyz/oa1oYVRO3M=; b=EDucHXP5HJC8pUmkl58FppnUpoTaP9MPcXFZFi0BmJw83p0p5nXLAoG58z4MX8PkDVIQgP /aJ1XMAi/6m4eZVpxTF9dvic4iABtktUQG8ZZakfuoOtZBon58WAAK9ij6624/w93rwImt bD5vpvx7+kz1n1BQXRwithySPmwei9E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F1DD62974; Tue, 9 May 2023 16:38:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96F06C433EF; Tue, 9 May 2023 16:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683650319; bh=rUhrsUno5UKglRVnTSvs0i9Sqtx8GYNijNMIbG+2KZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tYIPeqQC8eQvgj6sCmgYFlKvVU6IQn7QeOxFA9EZLH8Ca9JeyfzS3jJYSHpl0E2cB IGhCIX4JkIE0U4UuqU2X6H4fWUyoTbGywdal+kK8GjhTaTFdjo95GKyqAKvabQ2YQg xMA0+dIoolZQO3aV5XT56GGpHKROYtxiBrDM4e8ammq4rLfCHkrnP8yov9HUA+BVEi i2Wl6nOfRzjcPXiGqqlF4Eb9jfRwJm4jAaQuvjU1JKkLrdW8z5pHILDQWrmnp5A3I2 FfNU50o3L6Q6Y397uv/s87GErb4jxeb15+6pqneInPDZNqxrEpfoMLbNUupGtZxWmW 8kyikRGNNay8g== Date: Tue, 9 May 2023 09:38:37 -0700 From: Mike Rapoport To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 02/12] mm: page_alloc: move init_on_alloc/free() into mm_init.c Message-ID: <20230509163837.GA4135@kernel.org> References: <20230508071200.123962-1-wangkefeng.wang@huawei.com> <20230508071200.123962-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508071200.123962-3-wangkefeng.wang@huawei.com> X-Rspam-User: X-Stat-Signature: is9wktj5iqt19m3kkbaai3qfbt6gufzq X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E6053100005 X-HE-Tag: 1683650321-720714 X-HE-Meta: U2FsdGVkX18GJ/hX5OBPYVIEUEWKSFZRrZjWcNxdIjSC3bP8zjVvETJWZ2YVWdnY2e80w3Mv1jVc4lI6PcuecSogCGQ6tKn5E97hLi+xMrj6W2UJx5pUV9nNbuvqqO9eiCHLEfTgcJmn1Qf51XrKr8lr8hwXkNg2FqdrmLsgWYs/OYmYp1/3R3J6Oz/gfdsXJkNi9DsIM5XdExmZjhPAwEExwnOtz2/PQ36fQa25RwMmhbwoD2wrBiFMNRnKhpQm06qAQEyscMbiBmtphBVopUJBoiuK+0RwZqSmoUgKTryC8YlXdom2/+pY/8JJN2wqsvDSHua17AxkFdfbW/st0VmmzEr+SIw/RoiLEft0yYKfc73K3qNokujcBy3DK3PC3T+OxIm7CjOrGkMeWJJ8GztBC571Vb3oZaO4wgxxFvf7hao+nr+dFYFMH/CqqO6Rv+LMYQFgWYH9Xz1/j3r5aKy18GCsjNxH9ev9x0oXlPGlzBg/UMbnAliN5YkEtMssW2p8AByKXp2XSm9LVOeHNw1OFSjxIwH39dVrFg1YXHVWthBqOosNsmMzq9zpQsh0hSod3q1hUGKnR0e+WZhvHTqBlVC7vr2vcXKZc0+8CxtaI5aObWIYLDtNI8uyD99irCaPT79GLVsGwrUEfPNz32pIaWnXFgP1RfHHjdjvEflXHEFSrqV1S2wv+iAwLfIhX+AxMmX2CjScHQxTrA4YyPQ071Do6M7D6KnoQtayDD0xaf4Lc3DDWBWEkiM0nbpuh5RlFR34y30lz/kQxp7FWoWLntMyh3//5b/d8WYFzmMMrlrE0K3yYP53jRbTfCAITAlmf6IXp/s3ANWFWuqan4UVfv/Up1bECUSEQYa1jPhE05qmJDgQ2eDWueMx3oeHtA3SyNMLE1Op/JcwtH9xQAtBERR9rXHH+nCuvVLThy5w98Ve5gM5QUxu08cvb0cxu/alkk0l9IUdqMmkvEK FsUb4J3P s/edzl2+ACFoh2AG+VqJcoRhcnftSK08oFkvTrOtc9NBHniX2eUZ2OfYLjrP3050AuRuih50gmjV1xYcm3QEEE00gqYbmFEh9y/bEqeQ0HZ0SIxGyst3nuMMdRKnSZFpzHH75kPOxQ6xbkONLiYfMkRrgTjn60IT3GrEKP6nHAJ/XAPj0NLhG5oRMjzyGBq3heZ4iKBtVjid6wOaRv9xIKu2t3QMtgNEMm0zuUCq+PxkJClI0K+WcR6PY0vZ7xMdYHuInG0z+GSa54w8tK37KM1Un2ntOywB33wUKigbBSxF2ClryeTNOvQJrCVqW3uUr3c3f0KW5jVGSPWv1M98H0SIgI6xL3dlqCE+RwE0lkPSWZN7EFNuqzbVfpCK9OG66u5kS40NZM8yJLax8fgR7JILgYfkIqhi5xWmY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 08, 2023 at 03:11:50PM +0800, Kefeng Wang wrote: > Since commit f2fc4b44ec2b ("mm: move init_mem_debugging_and_hardening() > to mm/mm_init.c"), the init_on_alloc() and init_on_free() define is > better to move there too. > > Signed-off-by: Kefeng Wang Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 6 ++++++ > mm/page_alloc.c | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index da162b7a044c..15201887f8e0 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2543,6 +2543,12 @@ void __init memblock_free_pages(struct page *page, unsigned long pfn, > __free_pages_core(page, order); > } > > +DEFINE_STATIC_KEY_MAYBE(CONFIG_INIT_ON_ALLOC_DEFAULT_ON, init_on_alloc); > +EXPORT_SYMBOL(init_on_alloc); > + > +DEFINE_STATIC_KEY_MAYBE(CONFIG_INIT_ON_FREE_DEFAULT_ON, init_on_free); > +EXPORT_SYMBOL(init_on_free); > + > static bool _init_on_alloc_enabled_early __read_mostly > = IS_ENABLED(CONFIG_INIT_ON_ALLOC_DEFAULT_ON); > static int __init early_init_on_alloc(char *buf) > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d1086aeca8f2..4f094ba7c8fb 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -233,11 +233,6 @@ unsigned long totalcma_pages __read_mostly; > > int percpu_pagelist_high_fraction; > gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK; > -DEFINE_STATIC_KEY_MAYBE(CONFIG_INIT_ON_ALLOC_DEFAULT_ON, init_on_alloc); > -EXPORT_SYMBOL(init_on_alloc); > - > -DEFINE_STATIC_KEY_MAYBE(CONFIG_INIT_ON_FREE_DEFAULT_ON, init_on_free); > -EXPORT_SYMBOL(init_on_free); > > /* > * A cached value of the page's pageblock's migratetype, used when the page is > -- > 2.35.3 >