From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197E4C77B7F for ; Tue, 9 May 2023 00:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 520456B009C; Mon, 8 May 2023 20:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D0616B009D; Mon, 8 May 2023 20:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 370E2280001; Mon, 8 May 2023 20:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 26C0B6B009C for ; Mon, 8 May 2023 20:56:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7A68A0895 for ; Tue, 9 May 2023 00:56:42 +0000 (UTC) X-FDA: 80768901444.06.F0342C6 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf05.hostedemail.com (Postfix) with ESMTP id 8265D100003 for ; Tue, 9 May 2023 00:56:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="s EeEvU6"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="g/w0UhmN"; spf=pass (imf05.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.26 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683593800; a=rsa-sha256; cv=none; b=Kta5zhAiFcfyaYfwunr3VCQWS+3xJq9y7kGlNnlfPn+/YMTYR4cRdQ6tQ5coF0KCET8iOI OZJ0+TmBNtwQM0EoMZYGCG/Qga9KLAzTlGPydu6iXdQ6Z0DvsEHU6ZT7In/62OeuMm4yG5 3tbE8wk7xum+VJQe5BlM6geLABbcMzo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="s EeEvU6"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="g/w0UhmN"; spf=pass (imf05.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.26 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683593800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R0MvdCJrAGQ3Lx601BQioOuJmlf2hwwfSdhcLcNWO5Q=; b=BnXu/hUKhfqd3+b8EV9EOS5xXr9zoAlrDk2AfxCnjU+2oPyXqohYJHZCeOKDIPs5xuqW8o z/pJ59Y+KVS3GIWhlVUmN1Zp421+rnWkBwzsURKHUzPNpU61BU7zI8iGLw6pSwUguDShBT TtBWXAstnWNXx5LusyAVVVmDLovlaMo= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B99285C01AA; Mon, 8 May 2023 20:56:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 08 May 2023 20:56:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1683593799; x= 1683680199; bh=R0MvdCJrAGQ3Lx601BQioOuJmlf2hwwfSdhcLcNWO5Q=; b=s EeEvU6yL9KcddveYTaG4jW49jAptZTFLlcgGM7rB5S79PZlLO/WT5o7kriEpPZzd jNxN9wQGt4jmdJV68b/Q05Oo2SOo3FR7UPK1aDOvrKntXqbxZK0lDqMESF3/usWx jOUFx5Po71d1NncnScZ4Ej9IICFrbIHIS1kDZfGs3NfC+fBLjFMr7MTyZJfaUzUg rnoA0HdA4znpZ+OCutRFCblzmWw+mMAWUe48qpFsypD4RpJiMUork6hZCnipfdiY 3Ekv9ZBusPtuovilI2BjnmY/Baer0aA815jHxR6WMaKoK/dYNOmUk1L0phbivXQF rxxhh+qu3aEvvQrEPRt2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683593799; x=1683680199; bh=R0MvdCJrAGQ3L x601BQioOuJmlf2hwwfSdhcLcNWO5Q=; b=g/w0UhmNd2dweHlXYwAIHgEQlefGr Cxa7kh+pkPfbpoHlavNypmWkCIYcGm84Zvr97hAOp/QvhNf4TS1h9I20ljSYthI2 9kzfxxrukjzZ3KbI31uDt4vsKyx7mI54LJP8ckq8DdyMNOMWMU56J11oBW4pjngs jgMvtWW1XVu4UE3u0WjzcLV/28ZVopNibtVTcJLzHdrCw3EZ1A0eczDyuKK9ooAK AJ1WxInDWqZKq0fV9vjzdmUWsRGoQK9L2wtTjxzDxJT+stcLSGx//Vj+r86znjZW hox7ObZSqiMDnSoiRD2//yLDTKf9gDvbRS0+WasRF/ol3RbI6vPaSpn/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefledgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeulefgteeukeeihfffveeukefhudehvdegvdeh lefhvdduffegheegffeifeelveenucffohhmrghinhepthhhihhnghhsrdhhmhenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhes shhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 May 2023 20:56:37 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 5E0AE10C40B; Tue, 9 May 2023 03:56:34 +0300 (+03) Date: Tue, 9 May 2023 03:56:34 +0300 From: "Kirill A. Shutemov" To: Ard Biesheuvel Cc: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv10 04/11] efi/x86: Implement support for unaccepted memory Message-ID: <20230509005634.qtuiodpirexbxu2k@box.shutemov.name> References: <20230507234618.18067-1-kirill.shutemov@linux.intel.com> <20230507234618.18067-5-kirill.shutemov@linux.intel.com> <20230508190043.ouauzbghn27khdy4@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8265D100003 X-Stat-Signature: o41kpmmc7yosffek4nrqa1xf5cqfur3z X-HE-Tag: 1683593800-673122 X-HE-Meta: U2FsdGVkX19MIp5AjbZPgoGagfwLvGVKdguIxSw9nDrvFzi9k/3zIN4It64R0CCvduekrkm8DsroqX4sdP3sTef9k62qN7aZNT5vEUvioVJYRTv0XEACSeYA4axPN+6xlfyL/W4HQ5JQ+XKvg9SmWhUIBKE3fqm/tVW/m0iRc7vI95jbZ1kdzVagBT8Kb21RAMN567yjwnNqMnmmRHRzjdeHpxqxyRGDVwm9Tn/hcBul3zvnnkR/ESmHYdcEifcfom0XTWP8+8eqPxxrjvWmFJpb79F4Tv7uzYh596jN2bBIJEas19eplHiuD95Q8hxNrklJhMSlSpOimmRGqaJEwcnpkbbFf5PLInFszHqE5LyaWFnUW+SBWGzTFvw78OCLW8c7BehZZMvRRY1G3O3+Ox3IoR9S3Ijt/F77+P/7IN0fjGNU/5+iDVi59C7zgiLhFtI/NqK95wYI6BRN9w67aVZuR4+WHj7qJNzq7VeccwIElkNrGZZAoHgYzvPoGfPnLrH3Mbwju1EDplUsrdpRGAhE6NopU8ac3NM3BE6LFfrYcTP5TeV3p/vgKqVHCWW/7RJUdyHqtfw7nEsnpB9H4xZJZRfN1DDlS7MAPrmn+kKcXz5ZXSVCJH8Zbh1PHqBnxuX9o/e+0EeBss0klbkNpITmJgffObC27EMVTrT9E877fCtdy3xvSytijlz/8QS9QdwKmDMOzE4V37QiqRqDKUYatA9hhvdx+9+oAhGE1EdIHdB+YDl1QASAsWa2N+ayn5mJMSc2uFaj5LrGKGUwX3ZJ5U2ZLgCUcLBSdoeM4VBZqEc81pXnVV8Mrp7IOQ02+sWYpgAcBuhYAOxatcWJVWkGlhBeGd/Lj0NtROWgSGmxhuP179pqcdGnjIYdvs8ISY0mDLtytuLF2giHKbV702e9f1zRGGGgj9T+SIWVMV0ZJO4KBTHOIBdGmj7d/UZ8L3l/7eMGpa1sS25+uI9 Xh/BwEbc YsWGxy/qzb50+oyF/2anyQlKZeCSX8unMpZ8SGsDFYN+axQ1n2huy849jWdNp00E3FC2cy2ycLVtVPM3dDSitOxlBdF/p69ETdCGGKNhyH7ICeBOjyR+iz28N4uxm07qtunyi6hS2mjhagFBsotlivJ/ZauJ7Yhzg/2zWjpC67sPJofeGc6gG4TbMv23DYqIo3RsKs5iAPYsfiOs+QFRQWsW2a2dMiFu7IOX01GIjBbQIWIK3imIDLBCv/16qrStWGNS/5w40I9sKQvmNRcC1AeyCOKkSZVfFARqOYdp8niXAjnc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 12:11:41AM +0200, Ard Biesheuvel wrote: > > @@ -1324,13 +1325,15 @@ void __init e820__memblock_setup(void) > > * e820_table is not finalized and e820__end_of_ram_pfn() cannot be > > * used to get correct RAM size. > > */ > > - if (boot_params.unaccepted_memory) { > > + if (efi.unaccepted != EFI_INVALID_TABLE_ADDR) { > > + struct efi_unaccepted_memory *unaccepted; > > unsigned long size; > > > > - /* One bit per 2MB */ > > - size = DIV_ROUND_UP(e820__end_of_ram_pfn() * PAGE_SIZE, > > - PMD_SIZE * BITS_PER_BYTE); > > - memblock_reserve(boot_params.unaccepted_memory, size); > > + unaccepted = __va(efi.unaccepted); > > + > > + size = sizeof(struct efi_unaccepted_memory); > > + size += unaccepted->size; > > + memblock_reserve(efi.unaccepted, size); > > } > > > > This could be moved to generic code (but we'll need to use early_memremap()) I don't understand why early_memremap() is needed. EFI_LOADER_DATA already mapped into direct mapping. We only need to reserve the memory so it could not be reallocated for other things. Hm? -- Kiryl Shutsemau / Kirill A. Shutemov