From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07427C77B73 for ; Sat, 6 May 2023 17:41:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FD626B0072; Sat, 6 May 2023 13:41:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ABF06B0078; Sat, 6 May 2023 13:41:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69B426B007B; Sat, 6 May 2023 13:41:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5A1806B0072 for ; Sat, 6 May 2023 13:41:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2C2DDADA04 for ; Sat, 6 May 2023 17:41:28 +0000 (UTC) X-FDA: 80760547056.15.F07E0A1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 6560940002 for ; Sat, 6 May 2023 17:41:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wsLd1C5H; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683394885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TCXAY75tMADx0lP/1BTmueIYGF9bV2HWzYizyxQvp4Y=; b=z5jxATjPXWfdnTCrWHctSc1mUi9qiHq2D8OnQnBVNsvx6QWYkeltN8H5ux1QXuLUujDMoh pCE/fAhPd9/3NdtlF7FILSTf+TEB+dv4wlwVCzVHO0I9afnUzTDGezBahyFQHey8S6TmQc SYLLYvyvA/feDAhvpg9LAwsOJRfBP1c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wsLd1C5H; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683394885; a=rsa-sha256; cv=none; b=BfZxZ2SE7sF4TQU7HPCSD6S5ORvSsQ4AnmLU3mvbk3vMFCAv129T7gtqM0EuZbCTDGF2pJ 7AkzF64XVNcBx5/aEvlywiwRNMHOqD141xwcnU8KkV8+Zs+fJzgMPhalcSRKxhHhhSc+I4 z+DcwcnIvgPolk9Z0FHinxl486Q3EQM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41D2B60AEB; Sat, 6 May 2023 17:41:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58CAFC433EF; Sat, 6 May 2023 17:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683394883; bh=uCjhesLcsunAx7s5aod9XiUZ78Nv1oXq2yenr1NvgEE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wsLd1C5HlxgIIVmt4ASrhpcTtCrMHOWkZ7A5kZGgmXequPskUYr5NMOdrSKTiQiXs j0Tt+d8KgWhYrFW5L7vt4X6YlrppLBG00FWLvx+DG3AZr6N8Em6rAgx7edTgnKz9Mp x79j6kLny7YolS9/hayAtU9joGsetEU+1u4BwI8E= Date: Sat, 6 May 2023 10:41:22 -0700 From: Andrew Morton To: Linus Torvalds Cc: "Matthew Wilcox (Oracle)" , Josef Bacik , Johannes Weiner , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Dan Carpenter , syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com, Christoph Hellwig Subject: Re: [PATCH] filemap: Handle error return from __filemap_get_folio() Message-Id: <20230506104122.e9ab27f59fd3d8294cb1356d@linux-foundation.org> In-Reply-To: References: <20230506160415.2992089-1-willy@infradead.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4bnkbstuzebb86m8emhqwiuw8oqpqzm4 X-Rspam-User: X-Rspamd-Queue-Id: 6560940002 X-Rspamd-Server: rspam07 X-HE-Tag: 1683394885-490982 X-HE-Meta: U2FsdGVkX1/IsJZL1dyKkRp6puCi1dLO9+097y0WJThlriZaXzG/iYR6HlkYfdz24qs7Kj5kEkxLcZK68XmUPQFZOfHlSH37nmd4BzQH3N9ECk6HBC9JHyD/WygWebs6x+txAcaPvP1OUSkuGaDyPBjmMey+zUwEt+t73COmKDJ/YmaoC3CgvsVpDK5oGd6VGNxIifRHHm8gV14Iz2LG5STLhAtR6BnHIInOyOHiAsbCP+ZT8xdNiasHOI68NS6qQ68R2ehTXJwLB7Fb+JXVrhLDYqbin2wp2c+gcQyNLxk9AkgHjPenf8ws75TduEOZGtLRzRTaAcBKlpK0kKaQOoxsRKxk7bAQF8MKDOyLBvnnSO0vZrbenh/FB2D/cTtAOF3meWpPL4e3fOiGCYmfecDx8XdPsYUOXkolMzxIV5ihRCSvypEfK7dfZRdZj2b1WeJhfiKRP0ZbRoxA6fr5GYANQFfMs2c8QIFd0kE4ngS5imSpKd7cIt1ccteGK/nmSNix2JzXcV7QO13kkkLLlqUZlRSjuTeIEEpB9sjavFxmXYBBGJ2peHMnyu/tw8I0rRj/ArLJrcDP1p/I0r6pS0AGFVeJIW8HhOoNg5qNI9LtKBJ902OryJoJnHBfVzTsKjl564j3j/LydqPrQ5NOPdj5L3f3/N7/VuG6MXQS5wjKlBk/fdkZ/kfW9zAfTj46vtAz1rDcG9SZG0RB7nu8ouh7m8oz3cIQpu2uGlx+9Dzm4Z+VpV7Hqiv/OhpVQCdwOxLP2v4uzWYOK2sGX5RXhmg5yEy7cLHmU9ztKv/QkuNTKbyrhWl/emFRYEE0t41rqSeea3nDxq9uhVWx58T9Hhp6r7CUeoakbXKNouaELR7vxI/64LZmrW96y0ffInl1ohddCkynMNcBoPKYFbcmg56p3GfYQXboHNxzhjXWYHytQOsx94JDvunkrCTfZDvqy3p4SwV2pM+G4WmHdfp lZF7Qi1Q H5oVCTlx277ltjH+QEt1+Q0P934sMRPv9UyZUVjGv4aO2Nmb4RI8cGVEJwe+aNtTly4P+BylR4gx/yIc9MUwAyVIuccACTmNsm1Q8ff9uodMvcutBODfreBht5vxrxFHHnPvs865i+/Khq1Nj+Cfym9TYcNwsKUlGsQvErRu2m6nW4Jzs3M8snAqffMHaXZ3ttC71lFkNaPwjkaP59lAOlSO4BlxrYHtyg5dUFP1V+PBQOVw/YUhgPoAwsufeYl7FezPjL6F7wQPViLRhm9d38bYeU6Jn9sFLyazSZgHxmGwgyaqWVBFUCBqFSeuakgXDjdBrc0sqs/fX/y7yexMEXUBg6ToZufz19ScJvi66nQrHiEbp7TplIT1qpwULkxKWE2KR7UgJP8OogDEeGZ4Y4yJmvq7w01m6en8iHoIzlE6kjQlSJQgiRuIc3WmyvQr4qIHdVPaoAd/7WhZT+JohOx8nbmBbDg4pxtQm9HQLV8MvQQBZNFjD5DQcNXZc7Ua9HFibcViWiTihCpCZRX0rcDQ8qcjwznCKP3w37bB272iILzbXB1bSZFlPYQTgOsJEUnoq44d3Q03+0LpMp8Bf+k/zI5KJ6LUpjwyVNR24TIkfwXarpIPG4VXC23X/G2sVpRVQcPn1T3WPgjn3pNBFn/Rn0vsW5FpGEWuTVyYRrRv6Zf3IR4EF7SZH2eKw8+XaYWrQH2utIRsWszBk1fPlyZbHpEkUXEPAmUAJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 6 May 2023 10:34:31 -0700 Linus Torvalds wrote: > On Sat, May 6, 2023 at 10:10 AM Linus Torvalds > wrote: > > > > .. in the meantime, I did end up applying your patch. > > Final (?) note on this: I not only applied your patch, but went > looking for any other missed cases. > > And found one in fs/nfs/dir.c, which like ext4 had grown a new use of > __filemap_get_folio(). > > But unlike ext4 it hadn't been caught in linux-next (or I had just > missed it) and so I hadn't caught it in my merge either. > > I hope that's the last one. > > I grepped for all these __filemap_get_folio() cases when I did the MM > merge that brought in that change (and did the ext4 merge fixup), but > then the nfs pull happened later and I didn't think to check for new > cases... > > A current grep seems to say that it's all good. But we had all missed > the second check in filemap_fault(), so... > We have a related afs fix which I plan to send over later today: From: Christoph Hellwig Subject: afs: fix the afs_dir_get_folio return value Date: Wed, 3 May 2023 17:45:26 +0200 Keep returning NULL on failure instead of letting an ERR_PTR escape to callers that don't expect it. Link: https://lkml.kernel.org/r/20230503154526.1223095-2-hch@lst.de Fixes: 66dabbb65d67 ("mm: return an ERR_PTR from __filemap_get_folio") Signed-off-by: Christoph Hellwig Reported-by: Jan Kara Reviewed-by: Jan Kara Reviewed-by: David Howells Tested-by: David Howells Cc: Marc Dionne Cc: Matthew Wilcox Signed-off-by: Andrew Morton --- fs/afs/dir_edit.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/fs/afs/dir_edit.c~afs-fix-the-afs_dir_get_folio-return-value +++ a/fs/afs/dir_edit.c @@ -115,11 +115,12 @@ static struct folio *afs_dir_get_folio(s folio = __filemap_get_folio(mapping, index, FGP_LOCK | FGP_ACCESSED | FGP_CREAT, mapping->gfp_mask); - if (IS_ERR(folio)) + if (IS_ERR(folio)) { clear_bit(AFS_VNODE_DIR_VALID, &vnode->flags); - else if (folio && !folio_test_private(folio)) + return NULL; + } + if (!folio_test_private(folio)) folio_attach_private(folio, (void *)1); - return folio; } _