From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619D3C77B7C for ; Sat, 6 May 2023 02:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 900276B007B; Fri, 5 May 2023 22:42:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B13D6B007D; Fri, 5 May 2023 22:42:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79F206B007E; Fri, 5 May 2023 22:42:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by kanga.kvack.org (Postfix) with ESMTP id 5EDBE6B007B for ; Fri, 5 May 2023 22:42:41 -0400 (EDT) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-24e3a0aa408so2255103a91.1 for ; Fri, 05 May 2023 19:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683340960; x=1685932960; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IXa2WM+Ux0ryWdk9v/juQWn6Ta5HKrRkFJpku8aKUgk=; b=Fo5KIb/ybvy6rjlKOBOEZWQrtygKZ6pR2WFuAgcmSwR3uXcZ8W9DY3wD2C+RZnRG+c HuNjUIYg7lEZfX3o+fPgIJXm97dKnc0fnFz8QCEVogqv1d8MEVm8DSpNS4IWCXwtL7JK l/aNzYgIqDRF0xmVBJcjCCj9AHSwM/VamsvPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683340960; x=1685932960; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IXa2WM+Ux0ryWdk9v/juQWn6Ta5HKrRkFJpku8aKUgk=; b=jX1jbSH4ONrZ/sYkPT9wLzMphFC7NcSAY5+s/0x7wDuWAji4fOUReZ+RkIyY6kEUmO ET3F75Jr+7Y2oW1WKH/7ouVljNBqqhWS1e+VXB2hRIvys0/7Lo/XnwrX/HXnVxSwF3XK lfxihT2rjvyiKI+0QWB6WG+Uj7x5tyKfBZDCubrPHIgBd+jUVdCQIwtp7S2hnBcgWWrZ //T0Tb8XF9qxF4licJ2BFIwz8JVzkls7q/NyiAgkFSSZWXL9klzRYTF1J2/WZMwywqiN Q/gTPFfjpJQ9fP2nww/6I1h9skSRTobjYLpqxthSyq/7ZFxEw1CE7k+oATGHPGR+JKu5 Kk1Q== X-Gm-Message-State: AC+VfDye+upXAigYSGxjPmitSKu59ajzvquKctDQnNj5Xf2yzNS0LMu6 4RnB4wfywUJPrJ2/EnyrI/OafA== X-Google-Smtp-Source: ACHHUZ5xJN8/SU9MRkAVlp117mlbDCf+WBPkOF66GWTYbp3rJ87qYpAVbZ4o5Zcxc0K585Bxj/h2Ng== X-Received: by 2002:a17:90b:190f:b0:24e:16ae:61ca with SMTP id mp15-20020a17090b190f00b0024e16ae61camr3441776pjb.34.1683340960500; Fri, 05 May 2023 19:42:40 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id v5-20020a17090a7c0500b0024e4f169931sm5530319pjf.2.2023.05.05.19.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 19:42:39 -0700 (PDT) Date: Sat, 6 May 2023 11:42:35 +0900 From: Sergey Senozhatsky To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v2 18/36] mm: Update vma_iter_store() to use MAS_WARN_ON() Message-ID: <20230506024235.GA3281499@google.com> References: <20230505174204.2665599-1-Liam.Howlett@oracle.com> <20230505174204.2665599-19-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505174204.2665599-19-Liam.Howlett@oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/05/05 13:41), Liam R. Howlett wrote: > MAS_WARN_ON() will provide more information on the maple state and can > be more useful for debugging. Use this version of WARN_ON() in the > debugging code when storing to the tree. > > Update the printk to a pr_warn(), but this will only be printed when > maple tree debug is enabled anyways. > > Making all print statements into one will keep them together on a busy > terminal. > > Cc: Sergey Senozhatsky > Signed-off-by: Liam R. Howlett Reviewed-by: Sergey Senozhatsky