linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH v2 16/36] maple_tree: Make test code work without debug enabled
Date: Fri,  5 May 2023 13:41:44 -0400	[thread overview]
Message-ID: <20230505174204.2665599-17-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20230505174204.2665599-1-Liam.Howlett@oracle.com>

The test code is less useful without debug, but can still do general
validations.  Define mt_dump(), mas_dump() and mas_wr_dump() as a noop
if debug is not enabled and document it in the test module information
that more information can be obtained with another kernel config option.

MT_BUG_ON() will report a failures without tree dumps, and the output
will be less useful.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/Kconfig.debug                | 10 +++++++---
 lib/test_maple_tree.c            | 27 ++++++++++++++++++++++++---
 tools/testing/radix-tree/maple.c |  1 -
 3 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index be272aa2fc0a4..17ba96a3c7bfe 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2293,9 +2293,13 @@ config TEST_XARRAY
 	tristate "Test the XArray code at runtime"
 
 config TEST_MAPLE_TREE
-	depends on DEBUG_KERNEL
-	select DEBUG_MAPLE_TREE
-	tristate "Test the Maple Tree code at runtime"
+	tristate "Test the Maple Tree code at runtime or module load"
+	help
+	  Enable this option to test the maple tree code functions at boot, or
+	  when the module is loaded. Enable "Debug Maple Trees" will enable
+	  more verbose output on failures.
+
+	  If unsure, say N.
 
 config TEST_RHASHTABLE
 	tristate "Perform selftest on resizable hash table"
diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
index d6929270dd36a..93b40a78c4f55 100644
--- a/lib/test_maple_tree.c
+++ b/lib/test_maple_tree.c
@@ -11,12 +11,33 @@
 #include <linux/module.h>
 
 #define MTREE_ALLOC_MAX 0x2000000000000Ul
-#ifndef CONFIG_DEBUG_MAPLE_TREE
-#define CONFIG_DEBUG_MAPLE_TREE
-#endif
 #define CONFIG_MAPLE_SEARCH
 #define MAPLE_32BIT (MAPLE_NODE_SLOTS > 31)
 
+#ifndef CONFIG_DEBUG_MAPLE_TREE
+#define mt_dump(mt, fmt)		do {} while (0)
+#define mt_validate(mt)			do {} while (0)
+#define mt_cache_shrink()		do {} while (0)
+#define mas_dump(mas)			do {} while (0)
+#define mas_wr_dump(mas)		do {} while (0)
+atomic_t maple_tree_tests_run;
+atomic_t maple_tree_tests_passed;
+#undef MT_BUG_ON
+
+#define MT_BUG_ON(__tree, __x) do {					\
+	atomic_inc(&maple_tree_tests_run);				\
+	if (__x) {							\
+		pr_info("BUG at %s:%d (%u)\n",				\
+		__func__, __LINE__, __x);				\
+		pr_info("Pass: %u Run:%u\n",				\
+			atomic_read(&maple_tree_tests_passed),		\
+			atomic_read(&maple_tree_tests_run));		\
+	} else {							\
+		atomic_inc(&maple_tree_tests_passed);			\
+	}								\
+} while (0)
+#endif
+
 /* #define BENCH_SLOT_STORE */
 /* #define BENCH_NODE_STORE */
 /* #define BENCH_AWALK */
diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
index ebcb3faf85ea9..cf37ed9ab6c4d 100644
--- a/tools/testing/radix-tree/maple.c
+++ b/tools/testing/radix-tree/maple.c
@@ -22,7 +22,6 @@
 #define dump_stack()	assert(0)
 
 #include "../../../lib/maple_tree.c"
-#undef CONFIG_DEBUG_MAPLE_TREE
 #include "../../../lib/test_maple_tree.c"
 
 #define RCU_RANGE_COUNT 1000
-- 
2.39.2


  parent reply	other threads:[~2023-05-05 17:44 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 17:41 [PATCH v2 00/36] Maple tree mas_{next,prev}_range() and cleanup Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 01/36] maple_tree: Fix static analyser cppcheck issue Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 02/36] maple_tree: Clean up mas_parent_enum() and rename to mas_parent_type() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 03/36] maple_tree: Avoid unnecessary ascending Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 04/36] maple_tree: Clean up mas_dfs_postorder() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 05/36] maple_tree: Add format option to mt_dump() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 06/36] maple_tree: Add debug BUG_ON and WARN_ON variants Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 07/36] maple_tree: Convert BUG_ON() to MT_BUG_ON() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 08/36] maple_tree: Change RCU checks to WARN_ON() instead of BUG_ON() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 09/36] maple_tree: Convert debug code to use MT_WARN_ON() and MAS_WARN_ON() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 10/36] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 11/36] maple_tree: Use MAS_BUG_ON() in mas_set_height() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 12/36] maple_tree: Use MAS_BUG_ON() from mas_topiary_range() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 13/36] maple_tree: Use MAS_WR_BUG_ON() in mas_store_prealloc() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 14/36] maple_tree: Use MAS_BUG_ON() prior to calling mas_meta_gap() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 15/36] maple_tree: Return error on mte_pivots() out of range Liam R. Howlett
2023-05-05 17:41 ` Liam R. Howlett [this message]
2023-05-05 17:41 ` [PATCH v2 17/36] mm: Update validate_mm() to use vma iterator Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 18/36] mm: Update vma_iter_store() to use MAS_WARN_ON() Liam R. Howlett
2023-05-06  2:42   ` Sergey Senozhatsky
2023-05-06  2:47   ` Sergey Senozhatsky
2023-05-05 17:41 ` [PATCH v2 19/36] maple_tree: Add __init and __exit to test module Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 20/36] maple_tree: Remove unnecessary check from mas_destroy() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 21/36] maple_tree: mas_start() reset depth on dead node Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 22/36] mm/mmap: Change do_vmi_align_munmap() for maple tree iterator changes Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 23/36] maple_tree: Try harder to keep active node after mas_next() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 24/36] maple_tree: Try harder to keep active node with mas_prev() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 25/36] maple_tree: Revise limit checks in mas_empty_area{_rev}() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 26/36] maple_tree: Fix testing mas_empty_area() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 27/36] maple_tree: Introduce mas_next_slot() interface Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 28/36] maple_tree: Add mas_next_range() and mas_find_range() interfaces Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 29/36] maple_tree: Relocate mas_rewalk() and mas_rewalk_if_dead() Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 30/36] maple_tree: Introduce mas_prev_slot() interface Liam R. Howlett
2023-05-05 17:41 ` [PATCH v2 31/36] maple_tree: Add mas_prev_range() and mas_find_range_rev interface Liam R. Howlett
2023-05-08 13:26   ` Vernon Yang
2023-05-08 16:11     ` Liam R. Howlett
2023-05-05 17:42 ` [PATCH v2 32/36] maple_tree: Clear up index and last setting in single entry tree Liam R. Howlett
2023-05-09 12:39   ` Peng Zhang
2023-05-12 15:54     ` Liam R. Howlett
2023-05-12 17:29       ` Liam R. Howlett
2023-05-05 17:42 ` [PATCH v2 33/36] maple_tree: Update testing code for mas_{next,prev,walk} Liam R. Howlett
2023-05-05 17:42 ` [PATCH v2 34/36] mm: Add vma_iter_{next,prev}_range() to vma iterator Liam R. Howlett
2023-05-05 17:42 ` [PATCH v2 35/36] mm: Avoid rewalk in mmap_region Liam R. Howlett
2023-05-05 17:42 ` [PATCH v2 36/36] maple_tree: Add gap to check_alloc_rev_range() testcase Liam R. Howlett
2023-05-05 19:29   ` Liam R. Howlett
2023-05-05 19:57     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505174204.2665599-17-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox