From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AD1C77B7D for ; Fri, 5 May 2023 20:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741046B0072; Fri, 5 May 2023 16:34:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0F26B0078; Fri, 5 May 2023 16:34:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62E8A6B007B; Fri, 5 May 2023 16:34:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by kanga.kvack.org (Postfix) with ESMTP id 4F5DB6B0072 for ; Fri, 5 May 2023 16:34:28 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DAD0B61539; Fri, 5 May 2023 20:34:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0106CC433D2; Fri, 5 May 2023 20:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683318867; bh=AFT7knrEPhLEA6RJfSbjIHYPUd6cKJPFX4vMnUj8HPQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m8xSlKCb794at+pDA2CJBWf1z89M4bzl/yxif1iN1rRFavvCkd6CIBqS4Wfs3CHVb ckNOj9uS/IU0bXbDQcGVI6Jvd7Rs8eVaITk8flI7trvTNMMSCWFTfmIl4/QmQkKdp6 ON1+OmL2ISBXHNuSKDUwopFfdyHqMO72iG7BniTo= Date: Fri, 5 May 2023 13:34:26 -0700 From: Andrew Morton To: Geert Uytterhoeven Cc: Nhat Pham , hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, linux-api@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v13 2/3] cachestat: implement cachestat syscall Message-Id: <20230505133426.d70a6599d9a729496b68a70c@linux-foundation.org> In-Reply-To: References: <20230503013608.2431726-1-nphamcs@gmail.com> <20230503013608.2431726-3-nphamcs@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 4 May 2023 19:26:11 +0200 Geert Uytterhoeven wrote: > > arch/x86/entry/syscalls/syscall_32.tbl | 1 + > > arch/x86/entry/syscalls/syscall_64.tbl | 1 + > > This should be wired up on each and every architecture. > Currently we're getting > > :1567:2: warning: #warning syscall cachestat not implemented [-Wcpp] > > in linux-next for all the missing architectures. Is that wise? We risk adding a syscall to an architecture without the arch maintainers and testers even knowing about it. The compile-time nag is there to inform the arch maintainers that a new syscall is available and that they should wire it up, run the selftest and then ship the code if they're happy with the result.