From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4053FC77B7D for ; Fri, 5 May 2023 19:14:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B06336B007B; Fri, 5 May 2023 15:14:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F9D6B007E; Fri, 5 May 2023 15:14:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 956B06B0080; Fri, 5 May 2023 15:14:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by kanga.kvack.org (Postfix) with ESMTP id 7DCDF6B007B for ; Fri, 5 May 2023 15:14:03 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14A306124F; Fri, 5 May 2023 19:14:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16A1CC433EF; Fri, 5 May 2023 19:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683314042; bh=4jYgePMhwPc9Dims/nrzw+Gr6MqL3fFrp9uR0NeldDU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GiVZFooZFKlm2eBJ0yl4stLGsdbaO2zL2nrnRdvEQs9gHL01jH8OQ6UAtGJgJwO9D 7tomHzm2P1nqxq4MS9PnfoFA9HbaCA+yeRynxD1pBTVwhekwj2TaStxdJ/mBFDqvRe VVsf7Eo5rFMN7rZwmoUdOwmQp8npdCzWp+hKnARg= Date: Fri, 5 May 2023 12:14:01 -0700 From: Andrew Morton To: Nhat Pham Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, kernel-team@meta.com Subject: Re: [PATCH] zsmalloc: move LRU update from zs_map_object() to zs_malloc() Message-Id: <20230505121401.31826e1251fb8792fe64f675@linux-foundation.org> In-Reply-To: <20230505185054.2417128-1-nphamcs@gmail.com> References: <20230505185054.2417128-1-nphamcs@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 5 May 2023 11:50:54 -0700 Nhat Pham wrote: > Under memory pressure, we sometimes observe the following crash: > > [ 5694.832838] ------------[ cut here ]------------ > [ 5694.842093] list_del corruption, ffff888014b6a448->next is LIST_POISON1 (dead000000000100) > > ... > > Suggested-by: Johannes Weiner > Acked-by: Johannes Weiner > Signed-off-by: Nhat Pham Am I correct in believing that we should backport this fix into earlier kernels? And that a suitable Fixes: target is 64f768c6b32e ("zsmalloc: add a LRU to zs_pool to keep track of zspages in LRU order)"?