From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156CBC77B7C for ; Fri, 5 May 2023 13:58:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E03C6B0075; Fri, 5 May 2023 09:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38FE26B0078; Fri, 5 May 2023 09:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A5A66B007B; Fri, 5 May 2023 09:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by kanga.kvack.org (Postfix) with ESMTP id 1B0526B0075 for ; Fri, 5 May 2023 09:58:10 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 514B163539; Fri, 5 May 2023 13:58:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2998EC433EF; Fri, 5 May 2023 13:58:07 +0000 (UTC) Date: Fri, 5 May 2023 09:58:05 -0400 From: Steven Rostedt To: Peter Collingbourne Cc: Marco Elver , andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Message-ID: <20230505095805.759153de@gandalf.local.home> In-Reply-To: References: <20230215143306.2d563215@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 1 May 2023 15:02:37 -0700 Peter Collingbourne wrote: > > > "ftrace" is really for just the function tracing, but CONFIG_FTRACE > > > really should just be for the function tracing infrastructure, and > > > perhaps not even include trace events :-/ But at the time it was > > > created, it was for all the "tracers" (this was added before trace > > > events). > > > > It would be great to see this cleaned up. I found this aspect of how > > tracing works rather confusing. > > > > So do you think it makes sense for the KASAN tests to "select TRACING" > > for now if the code depends on the trace event infrastructure? > > Any thoughts? It looks like someone else got tripped up by this: > https://reviews.llvm.org/D144057 Yeah, it really does need to get cleaned up, but unfortunately it's not going to be a trivial change. We need to make sure it's done in a way that an old .config still keeps the same things enabled with the new config settings. That takes some trickery in the dependency. I'll add this to my todo list, hopefully it doesn't fall into the abyss portion of that list :-p -- Steve