From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC2CC77B78 for ; Wed, 3 May 2023 15:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C3576B007B; Wed, 3 May 2023 11:22:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 473BC6B007E; Wed, 3 May 2023 11:22:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 362B86B0080; Wed, 3 May 2023 11:22:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by kanga.kvack.org (Postfix) with ESMTP id 181ED6B007B for ; Wed, 3 May 2023 11:22:38 -0400 (EDT) Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-74df951e897so223696385a.2 for ; Wed, 03 May 2023 08:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1683127357; x=1685719357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z72RIdKmaEAHhQSJvbUggUruDGfXxzyBpebhinUUrDk=; b=5re4CQifcjgd9jxTsVO9hmhw6XMxMZLnn+9npz6K1XjDCQ8FvkKJE3X6Yw4GkTPAGM FbvGtFkH/d+NJOWM3Q1x6nZoFb+jc+X8Taw5QBSs/hEhgEe+ZMp3MaxCwjyd40CQGqNw 4BSbRR9FgKVb4EOoP1w+l1ybPqbF97tlvZuF4TaFYkQL/CYHpgxlM6rgsnGHDzYuMMh/ p2+7dkbgEiMBIT2eGpcMqkT+SfAnDGxDaz8/+6M91ysZaSwycbmKeyYg6ZpkUy1Mg6Sw fcLO/8PJqzpX0w1KpblmJPgjHfSzQH/BAYHMESvYMfGj9F95/wfgCms82p8c6UwSNs3o 0P1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683127357; x=1685719357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z72RIdKmaEAHhQSJvbUggUruDGfXxzyBpebhinUUrDk=; b=QctzyFzwfN2t2+N6jWXj5lJ5ZUiIN+zUzlQaxbcYvTlMFTKEr5WxO67fWgbOZUDBx0 sDIaysKc7nKxhxowYNkKGjcEaqfy/1VXeHp8/ldQQ4WN7CIzTwE0cLHLiQXWHqvUnXNr cTnDI27ajlRLy4+jdRPlN6klwes1pdGrAOEZycTs2zOQBnBBidNaQcw09x8MkwFaz876 lZqLPJJ/gixNzJudKuOzW7Rao7zlRmwPYNgqMujYxRFfl/QeIlklWw6rdPn3lyqyGA0t +e7XS3lE0JnwTso7cI+neNtFjwL7ctz3NDUuJjaH+0uq3eWTfhQClnkgd2yctpIvIQPG D/ZA== X-Gm-Message-State: AC+VfDwxsZm8p4UsdXlg1Iwa0f/ildNbwhtHnEkkb2S4tCk7hEw8YvrG KMvh01h2IbMZ1urWNI8Jqf4GYA== X-Google-Smtp-Source: ACHHUZ6fGMSFqnaJplKEuCgOeeUB553kYejp5VFW8TunnY7roEmjKtyUeC1wrv92nnbOwFt/+39Z3w== X-Received: by 2002:ad4:5ba6:0:b0:5b9:3f17:b219 with SMTP id 6-20020ad45ba6000000b005b93f17b219mr9586749qvq.3.1683127357643; Wed, 03 May 2023 08:22:37 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id w8-20020a05620a444800b0074e026a6a43sm10732751qkp.9.2023.05.03.08.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 08:22:37 -0700 (PDT) Date: Wed, 3 May 2023 11:22:36 -0400 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, linux-api@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v13 3/3] selftests: Add selftests for cachestat Message-ID: <20230503152236.GD193380@cmpxchg.org> References: <20230503013608.2431726-1-nphamcs@gmail.com> <20230503013608.2431726-4-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230503013608.2431726-4-nphamcs@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 02, 2023 at 06:36:08PM -0700, Nhat Pham wrote: > Test cachestat on a newly created file, /dev/ files, and /proc/ files. > Also test on a shmem file (which can also be tested with huge pages > since tmpfs supports huge pages). > > Signed-off-by: Nhat Pham *and a directory Looks good to me. It covers a good set of real cases and weird cases. Acked-by: Johannes Weiner