From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE56C77B7F for ; Wed, 3 May 2023 21:06:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3580D6B0078; Wed, 3 May 2023 17:06:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3084C6B007B; Wed, 3 May 2023 17:06:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F69E6B007D; Wed, 3 May 2023 17:06:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by kanga.kvack.org (Postfix) with ESMTP id 0C7B36B0078 for ; Wed, 3 May 2023 17:06:12 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 56C1E62A71; Wed, 3 May 2023 21:06:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67A5BC433EF; Wed, 3 May 2023 21:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683147970; bh=BJaWoQEwi1nsRGaASt1366eU6W3XLddSBQxqT3JtCXM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DxuYsd9iiuRdr6p7QdaO8G+QMUAoci3OATTy+KDSrBag9t1Z9E/S2g29TRr9nQz8J 7z32VV9tA6DzSnMc8u4PNFwIoJahMxhtLeYBqtc69/E3tT0+JlyCz4SuOkPOsbrdv5 LfgKFUuKkAMpLvsqo7ktPKou0bea0oA9OJxzGV7c= Date: Wed, 3 May 2023 14:06:09 -0700 From: Andrew Morton To: Bagas Sanjaya Cc: Danila Chernetsov , Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Linux Memory Management , Konstantin Komarov , Christian Brauner Subject: Re: ntfs orphan? (was Re: [PATCH] ntfs: do not dereference a null ctx on error) Message-Id: <20230503140609.e65bdc2b0e55ba6f49bbb620@linux-foundation.org> In-Reply-To: References: <20230407194433.25659-1-listdansp@mail.ru> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 3 May 2023 11:16:02 +0700 Bagas Sanjaya wrote: > On Fri, Apr 07, 2023 at 07:44:33PM +0000, Danila Chernetsov wrote: > > In ntfs_mft_data_extend_allocation_nolock(), if an error condition occurs > > prior to 'ctx' being set to a non-NULL value, avoid dereferencing the NULL > > 'ctx' pointer in error handling. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Duplicate of 10-years-old outstanding patch at [1]. Well, the patches are actually quite different. Is Danila's longer one better? > I'm not speaking of the patch itself but rather on unfortunate state > of ntfs subsystem. It seems like the maintainer is MIA (has not > responding to patch submissions for a long time). Some trivial > patches, however, are merged through mm tree. > > Konstantin (from newer ntfs3 subsystem), Andrew, would you like to take a > look on this orphaned subsystem (and help reviewing)? I'd like to send > MAINTAINERS update if it turns out to be the case. > Sure, I can join linux-ntfs-dev@lists.sourceforge.net and hendle things which come along. Or Christian may want to do that? > > [1]: https://lore.kernel.org/all/1358389709-20561-1-git-send-email-nickolai@csail.mit.edu/