From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EF1C77B61 for ; Fri, 28 Apr 2023 14:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CA4B6B0071; Fri, 28 Apr 2023 10:16:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57A736B0072; Fri, 28 Apr 2023 10:16:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41AFB6B0074; Fri, 28 Apr 2023 10:16:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 32C6E6B0071 for ; Fri, 28 Apr 2023 10:16:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DE7FC801F6 for ; Fri, 28 Apr 2023 14:16:42 +0000 (UTC) X-FDA: 80731000644.14.E8FCC06 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf11.hostedemail.com (Postfix) with ESMTP id AD40C40013 for ; Fri, 28 Apr 2023 14:16:39 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dRrMVyLZ; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682691400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vrLTCdkw+EP7Dp2PoWtg4fMUuxmPjTrMyGpPQd9/5l8=; b=nQCmyBSv00d2eP5b1sdq6qhLhPBjyR7jfhhK2st6K4kZYgZYqRa1R4MOZRpp8vt9LjQsVo euPWYbuw49tdF2tnKZT4tofuFa6KwYXEkkMlavV+bpw72Cqmx9TpCJMOt47PUaXI3OZm6O l5BOZhKb67Ht2r0GU3ffaN7sGIJveDE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dRrMVyLZ; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682691400; a=rsa-sha256; cv=none; b=y1NeWjjeQndvziQj4Oqv5I+0BHdcpSNzeNGNy8/9k1r6IE1pQdT16E6Jzw4o2HsCFwzfd8 KYZ+9uSO+w1MLuv+c0zhxhKcbG9Og9q1wfUaBpIgWXxYO3eP1MUO2S35gAy0TWemj83sNW P/q0VBQt/N6EGuTN4Sgq0dgrs6pVQ5A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682691399; x=1714227399; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Pcj+cSdQdRCCbV5iccXjACQN9M1g+OCjIGDd19j+Ffk=; b=dRrMVyLZiDXDDTIrIjpVvvtDiAM60pnAWVmweCNroVhM4sgLjHeLoNVT AQCNiL4siTn5pec53GTaGh9ifQmFO/uv41gl5u4xpLXObZOxrFgDTJzAX xWHs58LhmAAjd6yXgbxcwqnxNiiV+xX63r7o1YWKYLjUnJHD3lxVpiO9f oSFFbk0wgku7VwSL/ktNiPV+7PrO8DIlD45rKaNsxmJ76zhb5PAym5Nw2 ugJa+37DB4bFh3sXXwlM1XAKUezqSX1L8hsW1gzXSPzVs8bsHqHtw9L3X DBa+a3rUqwMLiDUYayPPz5QHhNtgbhJihZWXeHNVXQGjWETAQrVNiwvlW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10694"; a="327381917" X-IronPort-AV: E=Sophos;i="5.99,234,1677571200"; d="scan'208";a="327381917" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2023 07:16:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10694"; a="694814597" X-IronPort-AV: E=Sophos;i="5.99,234,1677571200"; d="scan'208";a="694814597" Received: from lkp-server01.sh.intel.com (HELO 5bad9d2b7fcb) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 28 Apr 2023 07:16:35 -0700 Received: from kbuild by 5bad9d2b7fcb with local (Exim 4.96) (envelope-from ) id 1psOtm-0000Ue-2V; Fri, 28 Apr 2023 14:16:34 +0000 Date: Fri, 28 Apr 2023 22:16:00 +0800 From: kernel test robot To: "zhaoyang.huang" , Andrew Morton , Roman Gushchin , linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [PATCH] mm: optimization on page allocation when CMA enabled Message-ID: <202304282118.os2SZpZS-lkp@intel.com> References: <1682679641-13652-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1682679641-13652-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xrr5as6m1gaojffnwhhhrqcx9irk4744 X-Rspamd-Queue-Id: AD40C40013 X-HE-Tag: 1682691399-285856 X-HE-Meta: U2FsdGVkX184pP3JsOPEZIoatdEgyLwX8Brh9eKllmBVN7H5Fn+oODPpToXaSWUMAll6NfZyCI5ihTn7T55qeD66vLMk6WMeX4Bi0xHekI09dOEYGpqSo6ptiCUsO+68k0b4PaObGui8vwG+ovXQhqaaSgJo96r3XpTdVGIpbTNpnp25ls5goI++fIvnCQHdSXYuL57Ep1sltX87cIHsbOLrc99Tmnyw+jcv7u+ryG/VG++V6fSvlMeE68r/HdAimSYR8WpqP4POKFRnebU+qHc4g8sM6m6yhJfIfeIYvWZWWkpr/5uqmJ/VOJFwEvvP++VyRQ5e2g9Rh4ghRScsKXSzb32jDlnqnAm4tXjcwWgGp9hHWPU66Xn7DVBNkh1PSqlDnBFAkx2i1IXQg5dheTIFPPHutArIqA/RieI9VqInd/1EpO8m/XITxg9dXNFS64h0nCjcAknPbL4prQNa6onkGvTgK9DJcOjsFp3po4LtvoFZePwbVd2Wm+ma9i8NlVIN9cMASBwmBS2sT0jsl3nX3VmSV9jNzupdUi194dKgoFQ4xbc6t/1npG0740csHTgr1Zodr+YRnMdD6PBYRA8jkLPw65vpFMFTc20aKcOeyWTL4G9KDYuwH8TuDbMhkmVUx1mNO5cWBcTC8mzU0kxN79xoaRk4LDWC+BI+cOBv44UraeJPOEhxAaoGLvkW4YOHu9/wkWVkdRzKCxHfnRFUwpsM7q1kuPKt5wy+pFeV+V1CwRCprnMJ+T8Y7bIch87TKylw/66VWNntmQekK7nu/1T4qhk3n4IMklMKE7swrVo0trvgtIYj51+NV7V8NH+nAs288u68xtn4wXC6y5jRkRbG/wXMIAc7jB6627UEtaFF036EuIdiTdDRi7HpDyRGijkVPjddJlneAoUsL2R6rREZF/txA0ifl27+h8s6L7Z3s/CQOBTbtB/HhhJiIT7yJ2OMfB+k31oJ+D9 17FUZdjD K9kJZ/XCqPkYuKLNNrIuqmN8YD9dZrhiwetsYCMjiPjn8xzjcKH2KmfH4N3+64Yh8Mf+wVSlSi0KntWP63V7pl2xGELAhNZ4SMOrGXEeRmzAHQ6bcUZ0MUPVzCUI9rXce5CzBAWTM4tlrcV2XrFtLiAapZRKB+akZgh0n0psT13Sx7yCsGkiBU+8qpx5ROZdShMNPiL55L6ueVo5f4HMMRCvrVPxaovS4vNX/Z+cnCm5pGV3mV2Urc792KeT74WFS6r9097GqwrD8epJ5y8eavmGZVQaIZc8QfoOzcBznL+kpC9YisKnBvE8NVB2ubT046jZfcnsv0sNfnq5whz4mo1zSFSY4yKshLHIyVGvTRRArukKjuClROsAm+ZDaduqQvTCO24HafnNGbKgjZi+GiOLmyeQ0bune3OXiPU6HLSeqo/I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi zhaoyang.huang, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/zhaoyang-huang/mm-optimization-on-page-allocation-when-CMA-enabled/20230428-190140 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/1682679641-13652-1-git-send-email-zhaoyang.huang%40unisoc.com patch subject: [PATCH] mm: optimization on page allocation when CMA enabled config: alpha-randconfig-r014-20230428 (https://download.01.org/0day-ci/archive/20230428/202304282118.os2SZpZS-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/dbda57eee661a0c9b47f23720bcc9741495d00a5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review zhaoyang-huang/mm-optimization-on-page-allocation-when-CMA-enabled/20230428-190140 git checkout dbda57eee661a0c9b47f23720bcc9741495d00a5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304282118.os2SZpZS-lkp@intel.com/ All errors (new ones prefixed by >>): mm/page_alloc.c: In function '__rmqueue': >> mm/page_alloc.c:2328:42: error: implicit declaration of function '__if_use_cma_first' [-Werror=implicit-function-declaration] 2328 | bool cma_first = __if_use_cma_first(zone, order, alloc_flags); | ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/__if_use_cma_first +2328 mm/page_alloc.c 2277 2278 #ifdef CONFIG_CMA 2279 static bool __if_use_cma_first(struct zone *zone, unsigned int order, unsigned int alloc_flags) 2280 { 2281 unsigned long cma_proportion = 0; 2282 unsigned long cma_free_proportion = 0; 2283 unsigned long watermark = 0; 2284 unsigned long wm_fact[ALLOC_WMARK_MASK] = {1, 1, 2}; 2285 long count = 0; 2286 bool cma_first = false; 2287 2288 watermark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK); 2289 /*check if GFP_MOVABLE pass previous watermark check via the help of CMA*/ 2290 if (!zone_watermark_ok(zone, order, watermark, 0, alloc_flags & (~ALLOC_CMA))) 2291 { 2292 alloc_flags &= ALLOC_WMARK_MASK; 2293 /* WMARK_LOW failed lead to using cma first, this helps U&R stay 2294 * around low when being drained by GFP_MOVABLE 2295 */ 2296 if (alloc_flags <= ALLOC_WMARK_LOW) 2297 cma_first = true; 2298 /*check proportion for WMARK_HIGH*/ 2299 else { 2300 count = atomic_long_read(&zone->managed_pages); 2301 cma_proportion = zone->cma_pages * 100 / count; 2302 cma_free_proportion = zone_page_state(zone, NR_FREE_CMA_PAGES) * 100 2303 / zone_page_state(zone, NR_FREE_PAGES); 2304 cma_first = (cma_free_proportion >= wm_fact[alloc_flags] * cma_proportion 2305 || cma_free_proportion >= 50); 2306 } 2307 } 2308 return cma_first; 2309 } 2310 #endif 2311 /* 2312 * Do the hard work of removing an element from the buddy allocator. 2313 * Call me with the zone->lock already held. 2314 */ 2315 static __always_inline struct page * 2316 __rmqueue(struct zone *zone, unsigned int order, int migratetype, 2317 unsigned int alloc_flags) 2318 { 2319 struct page *page; 2320 2321 if (IS_ENABLED(CONFIG_CMA)) { 2322 /* 2323 * Balance movable allocations between regular and CMA areas by 2324 * allocating from CMA when over half of the zone's free memory 2325 * is in the CMA area. 2326 */ 2327 if (migratetype == MIGRATE_MOVABLE) { > 2328 bool cma_first = __if_use_cma_first(zone, order, alloc_flags); 2329 page = cma_first ? __rmqueue_cma_fallback(zone, order) : NULL; 2330 if (page) 2331 return page; 2332 } 2333 } 2334 retry: 2335 page = __rmqueue_smallest(zone, order, migratetype); 2336 if (unlikely(!page)) { 2337 if (alloc_flags & ALLOC_CMA) 2338 page = __rmqueue_cma_fallback(zone, order); 2339 2340 if (!page && __rmqueue_fallback(zone, order, migratetype, 2341 alloc_flags)) 2342 goto retry; 2343 } 2344 return page; 2345 } 2346 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests