From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64108C77B61 for ; Fri, 28 Apr 2023 13:24:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF8166B0078; Fri, 28 Apr 2023 09:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B81796B007B; Fri, 28 Apr 2023 09:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A21B76B007D; Fri, 28 Apr 2023 09:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8DE7C6B0078 for ; Fri, 28 Apr 2023 09:24:13 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 49581C0163 for ; Fri, 28 Apr 2023 13:24:13 +0000 (UTC) X-FDA: 80730868386.26.5C22DB6 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf15.hostedemail.com (Postfix) with ESMTP id 94F93A001E for ; Fri, 28 Apr 2023 13:24:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ExU31UHi; spf=pass (imf15.hostedemail.com: domain of 3-shLZAoKCOMdTXWdFMRJILTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--yosryahmed.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3-shLZAoKCOMdTXWdFMRJILTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682688251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=WHCBk5ekoAeggcfMzSItuZKOWJ2+XlF6kZloOg6sBWI=; b=dd5FZUR8L70jZzRgepvjkmiSmhWuRsCdT3/5q9ENRPTe6PbYBjEHTzlcAbyUg2D7wVWC92 /gdCZKoNrc20khM52hLzEeVN7i2jH3C4vFpFp09iUJZ/Oy6ejmm5FnXYCcSk3moTRM2M1C 3OrZweL4FASrGsnhV+V4siiphSMnUhs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ExU31UHi; spf=pass (imf15.hostedemail.com: domain of 3-shLZAoKCOMdTXWdFMRJILTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--yosryahmed.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3-shLZAoKCOMdTXWdFMRJILTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682688251; a=rsa-sha256; cv=none; b=ewVPEtLXLuj6AWHXBx14Q1Sn55gFPKbUtptLBTsPewuCz/8koigSL/BBd/WYEZd7QVP8+8 2EMIj3nNYue+zkszI8YCbd3x1bTFUazHd8qZr1SzYXS5m2UOnwMQIOQlTi2Ki13hIecyYF 6mk3ZciiQ526bw3NqukMgPoCDZirtos= Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-64115e69e1eso10532950b3a.0 for ; Fri, 28 Apr 2023 06:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682688250; x=1685280250; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=WHCBk5ekoAeggcfMzSItuZKOWJ2+XlF6kZloOg6sBWI=; b=ExU31UHiJbjXrqTR/RqtL1j7rtOUfrWye3kSIY+A9bN+qQOyMIen7nZ14d0Cslj/rw 0K0Bqef8k5GwIXCOnaTSAtRwXteDZmLIh3M61j5KjQlBPVJeSd7nlkWo+zsS3dmJYcg1 4kPNtWe5dhSdiycCKhAgpILFExYKaISctW+uSpbiivNtdrGlhP1C28da5SqI+Iiz/NK1 BUf2RYaYobH43+xZz2BSvVquZXldFj1iCvK92+4k6ySBsJwHjva5lbQtAhc1AiBKG1pL LpsLc8MUIU41XiyWbUGY1rpSwpiDqSKC8VLyEJxX3Lg3X0R8kl5GTNZ9vmj9HQs11RGP 83HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682688250; x=1685280250; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WHCBk5ekoAeggcfMzSItuZKOWJ2+XlF6kZloOg6sBWI=; b=mC1iiAnrXXrLChMBh69Uz4NS2ROJNvR4Rq+0KOlKH+FGZ9KKTRhyoFzelHU00eBjQn VeNovRLWs2Ml4EOlPaSuMeAG2Iok/uvYfh8XV7NQxBCCv/rnTeYKypVwZrzk80SvfhSz v4lpcdTfN3mtQDo+Fel22WO8uOBKfz1n1oF8zeEeX899zogMJwyzQBamIYXfkhK+Y7sM EKNncg7B55Do0pNGmfac8KLS5Dix8tdk+w7nTrnVAzvNAMMWfHqiZfrypohSm55yvvaa 5krdqWL/ibgLLGI+kckM3vwsdcLfM+VxufDLGvbTZutB0x2wJCuFt2UXLoPQMIhqz/6t KEmA== X-Gm-Message-State: AC+VfDyjQ+V2OpCsAnx54QKODWwJcTeCGyb+8SW69XsZ/IpasNcObVtd zJKStxe9LFSNLc4WVRtxdGxDAWHNQnz6bIx0 X-Google-Smtp-Source: ACHHUZ5yDwP6znzISpEDQqOcWA1LzG9974vmTJ9VwtAXQ0FSs47oGTk6dHRKZ40/nhBwiSptB2LvFwUEOvOcf6L1 X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2327]) (user=yosryahmed job=sendgmr) by 2002:a17:902:be05:b0:1a5:112d:f90b with SMTP id r5-20020a170902be0500b001a5112df90bmr1728309pls.1.1682688250374; Fri, 28 Apr 2023 06:24:10 -0700 (PDT) Date: Fri, 28 Apr 2023 13:24:04 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Message-ID: <20230428132406.2540811-1-yosryahmed@google.com> Subject: [PATCH v2 0/2] memcg: OOM log improvements From: Yosry Ahmed To: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton Cc: Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 94F93A001E X-Rspam-User: X-Stat-Signature: iogcs6a93xqxa7494wy1c79i1uogjywx X-HE-Tag: 1682688251-484626 X-HE-Meta: U2FsdGVkX1+0JqUOrLweYxLre6gYOURFDJS65CuxJ1rzmKm+bQBGCCqcdQVdvlo5DhCdc+aXQIMHo0qdP+7rIxd4oc/nfM3lP1zdrPOUcKN1f1l488O9uEg4EQyOjthv1crE09jtCgFqgHT+EexZePHqtD+49zF3oGTm2UkSc1Xe+dxQFBKiVW3FR3G7eLvymPv/N4HI9+WZysyLnh4tmUuEuSly9YYZUW4jsKOnacZOsBHfJJ+3vs0kTWWTOdZ4Iq44sBGkUQpSaBYkZB/WA7VXZUxieErRSL37DgUaQ5AsATlh9k8rnYrgUAWngFLUvoyThzxZMfkU03qtPm5pQID3xObX/kWzWvbJnLdPgvJWnnGUa6Gocxg8Fn+QCk6X/CcGVM+3ag/MkVjltEdfPy1h12pxtWEv/LP9z/cif6qqTrvMHNKGcODRSnAkM8nn7fMnVuERy8jhtEN/jkUTpeYFMInC3AP2M1jzZ5D5ooDKc4LanEBlW93Xs/+NRLWUeW8393z63v9iM5QJ/6zPFVxFuw0DNuHZZTGBEJ0FPzG7eSvBathXggHk5McHzSXr+7eKgN2TEqG2M55gMwxy4t/iwNc/nHyU56JWcGR0VupNcTv6nKiZae51kIG2jmXfN65jzPL30rkqVRQfop23phPL9+mQaviPj6JTT686jhaBZYi4felYmAUZY6aQkbdH66GhCIKtKQ3F5qYu/IucuX5gjYVP0/lFjs5FvRznIv74FawSsbjjF+V21r3P9kUO7Tclcoz9k3raGbo8qNPBsAGJNkFMY6esGgSQ0nXc6Pai2X1ftnhGyDLll3nzm2170oss/EufDriM6GppI0H60qiBf617A3wk8hCgONBCcRoYxz/lxXSxrnncmqpJEop0Gejz2WQn+wgmKprgzG+IJdLKPulEaG2JTVowUDFhRDQ4YjB9mpQLjUxzad081A17XVyj4AYq9foUZf8WOGG SeMCa7rL NSs7Rf834YrKOMRRqwIkoeXIJY4c98EXY1T/onCYVcC3wpye4Y5E+KgIfXkrMl4+ztSJwIgvUr4hbn9nQjeUTTaePmMt2DoytJgUBanUoeS3jkUgb3DD2OT5wRIf8mbKpYGiHHeFV/oH8FLpkiBkK/JkwtiJHfNcake6MUGkqZPK1NvjBqqM/zrV+uHkZLrI74tiohOQyYY1ZSb0excchjCPBsHFhvJBZtFmkTtoK0+0NGLhTOQ3oFmkmOeoyPwjeH24vbBrdMrXdw+a2botx5ShTiDLI+ImJv091HD1OFlqwcKP8rvm6d3cmn9MxDYN6VwGqFUjkQlsGXf7jvWhn9kaem4rcnjANix76lRUgL7Ok21PQyedYGu836hVFvGGLEDMo+Hq29VvcrTYuf4Uf7jhxp/n6qCPnXP4FJ6YjDStSEguTucA80zPsee4RDf1elY/MDtcxepX4itZYH0zTciCyLT9wyd3X9NrThW3LltwgdO3o5jJFerrEDAasvyt6N4vVZPU5IC/AhY9q9smPLHhkvLlaL3pEwBG+0lgZp+dLFE+TicpKmyl5xLkDmRdSg7TzG3jhzL8f/RviLAx3eLYk6fcIKfvgwUK97cuYyzOE52kQPY5pYiY4oGPtl1OZ979jK5mOEVqLnNXIxvj8Y5WbRxR7235nAHvZJIRxC2IeNYh5uieWUIPTl8PMvgQnVZo0YPsvNsCGXMKaTnEOHtzuIYq4is601tmcTvPylJ02tSU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This short patch series brings back some cgroup v1 stats in OOM logs that were unnecessarily changed before. It also makes memcg OOM logs less reliant on printk() internals. The series uses seq_buf_do_printk() which was only recently introduced [1]. It did not land in Linus's tree yet, but ideally it will land this merge window. It lives in linux-next as commit 96928d9032a7 ("seq_buf: Add seq_buf_do_printk() helper"). v1 -> v2: - Collect Ack's and Reviewed-by's on patch 1 (thanks!). - Reworded the commit log for patch 2 after discussions with Michal Hocko. [1]https://lore.kernel.org/lkml/20230415100110.1419872-1-senozhatsky@chromium.org/ Yosry Ahmed (2): memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo() memcg: dump memory.stat during cgroup OOM for v1 mm/memcontrol.c | 85 ++++++++++++++++++++++++++++--------------------- 1 file changed, 48 insertions(+), 37 deletions(-) -- 2.40.1.495.gc816e09b53d-goog