From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7056CC77B61 for ; Fri, 28 Apr 2023 10:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC8486B0071; Fri, 28 Apr 2023 06:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B77946B0072; Fri, 28 Apr 2023 06:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A411E6B0074; Fri, 28 Apr 2023 06:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9525A6B0071 for ; Fri, 28 Apr 2023 06:18:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 628D5A02EA for ; Fri, 28 Apr 2023 10:18:21 +0000 (UTC) X-FDA: 80730400002.03.73B7759 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 65AEB180009 for ; Fri, 28 Apr 2023 10:18:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=mhhECMNx; spf=pass (imf06.hostedemail.com: domain of boris.brezillon@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682677099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8yExguc1oTTRtr3DXEj/w82MFM5wt9uV7lEcUeLaq6Y=; b=1UdMXW6a+cJopTc1SHEgXpLuiZsgjEc6274nwglzwKUqvFA9NT6hPB4on0KfxVp7aX6Jk6 MhXeuPJ0KWd1TGREih/AtQDmeeWB3cQjAMRSPwFG4THRhlN2PAGp/xoHRo665MM36KcqSv 0fdukTKsRYAwsO/oW513dDnU112NAjM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=mhhECMNx; spf=pass (imf06.hostedemail.com: domain of boris.brezillon@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682677099; a=rsa-sha256; cv=none; b=hW0dHFzLr7bDK2gICqUP2YK8oQlp5O0qzvJhspVaIgB7ggG1h0oPgEXsmENPWJIXmb6CPn zdwlsORK6mXdMhJ7ussS8r8Uz5uV0t+HywBeV4FTuMreiwekfzGb5bEz3rLcko7t8Uc5Iv unKvyJAFsW5TbcNfAIePuWqhhL7jETQ= Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 265436602097; Fri, 28 Apr 2023 11:18:17 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682677097; bh=Yk5D9b+oPUkoCZwzeMIIJtHOgvXide7fZoW+I8ghpV0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mhhECMNxkLs1iW+QaB2pRm8nUySryOtAT9Y4NOyMqr2EqHYzZmpOT+adaU6/ID1a9 no1OdnK+ALZIj8/C7cBWw20X2bNzE89ZFuf6mYMbos909zeCh8D7m0E2UFsLyi3fri MJloqfSnhMn9R9NfMh89i03ukNYFMrsV08bymj3SSPhXtXvaNygxNTThFredKI91aT E3NP3647tgYI23H9PtLyuLvhEXAJoK4jHGAjfi09ZqIlAzfKWTKK6G/5bZj9bKGvUX sM8uGnfSD66AngdfS1WteFdbKzplq4xmhjx4GPFm5NVhHHnboQ0n6DZdSmsdshX2G0 mCGmVSSVOfJmw== Date: Fri, 28 Apr 2023 12:18:13 +0200 From: Boris Brezillon To: Danilo Krummrich Cc: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Airlie Subject: Re: [PATCH drm-next v3 04/15] drm: manager to keep track of GPUs VA mappings Message-ID: <20230428121813.309ea609@collabora.com> In-Reply-To: <20230404012741.116502-5-dakr@redhat.com> References: <20230404012741.116502-1-dakr@redhat.com> <20230404012741.116502-5-dakr@redhat.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 65AEB180009 X-Stat-Signature: ie8y4kz1qmux8c75o9q61odkgamutsmx X-Rspam-User: X-HE-Tag: 1682677099-997667 X-HE-Meta: U2FsdGVkX1+NITiJuNyu3dltTCiz+c6XUBTIZb10EbYaZ0B/PcSCYw8fLXq41RuE6mVuU2AHx7GF/E1NlpXNDvpN6IaVLQq+3RF96TOL80KcjR8eSEfAbCr4GDlTE/N3PorvqemExLaMq2bSPPa3+AQKcfJpm6gVnMIRC/rjs2/FMRXH6MKJm7a+AadkaWGExK3qy1E3IjO+kMM/J+lKo2ENlq1hisPaUmcvU0s6Jx31oOlyTc7dWfoELZwneh79pDcfwoul48+mDwb72jQEfCxI/yZu+YQ4n6qlunPQEzU3tU+D+L6Sv/PUVUMQK170RWyhVhoPWIbNnXC0P0HcH2QRGhPZrVUSfztgtWcVOot8zotA+/HBu4F2Agg8Qd0ixiyUuTx4nx37Xz8SLm8YczbwT65QRvwFgB9IStAuexKjZ3YWEcXZ/1cEFNNZnwjg2CGmzmxdGQ/u/jCYhpK/vnhCYDsqGtJyVdUvjBSdN6HmzKUPPxz6fDozstkZlps2ELPd/XOE0naCxJNIuwBa7j82P+4jri6snWrm7nAK64iCsxGZ/5RCfamMaK/Ka2mXreKop5dg8fOaDhfJNNCOGAIY2mcTLhfv+8T8k0I2gPp6QZd/KBKZRVM0fSSTwiIywJLKyx/z/Mfhrrl2DiPI+8+JXVcWhfCcIhWHZd9eG0MCzXEzrjjv32CTg4GXm8XWcE4jZvVZdMDjA4gvXySMIY3sz8SxcFmjTlRRgQJ8lxPQn0ctjylxXIrdVxgQRRMVU21lFRYEJon1MrujeTSmhRCwllf6p4Cdtb2qDGLH3u52F8dr8XJTIxDpeuTk2rSkrgpX8FdpOUdQyj1YjuBIEddMW+ZbANuQzyk0+YV17uAlvaSov9xWCCjPNPULPRrGdazr0R4VCX4Pk0+kOV4RvW/J0bdhqvuush7JF8wGWoUIpahrEjXauxA+wL4hJzLgsVV5AAI8o1wAdwyM4Vw 2MY84f+Z k3bsMjkWM5SWwXuIU3wX+ZcRjwPKEDg8k3D8wruU1QyFocIItJA7vF6oeykQHd4+U91wAiKTgC4+PYouqBLF0lenenpoie7ov/PTSI7IGwC9Y4l3wf/EXH0ojYQlb1gfTbOulD341t34STAxvkXVBDpnENGnJSGmYRd0kSh6OpX3/zNI4c3SbpZx8koDkLLhcUh7NJdbAzFgNDAZomxNKzF+CjWyP7e+lKGbnp+Sz/QZ4Hjz4KPV/ajVEFIu8TG4NdbIA33iIh5BDP9QvbtkfPJuwp3jQhnf5OkV0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000104, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Apr 2023 03:27:30 +0200 Danilo Krummrich wrote: > +struct drm_gpuva_manager { > + /** > + * @name: the name of the DRM GPU VA space > + */ > + const char *name; > + > + /** > + * @mm_start: start of the VA space > + */ > + u64 mm_start; > + > + /** > + * @mm_range: length of the VA space > + */ > + u64 mm_range; > + > + /** > + * @mtree: the &maple_tree to track GPU VA mappings > + */ > + struct maple_tree mtree; > + > + /** > + * @kernel_alloc_node: > + * > + * &drm_gpuva representing the address space cutout reserved for > + * the kernel > + */ > + struct drm_gpuva kernel_alloc_node; > + > + /** > + * @ops: &drm_gpuva_fn_ops providing the split/merge steps to drivers > + */ > + struct drm_gpuva_fn_ops *ops; Any reason for not making that a const object (same goes for all the functions being passed a drm_gpuva_fn_ops)? > +};