From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6469C77B73 for ; Thu, 27 Apr 2023 14:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C829900003; Thu, 27 Apr 2023 10:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17AB86B0074; Thu, 27 Apr 2023 10:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 040A2900003; Thu, 27 Apr 2023 10:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E5F366B0072 for ; Thu, 27 Apr 2023 10:27:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B46BD1402AB for ; Thu, 27 Apr 2023 14:27:52 +0000 (UTC) X-FDA: 80727399984.02.B53BEDB Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf23.hostedemail.com (Postfix) with ESMTP id B1E35140021 for ; Thu, 27 Apr 2023 14:27:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm3 header.b="ISY/db0+"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=aXBHwX7a; spf=pass (imf23.hostedemail.com: domain of greg@kroah.com designates 66.111.4.29 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682605670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a5ON+ne5HB5nl4hoXlBqXG88QwWZJREMnOBOsnBrRv4=; b=DG1BxmH3S6fJ65wBf8v3uHywbu+yBV50vHpaQ6GSus7A+BjPzYY96kzIdk03FoJcRdl+wh hfbbjc/yH4yEZwBqgXtz8iaGK4KoPlHrJ4BaFw9Iw98zGyRG/Q8Yygq36VZ3UWZ1Yi5iKJ tiHh5/F64cllkTL+jDpbbge09j+eV5E= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm3 header.b="ISY/db0+"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=aXBHwX7a; spf=pass (imf23.hostedemail.com: domain of greg@kroah.com designates 66.111.4.29 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682605670; a=rsa-sha256; cv=none; b=wqCnNltKTiXHUnCkUzRMVxfM+sXfXjGuKGe5rpHjcawjFTzq5tkKMacvNTMx4roqq5AxdQ bTnGbOwuFAzuTU5O5bw/MvwiGJCEiPw81k4cQgrFvTVL2FHkTWjrDWx3oB8rsuQidge3df WNM7sO4ts1a2uRm/2OPjnP6V8gG+fBw= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CC8405C0207; Thu, 27 Apr 2023 10:27:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 27 Apr 2023 10:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1682605668; x=1682692068; bh=a5 ON+ne5HB5nl4hoXlBqXG88QwWZJREMnOBOsnBrRv4=; b=ISY/db0+zxp0t+fkm6 0n8WaCGUVCEHTBbni4+YEjjkmEErP7gn+L9QLMUJg7GyQ7ECHEzfSONRIkRmvKRl 2tlhtbdncGXxvhrjJpOqFtefmejXFiwQiB2jyj4vvF+Xvddc6TvPuFTR1FaRHROZ VX+SoUKD9hG7vsFBmzmJYEBJdc9CdSNDdacPWzZZaFanjBDmTjDrYQ9N6EIICsKE YfTsRO0hAsqxe7BF45/Gwxy5ZPH8Jh/ANQNHmZn4tBhRxqND0DtpzdEwm5MNAdfp V7Yd4iU8kZpIH2G+YKHcpTdHnqHVKpb9xEx/YhTx9HD3NWGuj3g9SX7PwMnLjF79 I3UA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682605668; x=1682692068; bh=a5ON+ne5HB5nl 4hoXlBqXG88QwWZJREMnOBOsnBrRv4=; b=aXBHwX7aqpVMTGsBDB+J9sN7vjDBi fKlo4XFYo6ZadStSpctoUaLLB/sEYz1F45U8O2PBjqrsdEv8cULZnl6SQYNpsHWA gSS3Q8IHQ5xDZGNQ+/3zyS8hiYZ451W/EHVe7l+6WQG6trnTFUitwS2MzI3b6U27 z10RS84dhRwbNtJuX4cSkXH+EaQU/XSJC28FEXx2rVboMY/SlDz1z4vizdat89gF +aCImjXJVVan1tRWkRfO8XYlxN1iGdJgnTCzSznGuxlI0sSQW8I9c6DaBTByt+lG xU4TjXQJ6WBeXBexyOUizntMGrXwvv0Ho63YdeBtazRr/hIDamDAALPdw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduiedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepjeekue dtffeftddtvdeggeffjeeuteelhfeifeegheeufeekjeevveelueelfefhnecuffhomhgr ihhnpehsuhhsvgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Apr 2023 10:27:47 -0400 (EDT) Date: Thu, 27 Apr 2023 16:27:44 +0200 From: Greg KH To: Vlastimil Babka Cc: Andrew Morton , Linus Torvalds , "Liam R. Howlett" , lstoakes@gmail.com, regressions@lists.linux.dev, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Jiri Slaby , Fabian Vogt , stable@vger.kernel.org Subject: Re: [PATCH for v6.3 regression] mm/mremap: fix vm_pgoff in vma_merge() case 3 Message-ID: <2023042719-stratus-pavestone-505e@gregkh> References: <20230427140959.27655-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230427140959.27655-1-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1E35140021 X-Stat-Signature: wosfcry5c6eti7x7yq8fpwbezcc81mtp X-HE-Tag: 1682605669-65894 X-HE-Meta: U2FsdGVkX19/f/wlh65t1Oub6NyBkad5kZJENINrr7ebp9W/0B/mpkMrRsdt3OvDGvLmeqthrWXd+YhsfIf8IlKyeLTGlDXfPqnhufdSygsHJuK2uy3jmeVh/y5TkizM/MohZMa0YZB2AxkoBJTJKfh5LBIwm8wj9Qnzx7NwftPQr1g8W/MM3uBvP7T31YMHJYALuU7h/MBTYeFJqLDtdMcOsZKNaGUi5YRhOVPcdg/EauES/u4G1PPsuxzIgR9akRftCDEZ9uQK5rZnDZF7NlAPFycHyLWIwO8XePqfKiuXgYV//aZJ6D81yp8U9QM+TDHFybpcA9hNVgiIdT/iTEfRZxqhtn6Rriaf01VEzufoTy+6UYbpWMgG/a8xZ44iRmEEGLltp1IfGErra21U29PodrukjudsIfQMLiO3pnBlyaby2N+c+Zwpaw6eUDheJEvCvnCpHxP3xE4NYPGDFsdtH9gl7rVYmVn9hTTwKWFNQhxhM1kMpCYKvW1skxPOwl7H9MlxIAZ01beG4X8RJFdgh6YSOGwdH85hdUx5OdgI72vV6PIRSPP+cmwwZWbowSaPqUJlJUIATdM+r/mwfdG+JQhr6yRHpTYWZeJt9k40YoEXrROE1ArVNdHn4MkHOR30vsx50g16h8223TEvjCctbS9K6qabRopku489f8bkovq7AMZKcDEeFBXzg2HJuwNqIL+b2BB5Unq9neLN0xYWOkj/VVlDnaM+zzp+AV6hatJQkZUe3hIawRx6QVgZhGN04pjsHyE5Q6peSDqkv84EiieaC5kCPa1Fkj9/a7FWcJ3e53euqqzYAPt1Ixbuyl0FJdJhAOHHNsEI79uC929CMhax0M/fQbiL2f2NASKoPyoAuEDU7JtQaUmoeWFAySWh4Ra9MPk3XaAIph58ON66zCmzABIfskPT1bg/xL7fhBIpn9QAhCncx72E1NWIWTaonPeHGRBAnzwDLRL AShOSMgk uRKjF6zsQbOnnbvvhAComcsfCgiHuzvuxw3veQ7b3ZYcBt2bx4Tox2iKjTbwGLTEeeA8gR736PsBkHgKkTHcwwbHB6jrLq4vTC/KslR6APmik2npcf8Xy+7Ts3FRWBJoi5WUjWlSaHnmjoX5wSG/qGzC8vHSCRz0tsrPYm2zARgu6exw68EUTg2y9UtOafb5LgLh8PDF/1B4o1IX6ck+QrHBs1rEvv9ZVq0YSnRGW47wdA+wEpjgODX1EgV1q211x4vj802CKZuOMsbQhN1F6Aoe26V0Exew99ZKTziJXuyGS6qnc3+15FJxgjHyvFRIrc9idLS0SKTcPpfNM7el+pV2hwrysglDqLZfx5HN8/RZbfz0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 27, 2023 at 04:09:59PM +0200, Vlastimil Babka wrote: > After upgrading build guests to v6.3, rpm started segfaulting for > specific packages, which was bisected to commit 0503ea8f5ba7 ("mm/mmap: > remove __vma_adjust()"). rpm is doing many mremap() operations with file > mappings of its db. The problem is that in vma_merge() case 3 (we merge > with the next vma, expanding it downwards) vm_pgoff is not adjusted as > it should when vm_start changes. As a result the rpm process most likely > sees data from the wrong offset of the file. Fix the vm_pgoff > calculation. > > For case 8 this is a non-functional change as the resulting vm_pgoff is > the same. > > Reported-and-bisected-by: Jiri Slaby > Reported-and-tested-by: Fabian Vogt > Link: https://bugzilla.suse.com/show_bug.cgi?id=1210903 > Fixes: 0503ea8f5ba7 ("mm/mmap: remove __vma_adjust()") > Signed-off-by: Vlastimil Babka > Cc: > --- > Hi, I'm sending this patch on top of v6.3 as I think it should be > applied and backported to 6.3-stable rather sooner than later. > This means there would be a small conflict when merging mm/mm-stable > later. Alternatively it could be added to mm/mm-stable and upcoming 6.4 > pull request, but then the stable backport would need adjustment. > It's up to Linus and Andrew. That's not how the stable tree works, sorry, it needs to be in Linus's tree _first_. thanks, greg k-h