From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B467C77B60 for ; Thu, 27 Apr 2023 01:07:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16D306B007B; Wed, 26 Apr 2023 21:07:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11DEA6B007D; Wed, 26 Apr 2023 21:07:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00C786B007E; Wed, 26 Apr 2023 21:07:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E5DED6B007B for ; Wed, 26 Apr 2023 21:07:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD1CC1A0404 for ; Thu, 27 Apr 2023 01:07:14 +0000 (UTC) X-FDA: 80725382388.21.AEB3CFB Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf23.hostedemail.com (Postfix) with ESMTP id D99E014000A for ; Thu, 27 Apr 2023 01:07:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BrybM128; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682557633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yWxN0HdpqE3nEcb94tpVaWre2EJjXxzqj1V4BeiGr4k=; b=BhlT1n2YbyhNpa4J3N93Iozo687EcQUk7kGS5ymJ8lePMAiAfqAWThTbYHXygJiwkVHXpn 5bwc4rUqMTGGFtTSGGcGVFZo5kdxiFY5NX450vJa8PB57kWJxBtFz69LvM6MZvitE7EuKP W6aMritATe/Jj7CAnhzR/2XeEpJCQyk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BrybM128; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682557633; a=rsa-sha256; cv=none; b=vm5wYMfgyosc+Fn0/NTzgbMpauHvkqqDQLV/4W+cD0L+5tHEcRJN0XHbSNYGQj6AlgV5sx tBYkxsSPUNGCkL4qzXLIXdBuuMIlm/SIapTo0AHXbvm7x9etwvEVvec3aaHTlpKTgRVf1K jbdUU7Oba+lIMKWG98uw0WvRMfP4ju8= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-64115eef620so1328655b3a.1 for ; Wed, 26 Apr 2023 18:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682557632; x=1685149632; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yWxN0HdpqE3nEcb94tpVaWre2EJjXxzqj1V4BeiGr4k=; b=BrybM128LAejQm/ZuKmsObyOmzrekJywBAYczMNylmOnjlsv2GAVaZnzT7mtEehlbs edNstU+IQ8nuuM/bsPh5eDUexDY5FDVJYEktDHcOJ/2R7qmryTU4RvyKMs4FwdGWW64y yxgZC7mizG9nQokYNIColNjB55kxHhnxOZIXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682557632; x=1685149632; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yWxN0HdpqE3nEcb94tpVaWre2EJjXxzqj1V4BeiGr4k=; b=fDgJF0o6rXsuJzV3ueUX42J1mga9HVUmebsKdiEMh2mJtZtWibjq1PnoGXziwOK0Lv w8Z/VPGUQ9D31tgTURZ9Iw8zqjdXrBbJgBV8ass6y4yevjxxgX1Y6LuoT5XNRI3ErPAw mpKQqLbc1nBeFE/dDhZqZVaz7HZJSPuL002PCo+EhXqf7fB7nnHVgDie96NYJ6jtyn3w E5UUVk79R+xOHjDnzipepgH6gQrAFFefpHXZ6pfUBP1ldyGOi15TgSMFn0T24YQmX93l NHakgo70wDrjhwHJkfzuDIxt20FyLkrQSZAGEERPH+B7W+sOU4iWl6WHexDK2SxASvU4 GX1w== X-Gm-Message-State: AC+VfDwk73ve+e25WgOUvyIfLSSkvixMB7hBUShHC0kquQAIMYHhtDr4 EL/qLhZynWQKs8Cm8VtqDfDqJQ== X-Google-Smtp-Source: ACHHUZ5IIgPQ9KvrurE6szSH0jhOKyONrDVq5eP9wwpRhBRRcdZRXDlJ8e3/Jpzh0f9dZTFLmYcWVg== X-Received: by 2002:a17:902:e74e:b0:1a6:7ea8:9f4f with SMTP id p14-20020a170902e74e00b001a67ea89f4fmr153135plf.26.1682557631694; Wed, 26 Apr 2023 18:07:11 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id q19-20020a170902bd9300b001a5000ba26esm10448485pls.264.2023.04.26.18.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 18:07:11 -0700 (PDT) Date: Thu, 27 Apr 2023 10:07:07 +0900 From: Sergey Senozhatsky To: "Liam R. Howlett" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, Petr Mladek Subject: Re: [PATCH 18/34] mm: Update vma_iter_store() to use MAS_WARN_ON() Message-ID: <20230427010707.GG1496740@google.com> References: <20230425140955.3834476-1-Liam.Howlett@oracle.com> <20230425140955.3834476-19-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425140955.3834476-19-Liam.Howlett@oracle.com> X-Rspamd-Queue-Id: D99E014000A X-Stat-Signature: hq4suxarh6hzi9dkkf1c381o1tmsjz6r X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682557632-807425 X-HE-Meta: U2FsdGVkX1/l6LJqiaw9Kfa7okbqOx0qigl92S20taPXjSC/k2SlAwzXBysM1OsgFRbgeEaPjZ1j4k4bqzJ89qHnkg+8uwWey+XtnFMzm0mVLuEbe6yw6eGUFr/G8mvNMnzYxjfKH7X3g47eorMNTyJp8QevspWb2fgBCJBVb/NhW9WGOI0N01a0SRHeFR6W7i3GdsAjEYtyj3i1t21hwd4WFF5W25V2nh99g83cxMwEEiAavu+cZs/hzW3EcFousEkkh4DNdbkfn2VEaBvFFS3TfLJ5vZoljTxYwTcNmur3ib2LzvD0xv2+quKVq4iytmh87iFfCcjS2ykzfgfodiqlrI31LtbEgJ9BYtLiUKAhE/hoHebb6AyQDg8gsakGy7esbK+pubzrxenOQ0O416HEEAq0wOlFszIotZSht9P/2x3TyIdx61gwi7idnRd9ZI4MXd6qcaPY8FBBbx5tDxtuiOPX1bN2vjmoAeBy+UOPjI8mDnhYwaHUX5D7rGU5a6vxy2V+DvdatH8UbrLhvJfoSkZwkwvR61rCP/T0K9V/kDL1Z5uCmhbUaCM4lQFDIu94vYwBxVpiIcyA2QLxvXOrCAPBjZQ1qL57BBdWodwmjrfz8MsS0ilJ2CHqdnSHtgV0yFqc3HyRSe9pp33SFONQPCLR871oZihs/LOmN7LuMWhOdyMZQTFZJezG+jpGjr/1u4/jyqgmAkQAKTpXhH6+M1sa+GHLGKxr98YAArd+EjsMZ1LimtbkEinaErZLag6KG0+oJVpH4B9/uMsW86HXTT42TGTqLVTAq7eK+BFtJlEhPX25GqX1hMwkSvVPJknryUr1mjUKotCShyj/gBhBzbS0PONIOEwRPdupzClUQy1ZnBN9/Hsb4RM8L6Qf+6kZPKFkUOAs9435Rec5PZHsUSJR9ha3LtVIve8rDtLQ/B7zL4syuHNhrCfFvujrxRFjB0FxCK70ijS1sR9 1w65LA17 uZfFkGC2kjzSt/bFp34yBEW2Pn+CMRrwj8sbPHsNJnTIELXV7KqUp3OX8TeFfLuNCazy/Vp8mWexz0hg51CdYPLMVAenW49riZEzPQxJ7MU6GaJ6v2dgi7hEP3xKd1cednHbiTGK8xeyLElU2/2TyCFjvAVLfqUywKPSWnGnCrBjLvF38IYTNcue2dbQm0HqzmsJtNVnqrs1pfNkY0J+mBXqFhD+1Af5+L4cNUOqsXAfsohBsEDCMS6fiJH3phzG5okKEGtPwqXd+kLILkOmHKn+Tid3CJo92OosshZIORW5VWa2e56zfiIPynRlgAp2Xd27y4JTRIK/xz/zmdiUL5fahLCWC5pmTGrOc2fjjOcB8yBc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Cc-ing Petr On (23/04/25 10:09), Liam R. Howlett wrote: > + if (MAS_WARN_ON(&vmi->mas, vmi->mas.node != MAS_START && > + vmi->mas.index > vma->vm_start)) { > + printk("%lx > %lx\n", vmi->mas.index, vma->vm_start); > + printk("store of vma %lx-%lx", vma->vm_start, vma->vm_end); > + printk("into slot %lx-%lx", vmi->mas.index, vmi->mas.last); > } [..] > + if (MAS_WARN_ON(&vmi->mas, vmi->mas.node != MAS_START && > + vmi->mas.last < vma->vm_start)) { > + printk("%lx < %lx\n", vmi->mas.last, vma->vm_start); > + printk("store of vma %lx-%lx", vma->vm_start, vma->vm_end); > + printk("into slot %lx-%lx", vmi->mas.index, vmi->mas.last); > } Any reason for "store of vma" and "into slot" to be two separate printk()-s? It's not guaranteed that these will be printed as a continuous line. A single printk should work fine: pr_foo("store of vma %lx-%lx into slot %lx-%lx", ...); The line probably needs to be terminated with \n unless you expect more pr_cont() printks after this, which doesn't look like a case. Additionally, do you want to pass a specific loglevel? E.g. pr_debug()?